Re: [PATCH 7/8] firmware: arm_scmi: transport: Add ACPI PCC transport

Sudeep Holla
2025-10-21T09:30:27Z

On Mon, Oct 20, 2025 at 06:37:31PM +0100, Jonathan Cameron wrote:
> On Fri, 17 Oct 2025 14:23:50 +0100
> Sudeep Holla <sudeep.holla@arm.com> wrote:
>
> > Introduce a new SCMI transport that uses ACPI PCCT (PCC) subspaces via
> > the Linux PCC mailbox layer. The driver parses ACPI _DSD data to map
> > protocols to PCC subspace UIDs, supports shared TX/RX channels, and
> > optionally sets up a P2A channel for notifications.
> >
> > Key points:
> > - new CONFIG_ARM_SCMI_TRANSPORT_PCC option
> > - integration with SCMI core via scmi_desc and transport ops
> > - response/notification fetch from PCC shared memory header/payload
> > - ACPI device matching and registration via the ACPI transport macro
> >
> > This enables SCMI to be exercised over PCC on ACPI platforms.
> >
> > Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
> Hi Sudeep,
>
> Just a very quick look in what is definitely a drive by style review
> A few things below.
>

Thanks for the quick look though, you have found quite a few things to
fix 😄.

--
Regards,
Sudeep