public inbox for arm-scmi@vger.kernel.org
 help / color / mirror / Atom feed
From: "Danilo Krummrich" <dakr@kernel.org>
To: "Gatien CHEVALLIER" <gatien.chevallier@foss.st.com>
Cc: "Cristian Marussi" <cristian.marussi@arm.com>,
	"Gui-Dong Han" <hanguidong02@gmail.com>,
	<gregkh@linuxfoundation.org>, <rafael@kernel.org>,
	<linux-kernel@vger.kernel.org>, <baijiaju1990@gmail.com>,
	"Qiu-ji Chen" <chenqiuji666@gmail.com>, <sudeep.holla@kernel.org>,
	<arm-scmi@vger.kernel.org>
Subject: Re: [PATCH v5] driver core: enforce device_lock for driver_match_device()
Date: Thu, 26 Feb 2026 12:15:33 +0100	[thread overview]
Message-ID: <DGOUMO3FAOO8.VAD47Q3CKIPL@kernel.org> (raw)
In-Reply-To: <5a291dbe-de59-4603-a712-40d4edc19aa3@foss.st.com>

On Thu Feb 26, 2026 at 9:54 AM CET, Gatien CHEVALLIER wrote:
> It may not be that trivial because unconditionally moving it to
> module_init() would not guarantee that the TEE bus driver probes
> before the platform device driver. I think there's a bit more to it.
>
> The platform device driver, as is, is not functional whilst the
> TEE services are not available. Therefore, it could falsely fail to
> probe if probed before. We may consider some sort of API to know if
> the services are available?

Ok, so there are three drivers somehow involved:

  (1) module_tee_client_driver(scmi_optee_service_driver)

  (2) scmi_optee_driver with compatible = "linaro,scmi-optee"

  (3) scmi_driver with name = "arm-scmi"

(1) registeres (2) in probe(), and the only thing (2) does is allocating a
platform_device with name = "arm-scmi", such that (3) is probed.

So, to me it seems that the indirection through a fake platform device is
unnecessary and instead (3) should just have compatible = "linaro,scmi-optee"
and return -EPROBE_DEFER if (1) is not ready. Besides that, this seems like a
use-case for device links.

Thanks,
Danilo

  reply	other threads:[~2026-02-26 11:15 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20260113162843.12712-1-hanguidong02@gmail.com>
2026-02-25 20:19 ` [PATCH v5] driver core: enforce device_lock for driver_match_device() Cristian Marussi
2026-02-25 20:38   ` Danilo Krummrich
2026-02-26  8:54     ` Gatien CHEVALLIER
2026-02-26 11:15       ` Danilo Krummrich [this message]
2026-02-26 12:21         ` Cristian Marussi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DGOUMO3FAOO8.VAD47Q3CKIPL@kernel.org \
    --to=dakr@kernel.org \
    --cc=arm-scmi@vger.kernel.org \
    --cc=baijiaju1990@gmail.com \
    --cc=chenqiuji666@gmail.com \
    --cc=cristian.marussi@arm.com \
    --cc=gatien.chevallier@foss.st.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hanguidong02@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rafael@kernel.org \
    --cc=sudeep.holla@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox