From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B3E702F2917 for ; Wed, 27 Aug 2025 13:13:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756300412; cv=none; b=cWK82028uCDjrPwCwvYz6cINEK6jb3cFDZLDwFg24k2mdomSHWF2Gsg8yCw2FN+79reU56Lbcn8Te6z07cip6sG8m4R+cqx2UV/cd61jQEdbzXv5HS7rPFVISTqpCf3mFiFv+PiKlzck/tPb3X4TWK31EuR1ydnnH9zSYzLd8uM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756300412; c=relaxed/simple; bh=eRhLjVe67iKErrxJ74pmlvZqDh8RQqKX7+TmAocxpuc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: In-Reply-To:Content-Type:Content-Disposition; b=JOOanlOw/4hQzRp62Z94ztseezpyNO36ok/e4VG2eb2mqq2eYHRNqswG14AqV9M31PZxki7NPJ+M7jUIhIg2xTOnQqg0Jf1YmYy9+3nQbcwuCfkU+z3pwQcdAu9LN+YXrgwRUgMnDnDid4HsF3ERRGd7+dXifkeTrkkEx/N/fQQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=F7cL2pGh; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="F7cL2pGh" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1756300409; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=13LJOrVZbt5/bZNb1010AyPGLHEYUJgw1i+wJLdf1Rs=; b=F7cL2pGhdjH3YvSDZHGj9tvpbXVyiaeuxJ9VyFYM/iFFrM7L3ehr1BbvFHet2y9z7Uq7m2 EkjNTwLQx/JrJLMymdl2ja9KLA/UuLRwbYoumxdWXYoX93MRxuvqNCDR5O/KuaMq5bRO0r MeeL6tnngeCo4LxyqWegN+kAxU24Oss= Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-94-MqPYeSmDNYK2LDU7oz0UOg-1; Wed, 27 Aug 2025 09:13:27 -0400 X-MC-Unique: MqPYeSmDNYK2LDU7oz0UOg-1 X-Mimecast-MFC-AGG-ID: MqPYeSmDNYK2LDU7oz0UOg_1756300407 Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-7f2942a1aa1so237767585a.0 for ; Wed, 27 Aug 2025 06:13:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756300405; x=1756905205; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=13LJOrVZbt5/bZNb1010AyPGLHEYUJgw1i+wJLdf1Rs=; b=CKpJPqX9hpfouZ2Dqoul6L5HE2xNd7aXW1b3eLmdBzL2i9YpXPQTfy3yRhIfnAWYU0 MZG4apALY4JrDaPrm2P5jpWMMoNYXfGKyeXFjtJ1F7J6VzpmILSZ95gt35pG5Y1obqLa qzaxjxt8SNFsqeBkbFXF5RBGzbFhv7B2ISDVGgeXUvD9ENMQyyuheMkRTNZUbE9ezp37 FRus7RG8HRB26CfzorhzjUZN3sTELQoBfD+k0qmiKKp9eqhSpa9yrLPqLU2iHNXyK8Jg FLbfVq0zQwKUt9oo9DZkT9+3il2mTbPm7mrMCIKkxDzzM6x28aeCSpqKYahoHd14SFaf kLZw== X-Forwarded-Encrypted: i=1; AJvYcCVsoRsGDvRWWuWCJ3kTjuhBudU9UrqzZJXp9z90MJpt8Bp3gMooTAlN/x9BPH4Rf/MH+0mXUfApMQ==@vger.kernel.org X-Gm-Message-State: AOJu0Yyi/OLxMizlrXVkg0F1fnvCyUgS+V39Xg8FKn0edhFKdFDn7Fv2 iTamSVOFHkYrOcmcz6yUBWbvyRjjgpbnAxiRn61xQ9gU1qzrrBy2wQHr47rfAZepK4/RzDaDk5y J0RAbGWcjFgSKcpV9bIXzwtqifMtF6Khy2usJ+N88Klye4JPCDSXDp3PhMonV X-Gm-Gg: ASbGncsKx7J+EnTEMv7yKJs2OqUFGx+ik4I1nvIQ9vLTXlqBcFjbyWIlN+ysnG8VfUk f+hKMxzQdqRfj5U3xPCj3/hn7BrSnDKk10wajsaSlye6HtO7+Fk9x9S8X2s6MnY5TNz3u4GsK4u 2M5Vh1hmoqSO06Uouvfq5/4psHthnjtNhYzNNVnIOFQYH5ah/v1nyg/S2SlV/xwUThq7lZFPxfY R5WSHRlviiAsVWaif+vafNkdchExo0dZVsZyI1OWQwFw3ZR0KWywpvsQnDT+Figqx1iJ/+BUXAI wvVXu/f8K9fIldAGG4FtVa3plWazXf1U1NQyIXpaWzVwt16RhQ1h7IUqbcwBRC85R6iJXeLr8Ho kMRnZ+F9zLHcMcfZ0lfA= X-Received: by 2002:a05:620a:7101:b0:7ed:92c8:7d16 with SMTP id af79cd13be357-7f58d941f59mr592256785a.31.1756300405070; Wed, 27 Aug 2025 06:13:25 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG//kDH7SoWg5eCSBiMLHP3nCnmfnmaReGS2V45T15TfIErjBPeekutHDc1uHZhw0fUtcQytQ== X-Received: by 2002:a05:620a:7101:b0:7ed:92c8:7d16 with SMTP id af79cd13be357-7f58d941f59mr592238785a.31.1756300403878; Wed, 27 Aug 2025 06:13:23 -0700 (PDT) Received: from x1 (c-73-183-52-120.hsd1.pa.comcast.net. [73.183.52.120]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7ebeca23e10sm885475785a.6.2025.08.27.06.13.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Aug 2025 06:13:22 -0700 (PDT) Date: Wed, 27 Aug 2025 09:13:17 -0400 From: Brian Masney To: Peng Fan Cc: Sudeep Holla , Cristian Marussi , Michael Turquette , Stephen Boyd , Chen Wang , Inochi Amaoto , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Paul Cercueil , Keguang Zhang , Taichi Sugaya , Takao Orito , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Jacky Huang , Shan-Chun Hung , Vladimir Zapolskiy , Piotr Wojtaszczyk , Paul Walmsley , Samuel Holland , Yixun Lan , Steen Hegelund , Daniel Machon , UNGLinuxDriver@microchip.com, Orson Zhai , Baolin Wang , Chunyan Zhang , Maxime Coquelin , Alexandre Torgue , Michal Simek , Maxime Ripard , Andreas =?iso-8859-1?Q?F=E4rber?= , Manivannan Sadhasivam , Sven Peter , Janne Grunau , Alyssa Rosenzweig , Neal Gompa , Eugeniy Paltsev , Ray Jui , Scott Branden , Broadcom internal kernel review list , Max Filippov , Matthias Brugger , AngeloGioacchino Del Regno , Daniel Palmer , Romain Perier , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Bjorn Andersson , Geert Uytterhoeven , Heiko Stuebner , Andrea della Porta , Krzysztof Kozlowski , Sylwester Nawrocki , Chanwoo Choi , Alim Akhtar , Qin Jian , Viresh Kumar , Ulf Hansson , Luca Ceresoli , Alex Helms , Linus Walleij , Liviu Dudau , Lorenzo Pieralisi , Nobuhiro Iwamatsu , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, arm-scmi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, sophgo@lists.linux.dev, linux-mips@vger.kernel.org, imx@lists.linux.dev, linux-riscv@lists.infradead.org, spacemit@lists.linux.dev, linux-stm32@st-md-mailman.stormreply.com, patches@opensource.cirrus.com, linux-actions@lists.infradead.org, asahi@lists.linux.dev, linux-mediatek@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-samsung-soc@vger.kernel.org, soc@lists.linux.dev Subject: Re: [PATCH 112/114] clk: scmi: remove round_rate() in favor of determine_rate() Message-ID: References: <20250811-clk-for-stephen-round-rate-v1-0-b3bf97b038dc@redhat.com> <20250811-clk-for-stephen-round-rate-v1-112-b3bf97b038dc@redhat.com> <20250827070933.GB18994@nxa18884-linux.ap.freescale.net> Precedence: bulk X-Mailing-List: arm-scmi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 In-Reply-To: <20250827070933.GB18994@nxa18884-linux.ap.freescale.net> User-Agent: Mutt/2.2.14 (2025-02-20) X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: pXGvlM9776-8xIIVuQ1JN_lsOJvMbRYRaFFPJwsui30_1756300407 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Aug 27, 2025 at 03:09:33PM +0800, Peng Fan wrote: > Hi Brian, Sudeep, Cristian > > On Mon, Aug 11, 2025 at 11:19:44AM -0400, Brian Masney via B4 Relay wrote: > >From: Brian Masney > > > >This driver implements both the determine_rate() and round_rate() clk > >ops, and the round_rate() clk ops is deprecated. When both are defined, > >clk_core_determine_round_nolock() from the clk core will only use the > >determine_rate() clk ops, so let's remove the round_rate() clk ops since > >it's unused. > > > >Signed-off-by: Brian Masney > >--- > > drivers/clk/clk-scmi.c | 30 ------------------------------ > > 1 file changed, 30 deletions(-) > > > >diff --git a/drivers/clk/clk-scmi.c b/drivers/clk/clk-scmi.c > >index d2408403283fc72f0cf902e65f4c08bcbc7b4b0b..6c6ddb92e7cf6a0cfac2c7e19c0f15f777bb8c51 100644 > >--- a/drivers/clk/clk-scmi.c > >+++ b/drivers/clk/clk-scmi.c > >@@ -54,35 +54,6 @@ static unsigned long scmi_clk_recalc_rate(struct clk_hw *hw, > > return rate; > > } > > > >-static long scmi_clk_round_rate(struct clk_hw *hw, unsigned long rate, > >- unsigned long *parent_rate) > >-{ > > I see the point of round_rate is not used if determine_rate is there. > But reading the code of round_rate, It might be better to rename > scmi_clk_round_rate to scmi_clk_determine_rate. > > Anyway, need Sudeep and Cristian to comment. In this case, yes the round_rate implementation is filled out, whereas the determine_rate lets the firmware handle it, and scmi_clk_recalc_rate() will later populate the rate the clock is running at. I can convert round_rate over to determine_rate in this case, however it would be a change to what's there now, and risks a regression. Here's the relevant code from drivers/clk/clk.c where the determine_rate and round_rate ops are called: static int clk_core_determine_round_nolock(struct clk_core *core, struct clk_rate_request *req) { ... if (clk_core_rate_is_protected(core)) { req->rate = core->rate; } else if (core->ops->determine_rate) { return core->ops->determine_rate(core->hw, req); } else if (core->ops->round_rate) { rate = core->ops->round_rate(core->hw, req->rate, &req->best_parent_rate); ... If Sudeep / Cristian want the round rate converted to determine rate in this driver, then I can do that in a v2. Brian