From: Cristian Marussi <cristian.marussi@arm.com>
To: "Peng Fan (OSS)" <peng.fan@oss.nxp.com>
Cc: Cristian Marussi <cristian.marussi@arm.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"arm-scmi@vger.kernel.org" <arm-scmi@vger.kernel.org>,
"linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org>,
"linux-renesas-soc@vger.kernel.org"
<linux-renesas-soc@vger.kernel.org>,
"sudeep.holla@arm.com" <sudeep.holla@arm.com>,
"philip.radford@arm.com" <philip.radford@arm.com>,
"james.quinlan@broadcom.com" <james.quinlan@broadcom.com>,
"f.fainelli@gmail.com" <f.fainelli@gmail.com>,
"vincent.guittot@linaro.org" <vincent.guittot@linaro.org>,
"etienne.carriere@foss.st.com" <etienne.carriere@foss.st.com>,
"michal.simek@amd.com" <michal.simek@amd.com>,
"dan.carpenter@linaro.org" <dan.carpenter@linaro.org>,
"geert+renesas@glider.be" <geert+renesas@glider.be>,
"kuninori.morimoto.gx@renesas.com"
<kuninori.morimoto.gx@renesas.com>,
"marek.vasut+renesas@gmail.com" <marek.vasut+renesas@gmail.com>
Subject: Re: [PATCH 09/11] firmware: arm_scmi: Add bound iterators support
Date: Sat, 28 Feb 2026 10:42:05 +0000 [thread overview]
Message-ID: <aaLGfXppc7am90us@pluto> (raw)
In-Reply-To: <PAXPR04MB84594E5C9BCE2B5171D15FEB8870A@PAXPR04MB8459.eurprd04.prod.outlook.com>
On Sat, Feb 28, 2026 at 02:43:47AM +0000, Peng Fan (OSS) wrote:
> > Subject: Re: [PATCH 09/11] firmware: arm_scmi: Add bound iterators
> > support
> >
> > On Fri, Feb 27, 2026 at 03:32:23PM +0000, Cristian Marussi wrote:
> > >SCMI core stack provides some common helpers to handle in a unified
> > way
> > >multipart message replies: such iterator-helpers, when run, currently
> > >process by default the whole set of discovered resources.
> > >
> > >Introduce an alternative way to run the initialized iterator on a
> > >limited range of resources.
> > >
> > >Note that the subset of resources that can be chosen is anyway
> > limited
> > >by the SCMI protocol specification, since you are only allowed to
> > >choose the startindex on a multi-part enumeration NOT the end index,
> > so
> > >that the effective number of returned items by a bound iterators
> > >depends really on platform side decisions.
> > >
> > >Suggested-by: Etienne Carriere <etienne.carriere@foss.st.com>
> > >Signed-off-by: Cristian Marussi <cristian.marussi@arm.com>
> > >---
> > > drivers/firmware/arm_scmi/clock.c | 3 +-
> > > drivers/firmware/arm_scmi/driver.c | 58 +++++++++++++++++++------
> > --
> > > drivers/firmware/arm_scmi/protocols.h | 13 +++++-
> > > 3 files changed, 55 insertions(+), 19 deletions(-)
> > >
> > >diff --git a/drivers/firmware/arm_scmi/clock.c
> > >b/drivers/firmware/arm_scmi/clock.c
> > >index 15faa79abed4..d7df5c45836e 100644
> > >--- a/drivers/firmware/arm_scmi/clock.c
> > >+++ b/drivers/firmware/arm_scmi/clock.c
> > >@@ -505,8 +505,7 @@ iter_clk_describe_process_response(const
> > struct scmi_protocol_handle *ph,
> > > struct scmi_clk_ipriv *p = priv;
> > > const struct scmi_msg_resp_clock_describe_rates *r =
> > response;
> > >
> > >- p->clkd->rates[st->desc_index + st->loop_idx] =
> > >- RATE_TO_U64(r->rate[st->loop_idx]);
> > >+ p->clkd->rates[p->clkd->num_rates] =
> > >+RATE_TO_U64(r->rate[st->loop_idx]);
> >
> > Seems irrelevant
> >
> Ignore this. I understand wrong.
Yeah...I will double check BUT the aim is to proper behaving while
filling up the vector when doing only a partial discovery with bound
iterators...in that case you want to fill probably only a subset of the
available slots in order like [0]:min, [1]:max...
Thanks,
Cristian
next prev parent reply other threads:[~2026-02-28 10:42 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-27 15:32 [PATCH 00/11] SCMI Clock rates discovery rework Cristian Marussi
2026-02-27 15:32 ` [PATCH 01/11] firmware: arm_scmi: Add clock determine_rate operation Cristian Marussi
2026-02-27 16:50 ` Jonathan Cameron
2026-02-28 10:07 ` Cristian Marussi
2026-02-28 0:27 ` Peng Fan
2026-02-28 10:13 ` Cristian Marussi
2026-03-02 12:37 ` Geert Uytterhoeven
2026-03-03 12:46 ` Cristian Marussi
2026-02-27 15:32 ` [PATCH 02/11] clk: scmi: Use new determine_rate clock operation Cristian Marussi
2026-02-28 0:56 ` Peng Fan
2026-02-28 10:23 ` Cristian Marussi
2026-03-02 17:11 ` Brian Masney
2026-03-03 2:54 ` Peng Fan
2026-03-03 12:47 ` Cristian Marussi
2026-03-02 12:39 ` Geert Uytterhoeven
2026-03-03 12:49 ` Cristian Marussi
2026-02-27 15:32 ` [PATCH 03/11] firmware: arm_scmi: Simplify clock rates exposed interface Cristian Marussi
2026-02-28 2:07 ` Peng Fan
2026-02-28 10:34 ` Cristian Marussi
2026-03-02 12:48 ` Geert Uytterhoeven
2026-03-02 13:09 ` Geert Uytterhoeven
2026-03-03 12:42 ` Cristian Marussi
2026-03-03 12:40 ` Cristian Marussi
2026-02-27 15:32 ` [PATCH 04/11] clk: scmi: Use new simplified per-clock rate properties Cristian Marussi
2026-02-28 2:12 ` Peng Fan
2026-02-27 15:32 ` [PATCH 05/11] firmware: arm_scmi: Drop unused clock rate interfaces Cristian Marussi
2026-02-28 2:13 ` Peng Fan
2026-02-27 15:32 ` [PATCH 06/11] firmware: arm_scmi: Make clock rates allocation dynamic Cristian Marussi
2026-02-28 2:29 ` Peng Fan
2026-02-28 10:36 ` Cristian Marussi
2026-02-27 15:32 ` [PATCH 07/11] firmware: arm_scmi: Harden clock parents discovery Cristian Marussi
2026-02-28 2:39 ` Peng Fan
2026-02-28 10:37 ` Cristian Marussi
2026-02-27 15:32 ` [PATCH 08/11] firmware: arm_scmi: Refactor iterators internal allocation Cristian Marussi
2026-02-27 15:32 ` [PATCH 09/11] firmware: arm_scmi: Add bound iterators support Cristian Marussi
2026-02-28 2:44 ` Peng Fan
2026-02-28 2:43 ` Peng Fan (OSS)
2026-02-28 10:42 ` Cristian Marussi [this message]
2026-02-27 15:32 ` [PATCH 10/11] firmware: arm_scmi: Use bound iterators to minimize discovered rates Cristian Marussi
2026-02-27 16:53 ` Jonathan Cameron
2026-02-28 10:43 ` Cristian Marussi
2026-02-27 15:32 ` [PATCH 11/11] firmware: arm_scmi: Introduce all_rates_get clock operation Cristian Marussi
2026-02-28 2:49 ` Peng Fan
2026-02-28 10:47 ` Cristian Marussi
2026-03-02 7:18 ` Peng Fan
2026-03-02 10:47 ` Cristian Marussi
2026-03-02 13:25 ` [PATCH 00/11] SCMI Clock rates discovery rework Geert Uytterhoeven
2026-03-03 13:08 ` Cristian Marussi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aaLGfXppc7am90us@pluto \
--to=cristian.marussi@arm.com \
--cc=arm-scmi@vger.kernel.org \
--cc=dan.carpenter@linaro.org \
--cc=etienne.carriere@foss.st.com \
--cc=f.fainelli@gmail.com \
--cc=geert+renesas@glider.be \
--cc=james.quinlan@broadcom.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=marek.vasut+renesas@gmail.com \
--cc=michal.simek@amd.com \
--cc=peng.fan@oss.nxp.com \
--cc=philip.radford@arm.com \
--cc=sudeep.holla@arm.com \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox