From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f48.google.com (mail-ej1-f48.google.com [209.85.218.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BDE192E92DB; Mon, 11 Aug 2025 15:38:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754926731; cv=none; b=b1zE3wl7sPAzoA4ZyK0fW7PSwP5j5fCwPKW38QMyhj46bSrKdUA03UnZ6wx1dZrSOyLsNuoURD10zUBtOMsowY/kClScs0QG6Bsk93xxNcLjcM9QIen9I/i1+9Hocp+XFgQm0e9wu1sESPeGrtj1/uQ6mg2AfOqVQ5yUvnlu73Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754926731; c=relaxed/simple; bh=FPbaAa28Nh3lMI3CatP7a4lPc6OfLL2O6SW4T1FANsI=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=i9aedr5cFSUp3S2qZotpU2Nzqg5rzojefUwSNmXNrZPaN0lTnyEwcT3KjGylwGYfR2J+CH7Yb898As37bJK41BfUHIB6KlxhjOjfRmpT9zDsbu+0en8xXt/WjiUqzx76+FPs4eCDJOnJX+KrY0NcJLGMHvqVm7KXeZD1rUvXsz4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=WX45NleR; arc=none smtp.client-ip=209.85.218.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="WX45NleR" Received: by mail-ej1-f48.google.com with SMTP id a640c23a62f3a-adfb562266cso618416466b.0; Mon, 11 Aug 2025 08:38:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1754926728; x=1755531528; darn=lists.linux.dev; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=qD3PnaCJHe7CAGf98jDIpzJE6HGS8eh/nvSCm5VXAxc=; b=WX45NleRBfzs1FTOjRTdrefhH6LF+nn6cAmvo1Aaxjuandjw4uK4njD+m6MsZEuoV2 7rJYpK3tWqsqX81hbgor8QgKgGQ9eKwPOeorFMzvaFQv4ZehFcgtKl3+UDGOHv+NAh+o XrsMylRd8zyTmEGS6UZKuTVARQFp5QFzbsCleLJuIyKdSbduAJ86/vMLe6NKQV3UQ6RL PqyGhkdDvITpY/pY1Vhe9t8Ux3hvEP7UtfDYiA1jCORw3EkGS4anEs8Nh0EVIF8Y1eV+ 6OYetWM9+iuK4rUlZNMhA+E9jb7RXBdddUoofmIZq3Q4lY78ye7PsHU4ATaswl84Eup1 Ac6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754926728; x=1755531528; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=qD3PnaCJHe7CAGf98jDIpzJE6HGS8eh/nvSCm5VXAxc=; b=ctyeGndyXzeeafAhsZsDvPbD9S2k10qfevNTttya+ZTdQRGibmp7x2dsv6IfwTvpGP lz149JOhbBqB8kp5KMG4BWuzw0wbJaJ1OON+3ueYBvjZpYt5r5mxb0+tAUNrLHz/Ledx OrgOnljxMu/3s9m9P9/c3CU2oCwYwXTVECHO736ZI7lBDPXJuTPMrQxarRyWNNF1OBZ1 /+Pnx4ZQmBDnP1jJpvT4b8gVM0pqxVmbHY41asSivn09CGebPlE+1YJZ9Chd8IUUpF0K 4S8EN9JZimDezP35d03N+R9Z0bdkSvy0z5fcA/KPzw30QQ0VSyyWC5mqiAmKOkVlCo5W KxSQ== X-Forwarded-Encrypted: i=1; AJvYcCU02U2w+NON8ZoDfuZ/iLFpZCXKudyzcEQAFgI1OdKQtto9wnIxKINPhxP95YIsgaH494l3@lists.linux.dev, AJvYcCV3tJLObKsuhy8w3EfgUqcpM/jALsCX7cYcQObNHjWx30zJ7iNSJ9Hyicmyqlt7WuIVL5Hib8hA@lists.linux.dev, AJvYcCVUARHuTOxMJ7/vmvAT0fzKWbZmRf0DlFH53JQtY9AMuFyBgGw+ye3axPm7VOTZGao6WzlNDQ==@lists.linux.dev, AJvYcCXKvelrljBdJ21gezkn3toWX1bVduGn0s5JtPPc56TOmaVmO0k2sQFGLfb+MFf+5+KOY+gQ@lists.linux.dev, AJvYcCXXEhme/55QA/f/Kyt4rfUh+DGcP5YN09OxfVaKspqNpySacqcpvJvN2RvGZrLaVZR30H9vswFRaOw=@lists.linux.dev X-Gm-Message-State: AOJu0YzbFsKZyMfAe1Mr/TmPdhCVmRCq3IQc1OHzr33LsXO9pO4t4rjZ ErqYP7ld4uQ91bBuuCkelq6lmkbzgiw4OW7Pz49Cp/FuhIk/eN5QZb91 X-Gm-Gg: ASbGnctrSVgNIG1VPL7Q3RLcSew7i3D1DY72wzn7IrUkJTs+MRPvOepxrfclccN/dfo TmO92Ap2u5wch4q+H7pnuwhsi2BK5yAACbE8+DTAJ5WuZLsyagz9j40TCyshBdJRmn2ZCZF2rl/ mAfU71bKbo7fgQaTiz3YZec7lho/QSNuyiUC0jvwMLEWzFfuUaagU7b1NN/nec3ag4voALNhnpX TjpqjgV7NdHaGODvQ7vm0NlkmFDCy3ox8Rgkr1D10OecfJr3WHPY7oSFeVgHQJznXIQg4nGyadI q9VmonXQWKvBiaRWcc7PphCLs9LfSTCjjgEwrrO7MeRnSBa+nzutXFicM3UhcX4CLAzBWsCL7Fd UPi8VdoAwvwYdUgA9eHTbut1sXdsdZn8Du0pz6fM= X-Google-Smtp-Source: AGHT+IEwAIMMmXMguO85CuFME8BHuByHpdLqU2yJrGASpVc+AuhN3x1kaE4ymuvmmSr6MxnWK7LVvA== X-Received: by 2002:a17:906:b07:b0:afa:1453:6632 with SMTP id a640c23a62f3a-afa14536b03mr150166866b.50.1754926727869; Mon, 11 Aug 2025 08:38:47 -0700 (PDT) Received: from giga-mm.home ([2a02:1210:8642:2b00:82ee:73ff:feb8:99e3]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-af91a21c157sm2047222366b.100.2025.08.11.08.38.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Aug 2025 08:38:47 -0700 (PDT) Message-ID: <09635747dcd29f45a90dd33a74a9902d7bfa9649.camel@gmail.com> Subject: Re: [PATCH 112/114] clk: scmi: remove round_rate() in favor of determine_rate() From: Alexander Sverdlin To: bmasney@redhat.com, Michael Turquette , Stephen Boyd , Sudeep Holla , Cristian Marussi , Chen Wang , Inochi Amaoto , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Paul Cercueil , Keguang Zhang , Taichi Sugaya , Takao Orito , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Jacky Huang , Shan-Chun Hung , Vladimir Zapolskiy , Piotr Wojtaszczyk , Paul Walmsley , Samuel Holland , Yixun Lan , Steen Hegelund , Daniel Machon , UNGLinuxDriver@microchip.com, Orson Zhai , Baolin Wang , Chunyan Zhang , Maxime Coquelin , Alexandre Torgue , Michal Simek , Maxime Ripard , Andreas =?ISO-8859-1?Q?F=E4rber?= , Manivannan Sadhasivam , Sven Peter , Janne Grunau , Alyssa Rosenzweig , Neal Gompa , Eugeniy Paltsev , Ray Jui , Scott Branden , Broadcom internal kernel review list , Max Filippov , Matthias Brugger , AngeloGioacchino Del Regno , Daniel Palmer , Romain Perier , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Bjorn Andersson , Geert Uytterhoeven , Heiko Stuebner , Andrea della Porta , Krzysztof Kozlowski , Sylwester Nawrocki , Chanwoo Choi , Alim Akhtar , Qin Jian , Viresh Kumar , Ulf Hansson , Luca Ceresoli , Alex Helms , Linus Walleij , Liviu Dudau , Lorenzo Pieralisi , Nobuhiro Iwamatsu Cc: linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, arm-scmi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, sophgo@lists.linux.dev, linux-mips@vger.kernel.org, imx@lists.linux.dev, linux-riscv@lists.infradead.org, spacemit@lists.linux.dev, linux-stm32@st-md-mailman.stormreply.com, patches@opensource.cirrus.com, linux-actions@lists.infradead.org, asahi@lists.linux.dev, linux-mediatek@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-samsung-soc@vger.kernel.org, soc@lists.linux.dev Date: Mon, 11 Aug 2025 17:38:43 +0200 In-Reply-To: <20250811-clk-for-stephen-round-rate-v1-112-b3bf97b038dc@redhat.com> References: <20250811-clk-for-stephen-round-rate-v1-0-b3bf97b038dc@redhat.com> <20250811-clk-for-stephen-round-rate-v1-112-b3bf97b038dc@redhat.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.56.1 Precedence: bulk X-Mailing-List: asahi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Mon, 2025-08-11 at 11:19 -0400, Brian Masney via B4 Relay wrote: > From: Brian Masney >=20 > This driver implements both the determine_rate() and round_rate() clk > ops, and the round_rate() clk ops is deprecated. When both are defined, > clk_core_determine_round_nolock() from the clk core will only use the > determine_rate() clk ops, so let's remove the round_rate() clk ops since > it's unused. >=20 > Signed-off-by: Brian Masney Reviewed-by: Alexander Sverdlin > --- > =C2=A0drivers/clk/clk-scmi.c | 30 ------------------------------ > =C2=A01 file changed, 30 deletions(-) >=20 > diff --git a/drivers/clk/clk-scmi.c b/drivers/clk/clk-scmi.c > index d2408403283fc72f0cf902e65f4c08bcbc7b4b0b..6c6ddb92e7cf6a0cfac2c7e19= c0f15f777bb8c51 100644 > --- a/drivers/clk/clk-scmi.c > +++ b/drivers/clk/clk-scmi.c > @@ -54,35 +54,6 @@ static unsigned long scmi_clk_recalc_rate(struct clk_h= w *hw, > =C2=A0 return rate; > =C2=A0} > =C2=A0 > -static long scmi_clk_round_rate(struct clk_hw *hw, unsigned long rate, > - unsigned long *parent_rate) > -{ > - u64 fmin, fmax, ftmp; > - struct scmi_clk *clk =3D to_scmi_clk(hw); > - > - /* > - * We can't figure out what rate it will be, so just return the > - * rate back to the caller. scmi_clk_recalc_rate() will be called > - * after the rate is set and we'll know what rate the clock is > - * running at then. > - */ > - if (clk->info->rate_discrete) > - return rate; > - > - fmin =3D clk->info->range.min_rate; > - fmax =3D clk->info->range.max_rate; > - if (rate <=3D fmin) > - return fmin; > - else if (rate >=3D fmax) > - return fmax; > - > - ftmp =3D rate - fmin; > - ftmp +=3D clk->info->range.step_size - 1; /* to round up */ > - do_div(ftmp, clk->info->range.step_size); > - > - return ftmp * clk->info->range.step_size + fmin; > -} > - > =C2=A0static int scmi_clk_set_rate(struct clk_hw *hw, unsigned long rate, > =C2=A0 =C2=A0=C2=A0=C2=A0=C2=A0 unsigned long parent_rate) > =C2=A0{ > @@ -300,7 +271,6 @@ scmi_clk_ops_alloc(struct device *dev, unsigned long = feats_key) > =C2=A0 > =C2=A0 /* Rate ops */ > =C2=A0 ops->recalc_rate =3D scmi_clk_recalc_rate; > - ops->round_rate =3D scmi_clk_round_rate; > =C2=A0 ops->determine_rate =3D scmi_clk_determine_rate; > =C2=A0 if (feats_key & BIT(SCMI_CLK_RATE_CTRL_SUPPORTED)) > =C2=A0 ops->set_rate =3D scmi_clk_set_rate; --=20 Alexander Sverdlin.