From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fout5-smtp.messagingengine.com (fout5-smtp.messagingengine.com [103.168.172.148]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A8B3CBA50 for ; Fri, 13 Sep 2024 18:02:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=103.168.172.148 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726250551; cv=none; b=iwrgo76QWCO7RJFblS9CIn0sxaA7BDmRgZTLftYHUTimFCbBchUjq1+M3LG2MimGxPR1Dr8ewDzXWmoac6BP11+30/qy9YB9FEmVyfS3fxSkcJmMcPqRHQPE1fUYoocrcNlqxjR4zYxDGivA55hrKx3iEhPANaCTEo5t3ADrp2g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726250551; c=relaxed/simple; bh=/xiIVCpQW8QVmjZDSV8aZTbb32lrd7k8VmT6lTMuWYs=; h=Content-Type:From:Mime-Version:Subject:Date:Message-Id:References: Cc:In-Reply-To:To; b=OLmcaLY56a17cpMcGwoYMTjFS2Jro0zvaG0gxzXsBrT2nc9UE7+d+dTFFao8RcOD9Sv+sAUj423QtPLEbQsIXxN5ic75+St0c4qKwcmwjzIzuEKP+0YOmCTJXItkSNssneQWCldZsoLYtvmats729FmC+m/K+I0pdOh+/HhoNi0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=svenpeter.dev; spf=pass smtp.mailfrom=svenpeter.dev; dkim=pass (2048-bit key) header.d=svenpeter.dev header.i=@svenpeter.dev header.b=jDfJUCZd; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=S3vKPw3X; arc=none smtp.client-ip=103.168.172.148 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=svenpeter.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=svenpeter.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=svenpeter.dev header.i=@svenpeter.dev header.b="jDfJUCZd"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="S3vKPw3X" Received: from phl-compute-03.internal (phl-compute-03.phl.internal [10.202.2.43]) by mailfout.phl.internal (Postfix) with ESMTP id C1C1C138019B; Fri, 13 Sep 2024 14:02:27 -0400 (EDT) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-03.internal (MEProxy); Fri, 13 Sep 2024 14:02:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=svenpeter.dev; h=cc:cc:content-transfer-encoding:content-type:content-type :date:date:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:subject:subject:to:to; s=fm2; t=1726250547; x=1726336947; bh=KgF0/2DNs9uieC59wQf5tgot36dlRR/u LSlmHjblz8o=; b=jDfJUCZdWRxOrQNYqiCr29EzjLrYMMyWE8xrlqsLM4gCD0m4 fIBqqCscBgOc53ODPmHaM9lIwcOIeE5WXUENMS40op1bgfe7WaJm9+uKMiuGpbYu z68XBaOvdCHbVaWjFYeA1XVzg3uhs71MHeErif85AA8UIoTbp5wlxqf15VmLvFKF 68IvfoLSVxTpTyx1yBQ3ffGpplSvbitYlK58/Gok4cdneqPoL6JZHZJZwx5/1bmf ZcP2iF2rPZxOBsHefvXTIC0oJI/9ovVPBv1rgfypihgz82prof1VIY4tw0bq8HfE HoCo+Rx8TDF+vYk32/YIoI2nQOAIBZESWu7Xqw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1726250547; x= 1726336947; bh=KgF0/2DNs9uieC59wQf5tgot36dlRR/uLSlmHjblz8o=; b=S 3vKPw3X8+p0TuP5oitYCrbasHjLSNfzYbnLPPTSUD9n9SOsBHBTV3rhRoG9Sz0+f iYBtg2anqYVoK2XIUoirmgmpKYBGg6bRmuy062xAw7pKSWwVoppNDSrpwmUIyrTI b1WddpmgFklmtzlmDR8i+wPjHeL1wjeFsqkbJR6CCePUnTo3h/ZlODuSbGJj6nJs ehj9Z262VUsbnNPdd10IDNKw3DxbMNymnuEQRpBdN1WQactt4+vBFbAEWDfhKZgY GwrdbqNJnpV4P5FxzT133Eg6q0SWrLlwO9l9A87cn6Ht5a/X/AK0hMCN4xKOpKvZ LsRnhhTy6q6ssdlLTQLUQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrudejjedguddulecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdp uffrtefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivg hnthhsucdlqddutddtmdenucfjughrpegtgffhggfufffkfhevjgfvofesthhqmhdthhdt jeenucfhrhhomhepufhvvghnucfrvghtvghruceoshhvvghnsehsvhgvnhhpvghtvghrrd guvghvqeenucggtffrrghtthgvrhhnpedvhfdtudduvdeujeeufffgudekvdefvefgueei iedvledtheegieevffdtteekudenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmh epmhgrihhlfhhrohhmpehsvhgvnhesshhvvghnphgvthgvrhdruggvvhdpnhgspghrtghp thhtohepledpmhhouggvpehsmhhtphhouhhtpdhrtghpthhtoheplhhinhhugidqkhgvrh hnvghlsehvghgvrhdrkhgvrhhnvghlrdhorhhgpdhrtghpthhtoheprghsrghhiheslhhi shhtshdrlhhinhhugidruggvvhdprhgtphhtthhopehlihhnuhigqdgrrhhmqdhkvghrnh gvlheslhhishhtshdrihhnfhhrrgguvggrugdrohhrghdprhgtphhtthhopehtohifihhn tghhvghnmhhisehgmhgrihhlrdgtohhmpdhrtghpthhtohepfihimheslhhinhhugidqfi grthgthhguohhgrdhorhhgpdhrtghpthhtoheprghlhihsshgrsehrohhsvghniiifvghi ghdrihhopdhrtghpthhtoheplhhinhhugiesrhhovggtkhdquhhsrdhnvghtpdhrtghpth htoheplhhinhhugidqfigrthgthhguohhgsehvghgvrhdrkhgvrhhnvghlrdhorhhgpdhr tghpthhtohepmhgrrhgtrghnsehmrghrtggrnhdrshht X-ME-Proxy: Feedback-ID: i51094778:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 13 Sep 2024 14:02:26 -0400 (EDT) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable From: Sven Peter Precedence: bulk X-Mailing-List: asahi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 (1.0) Subject: Re: [PATCH] watchdog: apple: Increase reset delay to 150ms Date: Fri, 13 Sep 2024 20:02:14 +0200 Message-Id: <0F0CD820-4479-4DDB-BA89-CB44F4A190F3@svenpeter.dev> References: <20240913174540.45551-1-towinchenmi@gmail.com> Cc: Hector Martin , Alyssa Rosenzweig , Wim Van Sebroeck , Guenter Roeck , asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org In-Reply-To: <20240913174540.45551-1-towinchenmi@gmail.com> To: Nick Chan X-Mailer: iPhone Mail (21G93) >=20 > On 13. Sep 2024, at 19:46, Nick Chan wrote: >=20 > =EF=BB=BFThe Apple A8X SoC seems to be slowest at resetting, taking up to a= round > 125ms to reset. Wait 150ms to be safe here. >=20 > Signed-off-by: Nick Chan > --- Reviewed-by: Sven Peter > drivers/watchdog/apple_wdt.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) >=20 > diff --git a/drivers/watchdog/apple_wdt.c b/drivers/watchdog/apple_wdt.c > index d4f739932f0b..353ecf0b04dc 100644 > --- a/drivers/watchdog/apple_wdt.c > +++ b/drivers/watchdog/apple_wdt.c > @@ -127,11 +127,11 @@ static int apple_wdt_restart(struct watchdog_device *= wdd, unsigned long mode, > /* > * Flush writes and then wait for the SoC to reset. Even though the > * reset is queued almost immediately experiments have shown that it > - * can take up to ~20-25ms until the SoC is actually reset. Just wait= > - * 50ms here to be safe. > + * can take up to ~120-125ms until the SoC is actually reset. Just > + * wait 150ms here to be safe. > */ > (void)readl_relaxed(wdt->regs + APPLE_WDT_WD1_CUR_TIME); > - mdelay(50); > + mdelay(150); >=20 > return 0; > } >=20 > base-commit: 5acd9952f95fb4b7da6d09a3be39195a80845eb6 > -- > 2.46.0 >=20