Linux on Apple ARM platform development
 help / color / mirror / Atom feed
From: "Rob Herring (Arm)" <robh@kernel.org>
To: Sasha Finkelstein <fnkl.kernel@gmail.com>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	 Maxime Ripard <mripard@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	 Thomas Zimmermann <tzimmermann@suse.de>,
	asahi@lists.linux.dev,  David Airlie <airlied@gmail.com>,
	devicetree@vger.kernel.org,
	 Alyssa Rosenzweig <alyssa@rosenzweig.io>,
	 linux-arm-kernel@lists.infradead.org,
	 Jessica Zhang <quic_jesszhan@quicinc.com>,
	 Krzysztof Kozlowski <krzk+dt@kernel.org>,
	 Neil Armstrong <neil.armstrong@linaro.org>,
	 Hector Martin <marcan@marcan.st>,
	linux-kernel@vger.kernel.org,  dri-devel@lists.freedesktop.org,
	Simona Vetter <simona@ffwll.ch>,  Sven Peter <sven@svenpeter.dev>
Subject: Re: [PATCH 1/5] dt-bindgins: display: Add Apple pre-DCP display controller bindings
Date: Sun, 24 Nov 2024 20:06:51 -0600	[thread overview]
Message-ID: <173250040970.6667.2839660338071681474.robh@kernel.org> (raw)
In-Reply-To: <20241124-adpdrm-v1-1-3191d8e6e49a@gmail.com>


On Sun, 24 Nov 2024 23:29:24 +0100, Sasha Finkelstein wrote:
> Add bindings for a secondary display controller present on certain
> Apple laptops.
> 
> Signed-off-by: Sasha Finkelstein <fnkl.kernel@gmail.com>
> ---
>  .../bindings/display/apple,display-pipe.yaml       | 59 ++++++++++++++++++++++
>  .../bindings/display/panel/apple,summit.yaml       | 24 +++++++++
>  2 files changed, 83 insertions(+)
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:
./Documentation/devicetree/bindings/display/apple,display-pipe.yaml:21:9: [warning] wrong indentation: expected 10 but found 8 (indentation)

dtschema/dtc warnings/errors:

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20241124-adpdrm-v1-1-3191d8e6e49a@gmail.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.


  reply	other threads:[~2024-11-25  2:06 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-24 22:29 [PATCH 0/5] Driver for pre-DCP apple display controller Sasha Finkelstein via B4 Relay
2024-11-24 22:29 ` [PATCH 1/5] dt-bindgins: display: Add Apple pre-DCP display controller bindings Sasha Finkelstein via B4 Relay
2024-11-25  2:06   ` Rob Herring (Arm) [this message]
2024-11-25  7:45   ` Krzysztof Kozlowski
2024-11-25 14:14     ` Hector Martin
2024-11-25 14:53       ` Krzysztof Kozlowski
2024-11-25 15:29         ` Hector Martin
2024-11-24 22:29 ` [PATCH 2/5] gpu: drm: adp: Add Apple Display Pipe driver Sasha Finkelstein via B4 Relay
2024-11-25  8:50   ` Neil Armstrong
2024-11-25 11:24     ` Sasha Finkelstein
2024-11-25 12:57       ` neil.armstrong
2024-11-25 13:14         ` Sasha Finkelstein
2024-11-25 13:16           ` neil.armstrong
2024-11-25 14:24       ` Hector Martin
2024-11-25 15:28         ` Maxime Ripard
2024-11-25 15:55           ` Hector Martin
2024-11-25 15:37         ` neil.armstrong
2024-11-25  9:04   ` Jani Nikula
2024-11-25 10:59   ` Alyssa Ross
2024-11-24 22:29 ` [PATCH 3/5] gpu: drm: adp: Add a backlight driver for the Summit LCD Sasha Finkelstein via B4 Relay
2024-11-25  8:45   ` Neil Armstrong
2024-11-25 11:28     ` Sasha Finkelstein
2024-11-25 14:49   ` Krzysztof Kozlowski
2024-11-25 15:03     ` Nick Chan
2024-11-25 15:06       ` Krzysztof Kozlowski
2024-11-26 16:34         ` Sasha Finkelstein
2024-11-26 16:52           ` Krzysztof Kozlowski
2024-11-24 22:29 ` [PATCH 4/5] arm64: dts: apple: Add touchbar screen nodes Sasha Finkelstein via B4 Relay
2024-11-25  8:39   ` Nick Chan
2024-11-25  8:43   ` Nick Chan
2024-11-24 22:29 ` [PATCH 5/5] MAINTAINERS: Add entries for touchbar display driver Sasha Finkelstein via B4 Relay
2024-11-25  9:24   ` Nick Chan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=173250040970.6667.2839660338071681474.robh@kernel.org \
    --to=robh@kernel.org \
    --cc=airlied@gmail.com \
    --cc=alyssa@rosenzweig.io \
    --cc=asahi@lists.linux.dev \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=fnkl.kernel@gmail.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=marcan@marcan.st \
    --cc=mripard@kernel.org \
    --cc=neil.armstrong@linaro.org \
    --cc=quic_jesszhan@quicinc.com \
    --cc=simona@ffwll.ch \
    --cc=sven@svenpeter.dev \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox