From: Thierry Reding <thierry.reding@gmail.com>
To: Rob Herring <robh+dt@kernel.org>, Joerg Roedel <joro@8bytes.org>
Cc: Will Deacon <will@kernel.org>,
Robin Murphy <robin.murphy@arm.com>,
Nicolin Chen <nicolinc@nvidia.com>,
Krishna Reddy <vdumpa@nvidia.com>,
Ashish Mhetre <amhetre@nvidia.com>,
Dmitry Osipenko <dmitry.osipenko@collabora.com>,
Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>,
Janne Grunau <j@jannau.net>, Sameer Pujar <spujar@nvidia.com>,
Lucas Stach <l.stach@pengutronix.de>,
devicetree@vger.kernel.org, iommu@lists.linux-foundation.org,
linux-tegra@vger.kernel.org, asahi@lists.linux.dev
Subject: [PATCH v12 0/4] iommu: Support mappings/reservations in reserved-memory regions
Date: Thu, 17 Nov 2022 19:54:20 +0100 [thread overview]
Message-ID: <20221117185424.2359687-1-thierry.reding@gmail.com> (raw)
From: Thierry Reding <treding@nvidia.com>
Hi,
This version is a minor update to the previous v11, which can be found
here:
https://lore.kernel.org/all/20221111161806.630527-1-thierry.reding@gmail.com/
The only change here is that the #dma-{address,size}-cells is dropped.
It turns out to be much simpler to just update #{address,size}-cells to
what they should be rather than add extra complexity for the DMA work-
around. There's a minor update to the DT binding so that it can now
properly validate cases where we have both reg and iommu-addresses
properties.
An example is included in the DT bindings, but here is an extract of
what I've used to test this:
reserved-memory {
#address-cells = <2>;
#size-cells = <2>;
ranges;
/*
* Creates an identity mapping for the framebuffer that
* the firmware has setup to scan out a bootsplash from.
*/
fb: framebuffer@92cb2000 {
reg = <0x0 0x92cb2000 0x0 0x00800000>;
iommu-addresses = <&dc0 0x0 0x92cb2000 0x0 0x00800000>;
};
/*
* Creates a reservation in the IOVA space to prevent
* any buffers from being mapped to that region. Note
* that on Tegra the range is actually quite different
* from this, but it would conflict with the display
* driver that I tested this against, so this is just
* a dummy region for testing.
*/
adsp: reservation-adsp {
iommu-addresses = <&dc0 0x0 0x90000000 0x0 0x00010000>;
};
};
host1x@50000000 {
dc@54200000 {
memory-region = <&fb>, <&adsp>;
};
};
This is abbreviated a little to focus on the essentials. Note also that
the ADSP reservation is not actually used on this device and the driver
for this doesn't exist yet, but I wanted to include this variant for
testing, because we'll want to use these bindings for the reservation
use-case as well at some point.
I've also been able to make use of this binding and the IOMMU code in
conjunction with the simple-framebuffer driver to hand over a display
configuration set up by UEFI to the Linux kernel.
Janne has confirmed[0] this to be suitable for indirect mappings as
well, though these patches don't implement that feature yet. Potential
extensions to this have been discussed but are not yet included at this
time to not further complicate things.
Thierry
[0]: https://lore.kernel.org/all/20220909144504.GA4024@jannau.net/
Thierry Reding (4):
of: Introduce of_translate_dma_region()
dt-bindings: reserved-memory: Document iommu-addresses
iommu: Implement of_iommu_get_resv_regions()
iommu: dma: Use of_iommu_get_resv_regions()
.../reserved-memory/reserved-memory.yaml | 89 +++++++++++++++++-
drivers/iommu/dma-iommu.c | 3 +
drivers/iommu/of_iommu.c | 94 +++++++++++++++++++
drivers/of/address.c | 41 ++++++++
include/linux/of_address.h | 2 +
include/linux/of_iommu.h | 8 ++
6 files changed, 233 insertions(+), 4 deletions(-)
--
2.38.1
next reply other threads:[~2022-11-17 18:54 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-17 18:54 Thierry Reding [this message]
2022-11-17 18:54 ` [PATCH v12 1/4] of: Introduce of_translate_dma_region() Thierry Reding
2022-11-20 18:00 ` Rob Herring
2022-11-17 18:54 ` [PATCH v12 2/4] dt-bindings: reserved-memory: Document iommu-addresses Thierry Reding
2022-11-17 18:54 ` [PATCH v12 3/4] iommu: Implement of_iommu_get_resv_regions() Thierry Reding
2022-12-02 14:37 ` Thierry Reding
2022-12-05 18:36 ` Robin Murphy
2022-11-17 18:54 ` [PATCH v12 4/4] iommu: dma: Use of_iommu_get_resv_regions() Thierry Reding
2022-12-05 18:37 ` Robin Murphy
2022-12-02 14:41 ` [PATCH v12 0/4] iommu: Support mappings/reservations in reserved-memory regions Thierry Reding
2022-12-05 16:59 ` Rob Herring
2023-01-20 17:36 ` Thierry Reding
2023-01-20 17:44 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221117185424.2359687-1-thierry.reding@gmail.com \
--to=thierry.reding@gmail.com \
--cc=alyssa.rosenzweig@collabora.com \
--cc=amhetre@nvidia.com \
--cc=asahi@lists.linux.dev \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.osipenko@collabora.com \
--cc=iommu@lists.linux-foundation.org \
--cc=j@jannau.net \
--cc=joro@8bytes.org \
--cc=l.stach@pengutronix.de \
--cc=linux-tegra@vger.kernel.org \
--cc=nicolinc@nvidia.com \
--cc=robh+dt@kernel.org \
--cc=robin.murphy@arm.com \
--cc=spujar@nvidia.com \
--cc=vdumpa@nvidia.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox