From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 767711ABEC8 for ; Wed, 28 Aug 2024 21:32:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724880781; cv=none; b=dH3K3kzoaRHyZXt9UDBB92Ue8ZGt4FV9c06HKn9hQ5aECLlq16KPXlw/T5QHgY1bFAue3VOJloh5jLJDnopclmMhNrGjeqf2zCGMxjHVjKTcrf2No1/YTdiCkHPJbScx6CaGGv3Ov6c+eNuCOo+6TACIbZQacmVbM/7Erq8VnBk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724880781; c=relaxed/simple; bh=cEpCS+awESzibz2fx1rBVxzmh/G9/OK1eGkd1D1LRF4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=HVJoDm8Q1ebWoZ0JCfYTG0/TpOQhiOyOe3VBj4mzvhC1e7b1XmRDy6JKd0Fx+0EoySI4wQFNeljFgsm5qMkKDOu15Y3MnbhAq63XMGTdOqd83Ith1TERP01DHFu6z0cBEMc7iE2XgE+ycGbiTEwAx4VTzxsxCvByMtTXfs7PVdg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=vhoGV+v7; arc=none smtp.client-ip=209.85.214.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="vhoGV+v7" Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-20353e5de9cso58675ad.0 for ; Wed, 28 Aug 2024 14:32:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1724880779; x=1725485579; darn=lists.linux.dev; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=6OiNe2YeQCUna2f4UjRdeOC+WErdfdXGa82/r6tUnVw=; b=vhoGV+v7iRvzcH57Gvy84/7ooNQrdQ9npldmmxGkBh/AeT1K3pApb6TNReHYPfEKvK bIb4cJVGZTLJXvkXWaWNj/AQz+8tnRbgP1mAKlX8UGlxb3n6MnDj4Oq3NobUFyKrjpZ9 ZgSG88nibz/n1rl8P1p/YNrJdegEfbAaOWFRklkxKhD80l6thc1LGkeqmg6KCFCXMUQv A3gHP4Sevaxjh63LEm/yIhLh/pbPb8Fvnt88+gRX9Qzz/3nLf4Av+wP96xZoPId9/3OA qKjAOByhAXGS80xtPrEFX109IwSe0jPBHm3WQWBPSwK8eNHhFUjEcANHOquKD9ycUHvv e7XQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724880779; x=1725485579; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=6OiNe2YeQCUna2f4UjRdeOC+WErdfdXGa82/r6tUnVw=; b=RW6CnFaDIIZHV0abky5kc7TplxpBpkCck7kiZS2nzIRjUtYAkJFaasDf9YbS1u3KFT mD1LPYOUOZBO57hWGC/UoaqhmGW/cUB97joBpzhVVv4uh1LyWOv0z6TDP85KrZLCTbm+ V8Itcyg2Npnm9pmE0bL48PeoWANhegFFhc/VfeiMAm0U+52vJDgovh7dho5gfkh1K7gP FchmqVopsOE8hsJnmmjilUNZFRY/7dzTkpxzyAjlD78+IW1RG5Qzw34M7nn1fdj3jp0k jAGSg3Rrc0rw1pxzMydW82WOLIWVhmQE7qaL7pKIN62C3f/YGH405Ryu3tm1sAhkm2RS 5zxw== X-Forwarded-Encrypted: i=1; AJvYcCWQkjMfjLLNmBOYEApimIOCoxOuwFY1PDw90ntVHYjt2zTcmHBXso26vWgzneyK7tjQZ2y0Kg==@lists.linux.dev X-Gm-Message-State: AOJu0YyQXfFBH1c2eaTdWP62Fmxu4s9go9gzGlqz++wHLSHuFlFfttEA 5yQF2NwzxusItDkdOMRPeXANhFLs7ByOL4TPKk1iGV/kS/DvQzP2Ku9OYi6P1g== X-Google-Smtp-Source: AGHT+IHHf+VlJrFFBJgPYVRNtck/f/imxXiwO9YAgJOrmaeUNIYbTt/FhYzSs4jbx7giAS/mraakLQ== X-Received: by 2002:a17:902:e5ca:b0:200:8e1e:9940 with SMTP id d9443c01a7336-20510d58e83mr210625ad.23.1724880778385; Wed, 28 Aug 2024 14:32:58 -0700 (PDT) Received: from google.com (226.75.127.34.bc.googleusercontent.com. [34.127.75.226]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-203855dbf41sm102647885ad.134.2024.08.28.14.32.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Aug 2024 14:32:57 -0700 (PDT) Date: Wed, 28 Aug 2024 21:32:51 +0000 From: Sami Tolvanen To: Masahiro Yamada Cc: Luis Chamberlain , Miguel Ojeda , Greg Kroah-Hartman , Matthew Maurer , Alex Gaynor , Wedson Almeida Filho , Gary Guo , Petr Pavlu , Neal Gompa , Hector Martin , Janne Grunau , Asahi Linux , linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, linux-modules@vger.kernel.org, rust-for-linux@vger.kernel.org Subject: Re: [PATCH v2 01/19] tools: Add gendwarfksyms Message-ID: <20240828213251.GB2130480@google.com> References: <20240815173903.4172139-21-samitolvanen@google.com> <20240815173903.4172139-22-samitolvanen@google.com> Precedence: bulk X-Mailing-List: asahi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Hi Masahiro, On Thu, Aug 29, 2024 at 02:45:03AM +0900, Masahiro Yamada wrote: > On Fri, Aug 16, 2024 at 2:39 AM Sami Tolvanen wrote: > > +static int usage(void) > > +{ > > + error("usage: gendwarfksyms [options] elf-object-file ..."); > > > > Description for each option, please. Sure, will add. > > +static int parse_options(int argc, const char **argv) > > > > Why not getopt_long()? Good point, I'll switch to getopt. > > +int main(int argc, const char **argv) > > +{ > > + unsigned int n; > > + > > + if (parse_options(argc, argv) < 0) > > + return usage(); > > + > > + for (n = 0; n < object_count; n++) { > > > When does "object_count >= 2" happen ? Right now it doesn't, but if we want to support LTO, we'll need to also process the temporary object files we build for stand-alone assembly to find types for the symbols exported there. > > +extern int process_module(Dwfl_Module *mod, Dwarf *dbg, Dwarf_Die *cudie); > > > No 'extern' for function declarations. Ack, I'll drop these. Thanks for the review! Sami