From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D0E7D1AC8A9 for ; Wed, 28 Aug 2024 22:28:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724884085; cv=none; b=UZ1R60WjDH9K7T4zwMGXBnj3cdyBXoWR5kdIhQ2ex3hbPspiNdLOzRQlwyCVfIa4IbroveOR+t9dD29a6O3o9d+EkF0x9f6Q/fknuoOMwESm5NdK+GLu/v3DMq1kVIF5uPPwKU+XrXWpAP/tosI+B61GA2aONMUVAUMKICiOx78= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724884085; c=relaxed/simple; bh=X+km3MM8Djv4BAoedxYfYSnV7h3AO6W0/QFMSBR+6tk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=I3ChF4p5GXDrizqTOXMFc3eQB4kXeX1LeDd2rahcF+LYPOCkqQjW8LsNWSC/7Vey5IO0o8lNfZ7sSYZFhSPOtm2Woii8v7eu48xqP3VXlHooizLgiBZILr0W04W2C0yVg6vxQJMXs8FWECWmwRJJgLPpXSzDhnFJyWwnDHwUuv8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=bTjnMQJQ; arc=none smtp.client-ip=209.85.214.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="bTjnMQJQ" Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-20260346ca1so73885ad.0 for ; Wed, 28 Aug 2024 15:28:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1724884083; x=1725488883; darn=lists.linux.dev; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=RyvIuJm8YmYnY8dX3OldQiJE1+zDwIi+PDulR5QhNTU=; b=bTjnMQJQOyN01QZfmYKGzzq5i6IecKNhQLd35gz5yokcs8DiS7J1YSus2IxSZP5r31 evKRIQmmCJQLTpc/rAc7ZoE/Amo2udO8TJBBedW7T91TXeIkxTo1BaZ+Tsa9L8Ip/XNY RzL9xX5obzGTGzlBqU1RQ4C8wJ6jyfUMZ5x8V2KnLtSOTl+LXlhLuiU9CB2W7nkFFpKU UA8f+VF3hSdS1iFx5tWduVfhHVEvpvaC0fnEvXKrsuj3CbfvBvrtSADuELy+TEXaGubt BvtlIe/LnKQRwuKhVOYCWclRHvvFXkuCqrMl2Y7NVRKCd8+9YSDbx5/MBslQEozHggVL i3ww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724884083; x=1725488883; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=RyvIuJm8YmYnY8dX3OldQiJE1+zDwIi+PDulR5QhNTU=; b=Ix70AXpNtvYeJou3eGqNME4shs6O9zZHhoX/CzXKpTCMjp0EPPDXQXISGrlCZCy4G/ ds5iAnxB/QQ3rDAcPE/ghJInFudkQfWNeTk1Tv0xMyFA+Ckc2ALyRyDcL9ONYF/aFWaK bSHmmzHSn/O+kPgT4+OI5D9zFHgklJmtrlVpwc/fMcK69OGVqkJpy5Km0HA3bxfdPSKO LiChITjEuTsyji2zZiovu2XAKqQZGObAT4W26ahCeaeEs92WhvVKJC+mRtqxapIG+WIy MlumfruiiV1TjPua2DDbsAxMJT7X8wPsQCbVPzQvPi3wn0rHRKhjGj95Vo1bGSdI6065 pPfQ== X-Forwarded-Encrypted: i=1; AJvYcCWCuwofzoBfR1kLkpUcxpRWcISgyAaZhkQRFsrxcojg53Ivb85uRxFrsLE6mI4PFViRSTgrlQ==@lists.linux.dev X-Gm-Message-State: AOJu0Yxqyw7KbvsK8e+BKp0qg4eJLSyFRGMOC8bwtl12+xldC7edHxnW zy8NEtQCYJN/ufurCVdNnBtRoMgYcME0PLMbbxZnCTCWbAvCTV0qrV/APTa96g== X-Google-Smtp-Source: AGHT+IFXWx05e/+XweIL+R6dsRvJNpSo2hQC1mySqaLDGAhfbYvgJChv9vcvthH548sGd8lARL2kdw== X-Received: by 2002:a17:903:22c7:b0:1fa:fe30:8fce with SMTP id d9443c01a7336-20510b5500dmr423205ad.23.1724884082803; Wed, 28 Aug 2024 15:28:02 -0700 (PDT) Received: from google.com (83.92.168.34.bc.googleusercontent.com. [34.168.92.83]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2d844618f6csm2496536a91.27.2024.08.28.15.28.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Aug 2024 15:28:02 -0700 (PDT) Date: Wed, 28 Aug 2024 22:27:59 +0000 From: Sami Tolvanen To: Masahiro Yamada Cc: Luis Chamberlain , Miguel Ojeda , Greg Kroah-Hartman , Matthew Maurer , Alex Gaynor , Wedson Almeida Filho , Gary Guo , Petr Pavlu , Neal Gompa , Hector Martin , Janne Grunau , Asahi Linux , linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, linux-modules@vger.kernel.org, rust-for-linux@vger.kernel.org Subject: Re: [PATCH v2 06/19] gendwarfksyms: Add a cache for processed DIEs Message-ID: <20240828222759.GG2130480@google.com> References: <20240815173903.4172139-21-samitolvanen@google.com> <20240815173903.4172139-27-samitolvanen@google.com> Precedence: bulk X-Mailing-List: asahi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Thu, Aug 29, 2024 at 03:15:02AM +0900, Masahiro Yamada wrote: > On Fri, Aug 16, 2024 at 2:39 AM Sami Tolvanen wrote: > > +static int append_item(struct die *cd, struct die_fragment **res) > > +{ > > + struct die_fragment *prev; > > + struct die_fragment *df; > > + > > + df = malloc(sizeof(struct die_fragment)); > > + if (!df) { > > + error("malloc failed"); > > + return -1; > > + } > > + > > + df->type = EMPTY; > > + df->next = NULL; > > + > > + prev = cd->list; > > + while (prev && prev->next) > > + prev = prev->next; > > > > So, this entirely traverses the singly-linked list > every time a new item is appended to the tail. > > > In my analysis, this while loop iterates for thousands > of times in total for emitting each export symbol. > > > Why isn't this list_add_tail()? Good catch, I'll fix this in the next version. Keeping track of the last element should be sufficient, but I agree, using the existing list implementation is probably cleaner. Thanks! Sami