From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 617FE15B992 for ; Wed, 25 Sep 2024 23:00:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727305210; cv=none; b=lmok8EjZWa4vfor2DDL9iFJvJbTUID5SZvoUhaOMK5ht6jykqeXTt6mYlPhg9RjaxQ/x25cV6De8aXSFNEJbBth2n5w6NfdfYXI7oGDxLx6ON1p8YAhE3W6XHdViujN6r8I1w9VXiNd3g0wETmyR2tEqQmZB7VL9OqmxXdRqrew= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727305210; c=relaxed/simple; bh=kQStd7Sr/RrN6skcJm3qMMqtRvr2awicCI5PoWvm6FU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=pTVoY/gQn/icMvrZGwGSvNoZukeBuyEq3rj8JY/mCYLZghKCOjqJfUnYxXu9r4lSWgyllouaH9qlmPl2jtr471+fIX5PVmuYiE2q9kZPDFP5QroMtCLDIbHdGfNKIMk4jryXS1L0Zu+j3CSxUd/SrPw7gvaUiXc7oullJrxZLW4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=KHLuImGB; arc=none smtp.client-ip=209.85.214.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="KHLuImGB" Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-2056aa5cefcso66145ad.0 for ; Wed, 25 Sep 2024 16:00:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1727305209; x=1727910009; darn=lists.linux.dev; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Vl8E5j+ZmDbmKOpu44SNpmShgOamIMtl/ODRrZ2cGY4=; b=KHLuImGBY5F87nmd0yy59oO3c1ybR99/cMdtZMOksO5UvKuG4CU+cQtgoRcZFYPmT3 TC/GB0ww62JCiuQqti1x3IOH6JS0mdsqH4y25QA4sjpPkEvH6tRl6NykseSn4tXg5NUO qcsWnUBky4HPYC5We3iy9OpSmUtGyhDEfzgidb1RTVjt3JtPXOQhZnptyfUPa2uz5LK1 K4i3fEfFr4Ux/+VBhUHuXJfAsnv1wunWUZ0WO0FGqLKDt61AJ0qAkYod34axh4xkqBLP 3osVNeAhmtIGWOK15TlD9ocsdqSDFI785Y66mAV7RuRwRWZCKUP6VZzqBZwB3gsZkcey yu4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727305209; x=1727910009; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Vl8E5j+ZmDbmKOpu44SNpmShgOamIMtl/ODRrZ2cGY4=; b=ibUn3SvNSm0en6y7vJioJOWsHLGDZo/1AEuO42mSUFBMmkNwSgJUkZI5azDPeGWQmN EIbpmidtHMg0ZW0+SHvNuMgUJovc0SGf3LiHr4j590v+9KnwAaXtzySe5fYQKXi4TEOa DTSnZNZj5fFPI9YRtrBTYEF7tfV8tcDQh8TZ/Kcrkj+jvRe1mf+StZB3aVD9MhNyQftV 95A+fSFv9ajtI5sbSpGrM5CQbm8+kq/SOfr/U5QGMiq5l9Dsnd+xCy3iHHmj21tFhaV1 660nZXR6GDlyk2aDeMQ/T+2ct0cLJZHKCmmhoOtV+L3HNajKjN/DVl0RjaB3WQbH4G+m CCkw== X-Forwarded-Encrypted: i=1; AJvYcCVcGV3oNJgRwzyJzCAWO+H4VvUR501XRwscSgJRrQtIP2wCYYybSbNL6aHmhj5sdJ54C1ZRbA==@lists.linux.dev X-Gm-Message-State: AOJu0YxG2wajSoND9TlWsWxc8V7ZHkYDxWdTvseMnliWaX8eecMIR2MH CoKzI8qaO0R9lfnefKkrihpyajrBwtLnpzhnl0Q4x487kGTHLcRMCDobbE8UNw== X-Google-Smtp-Source: AGHT+IFG1pBJvk67WuIMPqXmbr6qCgX/nanvp1+Hex9+YWAbxaQzu9KQp5bWrdANVwkkvt84iFfWmg== X-Received: by 2002:a17:902:ec83:b0:206:a87c:2873 with SMTP id d9443c01a7336-20b202f1655mr563355ad.5.1727305208163; Wed, 25 Sep 2024 16:00:08 -0700 (PDT) Received: from google.com (164.135.233.35.bc.googleusercontent.com. [35.233.135.164]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-71afc8493cdsm3190227b3a.88.2024.09.25.16.00.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Sep 2024 16:00:07 -0700 (PDT) Date: Wed, 25 Sep 2024 23:00:00 +0000 From: Sami Tolvanen To: Matthew Maurer Cc: masahiroy@kernel.org, ndesaulniers@google.com, ojeda@kernel.org, gary@garyguo.net, mcgrof@kernel.org, Michael Ellerman , Alex Gaynor , Benjamin Gray , Naveen N Rao , rust-for-linux@vger.kernel.org, linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, neal@gompa.dev, marcan@marcan.st, j@jannau.net, asahi@lists.linux.dev, Nicholas Piggin , Christophe Leroy , Madhavan Srinivasan , Petr Pavlu , Daniel Gomez , Boqun Feng , =?iso-8859-1?Q?Bj=F6rn?= Roy Baron , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , linuxppc-dev@lists.ozlabs.org, linux-modules@vger.kernel.org Subject: Re: [PATCH v4 14/16] modules: Support extended MODVERSIONS info Message-ID: <20240925230000.GA3176650@google.com> References: <20240924212024.540574-1-mmaurer@google.com> <20240924212024.540574-15-mmaurer@google.com> Precedence: bulk X-Mailing-List: asahi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240924212024.540574-15-mmaurer@google.com> Hi Matt, On Tue, Sep 24, 2024 at 09:19:56PM +0000, Matthew Maurer wrote: > +static void dedotify_ext_version_names(char *str_seq, unsigned long size) > +{ > + unsigned long out = 0; > + unsigned long in; > + char last = '\0'; > + > + for (in = 0; in < size; in++) { > + if (last == '\0') > + /* Skip one leading dot */ > + if (str_seq[in] == '.') > + in++; Thanks for addressing Michael's comment, this looks correct to me. Nit: might be cleaner in a single if statement though: /* Skip one leading dot */ if (last == '\0' && str_seq[in] == '.') in++; > +void modversion_ext_start(const struct load_info *info, > + struct modversion_info_ext *start) > +{ > + unsigned int crc_idx = info->index.vers_ext_crc; > + unsigned int name_idx = info->index.vers_ext_name; > + Elf_Shdr *sechdrs = info->sechdrs; > + > + /* > + * Both of these fields are needed for this to be useful > + * Any future fields should be initialized to NULL if absent. > + */ > + if ((crc_idx == 0) || (name_idx == 0)) > + start->remaining = 0; > + > + start->crc = (const s32 *)sechdrs[crc_idx].sh_addr; > + start->name = (const char *)sechdrs[name_idx].sh_addr; > + start->remaining = sechdrs[crc_idx].sh_size / sizeof(*start->crc); > +} This looks unchanged from v3, so I think my comment from there still applies: https://lore.kernel.org/lkml/CABCJKufJK0WO92wnW09VTLqZk0ODxhuKQG=HbKE-va0urJU1Vg@mail.gmail.com/ Sami