From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f202.google.com (mail-pl1-f202.google.com [209.85.214.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7A62922A489 for ; Wed, 30 Oct 2024 17:01:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.202 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730307716; cv=none; b=pjPZCPoOia77eVa29WOmzL4mbtIBKHYAdfeflMJlt20i3/zlKvKLaEzHb3OmwGh7c8qv86jMsWFFJ0XxDo2j+o9asNohIn/06ODr5EY0S/9i7GbKlDBSc1qwiVhXF9OVSBM1eOiECv9DLrmt8TjnErDf/1WlkauAAbFTB1y/k6Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730307716; c=relaxed/simple; bh=rksEvC6HZ/MrrqljgbD4UQU0K86C0fyQIL1Xtq9Es3w=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=Ncq2sszkevEF6pTV8sPoSl44Ovxwm0SwOapNc+mZgWtH0iYkBcFABAseR6JPiijvh9Mb8Bn/cWdN4uSQ7WzeUPWjh405W4Bl1qpHqQIvnvjydvPYJ+Dfu438L6UOBuj1C9YuaSkCP88+QSG1ES3DCS9JMiAmjCUbzO0783nBoJ4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--samitolvanen.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=4xRqq6lv; arc=none smtp.client-ip=209.85.214.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--samitolvanen.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="4xRqq6lv" Received: by mail-pl1-f202.google.com with SMTP id d9443c01a7336-20cb3d9f5eeso321325ad.1 for ; Wed, 30 Oct 2024 10:01:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1730307712; x=1730912512; darn=lists.linux.dev; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=K7eFA8HtUgZFV05J7QoEMTMnbx6tYPL9kZjt/pwvBV0=; b=4xRqq6lv3WrdzHlYKuB80vktGfOQBFHOFtfkYsEhoneN4Y2G+s2NhdSsAIrYdp/adl QD8GGiXegAxoI9BbcghTrkDDJJk8v/xMnVFEBH/oCjtjoYsKyB1LxxQwnaNM4hgn1MkY Qx9ui2ikUqvFYZHty62kx4xPBsZDRDcBdInha8fxKlMmJUTl/zleF3whKca45CX7CK+X mfdz9AdSWizkH/1d1871Ahg4WS62YDI/nB+Uy7+SEkxh7gd0Aw880yUTWJ9grNXUOHfD MtNCke4OjNkSWvTG9p+bBAraKtOttrwboUZT7pHQt/jy73jj860lX0sD542z+14UIbGf feag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730307712; x=1730912512; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=K7eFA8HtUgZFV05J7QoEMTMnbx6tYPL9kZjt/pwvBV0=; b=CSqLdBI5hPSGpr78BpVdH97BqGxocNR+QvxO1RgA+SZfxWZ1NrPaRwlYfHJ3qAtINr SCe9fPF71cFjnoOQ5YT5VgkdJ6XFqPqSL6fUHWO1p8XelaSH2sKnyAI2cII4XWLc/bVZ /TkJMbpUnH3dFI2xoaoTFWqVsYFLDWcj4uJKTGjMYiUhtE++BY+y86owJTjzN6sZQvYj vSAhAAcQs6HDm/kGIakRXJrj+xEpqc113DbNh/aytVxPoAy+kEqINCA8wthx3+H9lf8b b6M8rgcSt9vwFwC5oMiXfV+OcVzN+hGduleYFJ4Q+XZdFBjTlwyxGP3VPsxnUV9AvUMP QnzA== X-Forwarded-Encrypted: i=1; AJvYcCWi520ct1z83Lo8zog1SKOS4hgTfxQYV6selJ+14xyqQLepKkYKhNLnYKZ7R9RIdF4WBjS8Gw==@lists.linux.dev X-Gm-Message-State: AOJu0YxSddyeFD5yPTD8xDG+wpu373iB5iHHtQxHSfvwjxBZG6Ff6SDn O3w8lFig5t6ss3n6/3RM8wS27fE7+9EwEkmOp80Qxs9sbWALEMVtzrWuz6qT2BGT8vSQH6VDyA9 2Zfi81O1EF0tXElvc35J9BjyMcA== X-Google-Smtp-Source: AGHT+IFeuji1GvoYInueYeA2WpLljEcP1b95Twypfv+fPllRTgDVEPi5y36JJdk4mGTm6hE159syArTxkGm4qK6S4mY= X-Received: from samitolvanen.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:4f92]) (user=samitolvanen job=sendgmr) by 2002:a17:903:32d0:b0:209:dc6d:769e with SMTP id d9443c01a7336-210ed3e47afmr348575ad.0.1730307712375; Wed, 30 Oct 2024 10:01:52 -0700 (PDT) Date: Wed, 30 Oct 2024 17:01:24 +0000 In-Reply-To: <20241030170106.1501763-21-samitolvanen@google.com> Precedence: bulk X-Mailing-List: asahi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20241030170106.1501763-21-samitolvanen@google.com> X-Developer-Key: i=samitolvanen@google.com; a=openpgp; fpr=35CCFB63B283D6D3AEB783944CB5F6848BBC56EE X-Developer-Signature: v=1; a=openpgp-sha256; l=2044; i=samitolvanen@google.com; h=from:subject; bh=rksEvC6HZ/MrrqljgbD4UQU0K86C0fyQIL1Xtq9Es3w=; b=owGbwMvMwCEWxa662nLh8irG02pJDOlKadESFw9Lm7oed/RRtkqsu5E/5f5WozXTDVWmHDAqW iFQ8+RURykLgxgHg6yYIkvL19Vbd393Sn31uUgCZg4rE8gQBi5OAZjIVAlGhs37+tc8uJK4WkvL z7N+VlXd3DmaWw4IPPWsz7uRlDvJ6hDDL+YpDQonlhzcKr4mp6rr80JBw9w/zK+cC3ufa17P2VT nwA0A X-Mailer: git-send-email 2.47.0.163.g1226f6d8fa-goog Message-ID: <20241030170106.1501763-38-samitolvanen@google.com> Subject: [PATCH v5 17/19] export: Add __gendwarfksyms_ptr_ references to exported symbols From: Sami Tolvanen To: Masahiro Yamada , Luis Chamberlain , Miguel Ojeda , Greg Kroah-Hartman Cc: Matthew Maurer , Alex Gaynor , Gary Guo , Petr Pavlu , Daniel Gomez , Neal Gompa , Hector Martin , Janne Grunau , Miroslav Benes , Asahi Linux , Sedat Dilek , linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, linux-modules@vger.kernel.org, rust-for-linux@vger.kernel.org, Sami Tolvanen Content-Type: text/plain; charset="UTF-8" With gendwarfksyms, we need each TU where the EXPORT_SYMBOL() macro is used to also contain DWARF type information for the symbols it exports. However, as a TU can also export external symbols and compilers may choose not to emit debugging information for symbols not defined in the current TU, the missing types will result in missing symbol versions. Stand-alone assembly code also doesn't contain type information for exported symbols, so we need to compile a temporary object file with asm-prototypes.h instead, and similarly need to ensure the DWARF in the temporary object file contains the necessary types. To always emit type information for external exports, add explicit __gendwarfksyms_ptr_ references to them in EXPORT_SYMBOL(). gendwarfksyms will use the type information for __gendwarfksyms_ptr_* if needed. Discard the pointers from the final binary to avoid further bloat. Signed-off-by: Sami Tolvanen Acked-by: Neal Gompa --- include/linux/export.h | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/include/linux/export.h b/include/linux/export.h index 0bbd02fd351d..cf71d3202e5b 100644 --- a/include/linux/export.h +++ b/include/linux/export.h @@ -52,9 +52,24 @@ #else +#ifdef CONFIG_GENDWARFKSYMS +/* + * With CONFIG_GENDWARFKSYMS, ensure the compiler emits debugging + * information for all exported symbols, including those defined in + * different TUs, by adding a __gendwarfksyms_ptr_ pointer + * that's discarded during the final link. + */ +#define __GENDWARFKSYMS_EXPORT(sym) \ + static typeof(sym) *__gendwarfksyms_ptr_##sym __used \ + __section(".discard.gendwarfksyms") = &sym; +#else +#define __GENDWARFKSYMS_EXPORT(sym) +#endif + #define __EXPORT_SYMBOL(sym, license, ns) \ extern typeof(sym) sym; \ __ADDRESSABLE(sym) \ + __GENDWARFKSYMS_EXPORT(sym) \ asm(__stringify(___EXPORT_SYMBOL(sym, license, ns))) #endif -- 2.47.0.163.g1226f6d8fa-goog