From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f202.google.com (mail-pl1-f202.google.com [209.85.214.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 788AE1DE4D3 for ; Thu, 21 Nov 2024 20:43:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.202 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732221786; cv=none; b=Eb+h7bN1zQbDOM4+/dtfypxR3BUOxTZlQMh6kmejWBWyiQwGzSdnh3XcZTuc1PqJFxH9TGNaQs6faHx+mUyEZSrD/CUs3AatImNjJHoKPmHtQOT4XFKrGYeI9SKcI7vViJQQEaIBjwaTQGf+LY7tgCt4vi1dHWUGsW+zVxpOvR0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732221786; c=relaxed/simple; bh=xtaSIvxHknHitZ36vqFnUTb8roe1ES/1Z1TTODMFmEs=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=efLhY9hF4OjjmSPmbZjdnxvhxyEM2EbCa2CSSYNEHabQrHCiyrTLHwjJ1svKkIL/6/UKuGmhiIXQ8QTuhzJCVHDz1/N2zLoukVvW5VW4JOk1rFf+feRD11MrZ5oQ2LjiKtE7b+PLLfzpBopt/9dT3Y/alFW0qlvnKIGIlMUqi6U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--samitolvanen.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=eoYkKihe; arc=none smtp.client-ip=209.85.214.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--samitolvanen.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="eoYkKihe" Received: by mail-pl1-f202.google.com with SMTP id d9443c01a7336-2125d54fbc1so13099095ad.3 for ; Thu, 21 Nov 2024 12:43:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1732221783; x=1732826583; darn=lists.linux.dev; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=BV+aUvfqJMcZq8xGaB9yJiMSnj11evO//RiyZr5bI/4=; b=eoYkKiheOYcAZ20bz2AbG+rI5TRe2bRZgc6uL8HH58GcblAA+tOaCxbEeNx1VJBlLH dnxj+/ku6sJuR+h3lrjfcw/sgwD8mx9+pfYSvnw79y58KG+18vThorzaCSeEl5sXAkTK beT4as7EbZCZoSMfQhA43ppqcmOlC9vcngxBKHxbQ8xeUK7uEv6k2oZNRC7IIBpmihUM V7/5niXT7oDWUG4Bl/sLSmpchQ89Eyyn0vc6FD+tKLfy4RcL27FRl1omMUmd0VQIyhUZ Ro9xRWP0sbEzSrfsAlOA5dOVbrdmspChwshO2xdcEJhv13tLBfcYwQP2oDkN6MH2etVh AnGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732221783; x=1732826583; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=BV+aUvfqJMcZq8xGaB9yJiMSnj11evO//RiyZr5bI/4=; b=dmfuxDW16n+8QRBTqp/yApdpBOuuxxF7SrAkDoZAu3N6Bn3RavyHpb2lsMKZtj7zdP WSDtD9pIuu3lZJb5Dgd7xpuDBeRGN1rF30Ab6IjYiQ8oOhhSThiestT/hHa2dt4s58yU q/AB0+yXjKa22W5Vcfhtu6ut+GNF/pKRUr2H0SRwnyyVglmD+Q8F7wLdjSO9LYjemoa+ unTAJK9WO1ZMRhrauMxOSIZ9as3vCH2+ZhTDiNirGJ+/T6Bjq33LFnYsxDtd3WtPb8Yx CAGfYj3rW4Q9yHiRXPD0E0jFXcO6Y3k4Pv85cq9FHebtrNC0bg+MAzh9UkDjoXPYKn9L oGsA== X-Forwarded-Encrypted: i=1; AJvYcCUsILq58z8P3+X5bThFosBJILGyhuMrozMVTZAdjLOUi1v85a0XNgZByRnI5ruXj8B68iqRHQ==@lists.linux.dev X-Gm-Message-State: AOJu0YwhGFSXhlrGL84irIvRX1XSIK2YYtDuevqvL0qVM8ddj8lwfYGC y8EXZxkOx5rUgauxBvTWbejn5rKGX3L1peqUWqlqsx+q8TtTMYGgKw6cL2oD56+JXvoZPp3tacU dCknMwaQu24XHgeH5ES8NKefHgg== X-Google-Smtp-Source: AGHT+IEL8dfJrjeB7OOZP3DGVEJNUwuVUxTwOq2yx0IpeIeDGWPIyVAbuB88MKF3tMDhLZ35CoQVhQdB25OFLx22EmU= X-Received: from samitolvanen.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:4f92]) (user=samitolvanen job=sendgmr) by 2002:a17:902:facc:b0:212:673a:c18e with SMTP id d9443c01a7336-2129f20e86dmr2275ad.2.1732221783527; Thu, 21 Nov 2024 12:43:03 -0800 (PST) Date: Thu, 21 Nov 2024 20:42:37 +0000 In-Reply-To: <20241121204220.2378181-20-samitolvanen@google.com> Precedence: bulk X-Mailing-List: asahi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20241121204220.2378181-20-samitolvanen@google.com> X-Developer-Key: i=samitolvanen@google.com; a=openpgp; fpr=35CCFB63B283D6D3AEB783944CB5F6848BBC56EE X-Developer-Signature: v=1; a=openpgp-sha256; l=2005; i=samitolvanen@google.com; h=from:subject; bh=xtaSIvxHknHitZ36vqFnUTb8roe1ES/1Z1TTODMFmEs=; b=owGbwMvMwCEWxa662nLh8irG02pJDOn2s01DnoisXl+/y+usjtDHjTJL9TPntS5fHLCojZMtu Pxch01XRykLgxgHg6yYIkvL19Vbd393Sn31uUgCZg4rE8gQBi5OAZjIPgmGf3p2aUsZb0SxHjge XHf1TNqhRoH9OVde/Tj/1sjBfJd3dCDDP8vyeRd2KClw+Lw69uqgzdFf80++vRYtvHvjk2+5AUZ LmpgA X-Mailer: git-send-email 2.47.0.371.ga323438b13-goog Message-ID: <20241121204220.2378181-36-samitolvanen@google.com> Subject: [PATCH v6 16/18] export: Add __gendwarfksyms_ptr_ references to exported symbols From: Sami Tolvanen To: Masahiro Yamada , Luis Chamberlain , Miguel Ojeda , Greg Kroah-Hartman Cc: Matthew Maurer , Alex Gaynor , Gary Guo , Petr Pavlu , Daniel Gomez , Neal Gompa , Hector Martin , Janne Grunau , Miroslav Benes , Asahi Linux , Sedat Dilek , linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, linux-modules@vger.kernel.org, rust-for-linux@vger.kernel.org, Sami Tolvanen Content-Type: text/plain; charset="UTF-8" With gendwarfksyms, we need each TU where the EXPORT_SYMBOL() macro is used to also contain DWARF type information for the symbols it exports. However, as a TU can also export external symbols and compilers may choose not to emit debugging information for symbols not defined in the current TU, the missing types will result in missing symbol versions. Stand-alone assembly code also doesn't contain type information for exported symbols, so we need to compile a temporary object file with asm-prototypes.h instead, and similarly need to ensure the DWARF in the temporary object file contains the necessary types. To always emit type information for external exports, add explicit __gendwarfksyms_ptr_ references to them in EXPORT_SYMBOL(). gendwarfksyms will use the type information for __gendwarfksyms_ptr_* if needed. Discard the pointers from the final binary to avoid further bloat. Signed-off-by: Sami Tolvanen --- include/linux/export.h | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/include/linux/export.h b/include/linux/export.h index 0bbd02fd351d..cf71d3202e5b 100644 --- a/include/linux/export.h +++ b/include/linux/export.h @@ -52,9 +52,24 @@ #else +#ifdef CONFIG_GENDWARFKSYMS +/* + * With CONFIG_GENDWARFKSYMS, ensure the compiler emits debugging + * information for all exported symbols, including those defined in + * different TUs, by adding a __gendwarfksyms_ptr_ pointer + * that's discarded during the final link. + */ +#define __GENDWARFKSYMS_EXPORT(sym) \ + static typeof(sym) *__gendwarfksyms_ptr_##sym __used \ + __section(".discard.gendwarfksyms") = &sym; +#else +#define __GENDWARFKSYMS_EXPORT(sym) +#endif + #define __EXPORT_SYMBOL(sym, license, ns) \ extern typeof(sym) sym; \ __ADDRESSABLE(sym) \ + __GENDWARFKSYMS_EXPORT(sym) \ asm(__stringify(___EXPORT_SYMBOL(sym, license, ns))) #endif -- 2.47.0.371.ga323438b13-goog