From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6C05122FE13 for ; Thu, 27 Feb 2025 12:10:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740658204; cv=none; b=l1nDzMNvLp/jhNO6U9IO+uWy8fOZqGzv/Kne2l6zgsynR4G70LPnsRWZncIK/ivszU9nlNlRdxZ7CwzWbm5GC5KMFPZESakv5zdgjzr0VfWl/TN6Q1ukqftlyR3M5kjPZE8tGq9HgoXd0tqpWaZeA9i2QbHfhPhFRI35ms33moc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740658204; c=relaxed/simple; bh=VAlMGbLBKi4xU+F696Y6zd+wEM/gtuswNpD/DqJM1CA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=VV1EOFq6aPy9TJpkaRMyK6mC2GEOGhCX54cNqlXejjoTWFsjyyiy7mRLbJm7FXTNlvWpGo3LtxDNTcNLKfjEZ1oKKQAD3s8IBBIsI5aUI5gaA2Jb1dOALf6uQfyCCME+PvADXtrQ/8tmJCuEV5yhdeDiqJdGM8d5BC6bUTBMRv8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=EDzdiyoj; arc=none smtp.client-ip=209.85.214.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="EDzdiyoj" Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-22185cddbffso33993775ad.1 for ; Thu, 27 Feb 2025 04:10:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1740658202; x=1741263002; darn=lists.linux.dev; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=C5ry6J/NoVdSnpNYCNQjATClf2ygTLOYGGyh+loV86o=; b=EDzdiyojsOq9W8ghYsdyinDLRuKuIrl6XgBgtimoUJniuT4MtXPlrMXL1L6lrg4rv7 RlgTMvu62ybK7FvvLFRW/yBXOum+wLaTtHVAFcZ4I9GPQCSKaZK+QtEdmeI3YJZuWBAf 80Kf0tW4Oq65Wb13YyWx2aO3GwKhx0JLSZ6MxUOH31JIzvGmxMJDtrcJOhN2+rLMgKuL GU5MWH9XVuwKAesbCx5dM6nVi/qqT/4SGNoAptzwJFcyieZr6bFaqiJ0S61pDTxME605 Rn5/8HGlv0K09yNovxFAE9fcgLXEnTmyCAYtf5Xwjd1xSCXyTBWJTFrJjm/RWZBDAzVd 6ESw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740658202; x=1741263002; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=C5ry6J/NoVdSnpNYCNQjATClf2ygTLOYGGyh+loV86o=; b=vkrIf6AmC761SvspPHtERs22wKH5h+5nQ7auPQUA2Mt1vjy/IRObJoj/wFkVne4yCY OMzLLR1NqlVPpNkNuUBEWm/IqKwOIkt5GEruwJQwUbnZV6+aSr1GzCLl9+7/jf0jJyQj NS4he+yHy+e4Hz6Pme9pcoTiy/a0JIAElR6s7+SvELosDjvppBipS2cpuPvd6e84LibV hkFVhc2tNgh1qUl8WXCQ3A6tnufYLjfdwz8YOEvuYaO/H5ELK9M1n0SrDnSkiv65gTDp cSG/huZg80a167FXA3LbWvb62WqcIw4Y7d/jTLNgZOny7xpJ7WgwSsd5sOFU6CqKnmWs BZzg== X-Forwarded-Encrypted: i=1; AJvYcCXqRqiV6XMppfXYTgT0VjtIaacf8ri0gJUe+1BN1Z1NzfkhsDQMw0ii+QNv3Zmy1z+kUS7lIQ==@lists.linux.dev X-Gm-Message-State: AOJu0YwX2NQKCs05bjoidnsr7wWvtcH4uZOvvJUzgQlHrJFkVLqVpZXn lEC9BRf1M3J1xJihleJh4dpcePKyKJjhSe7BYl0bndBYj3q9MpV1fCqZpyLH X-Gm-Gg: ASbGncvLGi+kfjZDdhFPDcHI9xlA1e3pfg5zdZFsMlNpc5QgUT1Sg5rlVQmDmRa+Gbp CdiYnWeMnVJ6ZJI2CP2Sdr511f95T/+wV2RRlO2U4blmDHqIcFKw+HW74d9uSeLEqPQLGOnOUbK bCOz/s+9PXfIXc0qrE+XZziojG+w98IljNvZP6JgUOLh8u1GsVq5TALL1CnMB3vgNgkBDxcVuAD 8gi9yyMpoYs0cfh9dv74aEbnvFaFB+ki/QeEI0slptuPHm3R/w1ODzYPNLgo7ElIYoq3f4BKQRL 5u5QcGuykh/6GT0KfVDYaoq4CtnBJ+k2sKY7ULK0oAfuDMNS/uw0LJ0JznVlHqz9porw5xFuLUA soqFD4WebIywopWg26/Lm X-Google-Smtp-Source: AGHT+IELA2MVEJT24EW2bxG3k6ZlSSpQ5TmMYRzmcOjW8RmSRjowq6jcIcch4pPSi6eG4EqbV3bfRg== X-Received: by 2002:a05:6a20:8402:b0:1ee:b5f4:b1d7 with SMTP id adf61e73a8af0-1f2e387ef46mr4574714637.7.1740658202396; Thu, 27 Feb 2025 04:10:02 -0800 (PST) Received: from [192.168.2.3] (2403-580a-80ed-0-4835-5a07-49e7-f115.ip6.aussiebb.net. [2403:580a:80ed:0:4835:5a07:49e7:f115]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-aee7de19cdasm1074217a12.24.2025.02.27.04.09.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Feb 2025 04:10:02 -0800 (PST) From: James Calligeros Date: Thu, 27 Feb 2025 22:07:36 +1000 Subject: [PATCH v3 09/20] ASoC: tas2764: Configure zeroing of SDOUT slots Precedence: bulk X-Mailing-List: asahi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Message-Id: <20250227-apple-codec-changes-v3-9-cbb130030acf@gmail.com> References: <20250227-apple-codec-changes-v3-0-cbb130030acf@gmail.com> In-Reply-To: <20250227-apple-codec-changes-v3-0-cbb130030acf@gmail.com> To: Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Shenghao Ding , Kevin Lu , Baojun Xu , Dan Murphy , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shi Fu , Jean Delvare , Guenter Roeck Cc: Alyssa Rosenzweig , =?utf-8?q?Martin_Povi=C5=A1er?= , Hector Martin , linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, asahi@lists.linux.dev, linux-hwmon@vger.kernel.org, Neal Gompa , James Calligeros X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2998; i=jcalligeros99@gmail.com; h=from:subject:message-id; bh=tMEwKfdUcN1GIbtYuD0/lRExutgObIXbnosPkubAYYI=; b=owGbwMvMwCV2xczoYuD3ygTG02pJDOkHQk91JD2dOGkue/LVHa91VHiZt06qVls9aaqbZ73MP //+LZsjO0pZGMS4GGTFFFk2NAl5zDZiu9kvUrkXZg4rE8gQBi5OAZjI9hxGhua/CRt//fpdmu7u N/nek1tPplZciP4VuknN+dqShJW/Aw4w/LOxSu5c9p7jUVWk1azr3Zd/PM+f1ZDL83mD4Z+Uw5m 7pVkB X-Developer-Key: i=jcalligeros99@gmail.com; a=openpgp; fpr=B08212489B3206D98F1479BDD43632D151F77960 From: Martin Povišer The codec has an option to zero out certain TDM slots on its SDOUT output according to a preconfigured mask (otherwise the output is, for the duration of unused slots, in a Hi-Z state). Since the programmed value is dependent on how the chip is implemented on a given board, configure this feature based on a mask read from the specific codec's Devicetree node. Reviewed-by: Neal Gompa Signed-off-by: Martin Povišer Signed-off-by: James Calligeros --- sound/soc/codecs/tas2764.c | 23 +++++++++++++++++++++++ sound/soc/codecs/tas2764.h | 11 +++++++++++ 2 files changed, 34 insertions(+) diff --git a/sound/soc/codecs/tas2764.c b/sound/soc/codecs/tas2764.c index 49b73b74b2d9dd6d09747cabc2b00519c549775d..f33ac89ffc598c39f3a7e0d620724098ca5bc3d3 100644 --- a/sound/soc/codecs/tas2764.c +++ b/sound/soc/codecs/tas2764.c @@ -40,6 +40,7 @@ struct tas2764_priv { int v_sense_slot; int i_sense_slot; + u32 sdout_zero_mask; bool dac_powered; bool unmuted; @@ -601,6 +602,23 @@ static int tas2764_codec_probe(struct snd_soc_component *component) if (ret < 0) return ret; + if (tas2764->sdout_zero_mask) { + for (i = 0; i < 4; i++) { + ret = snd_soc_component_write(component, TAS2764_SDOUT_HIZ_1 + i, + (tas2764->sdout_zero_mask >> (i * 8)) & 0xff); + + if (ret < 0) + return ret; + } + + ret = snd_soc_component_update_bits(component, TAS2764_SDOUT_HIZ_9, + TAS2764_SDOUT_HIZ_9_FORCE_0_EN, + TAS2764_SDOUT_HIZ_9_FORCE_0_EN); + + if (ret < 0) + return ret; + } + switch (tas2764->devid) { case DEVID_SN012776: ret = snd_soc_component_update_bits(component, TAS2764_PWR_CTRL, @@ -749,6 +767,11 @@ static int tas2764_parse_dt(struct device *dev, struct tas2764_priv *tas2764) if (ret) tas2764->v_sense_slot = 2; + ret = fwnode_property_read_u32(dev->fwnode, "ti,sdout-force-zero-mask", + &tas2764->sdout_zero_mask); + if (ret) + tas2764->sdout_zero_mask = 0; + return 0; } diff --git a/sound/soc/codecs/tas2764.h b/sound/soc/codecs/tas2764.h index 3251dc0106e07862dd69efd69fa0e40c3858ecb7..4cf0f7f112d6c3002203fa32e900efd640ef3f22 100644 --- a/sound/soc/codecs/tas2764.h +++ b/sound/soc/codecs/tas2764.h @@ -123,4 +123,15 @@ #define TAS2764_BOP_CFG0 TAS2764_REG(0X0, 0x1d) +#define TAS2764_SDOUT_HIZ_1 TAS2764_REG(0x1, 0x3d) +#define TAS2764_SDOUT_HIZ_2 TAS2764_REG(0x1, 0x3e) +#define TAS2764_SDOUT_HIZ_3 TAS2764_REG(0x1, 0x3f) +#define TAS2764_SDOUT_HIZ_4 TAS2764_REG(0x1, 0x40) +#define TAS2764_SDOUT_HIZ_5 TAS2764_REG(0x1, 0x41) +#define TAS2764_SDOUT_HIZ_6 TAS2764_REG(0x1, 0x42) +#define TAS2764_SDOUT_HIZ_7 TAS2764_REG(0x1, 0x43) +#define TAS2764_SDOUT_HIZ_8 TAS2764_REG(0x1, 0x44) +#define TAS2764_SDOUT_HIZ_9 TAS2764_REG(0x1, 0x45) +#define TAS2764_SDOUT_HIZ_9_FORCE_0_EN BIT(7) + #endif /* __TAS2764__ */ -- 2.48.1