From: Sven Peter <sven@kernel.org>
To: Janne Grunau <j@jannau.net>, Neal Gompa <neal@gompa.dev>,
Vinod Koul <vkoul@kernel.org>,
Kishon Vijay Abraham I <kishon@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Philipp Zabel <p.zabel@pengutronix.de>
Cc: asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
linux-phy@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, Sven Peter <sven@kernel.org>,
Alyssa Rosenzweig <alyssa@rosenzweig.io>,
Hector Martin <marcan@marcan.st>
Subject: [PATCH v2 0/3] Apple Silicon Type-C PHY
Date: Sun, 23 Nov 2025 21:19:53 +0000 [thread overview]
Message-ID: <20251123-b4-atcphy-v2-0-34cc7092b22a@kernel.org> (raw)
Hi,
As requested in the previous version of the Apple Silicon USB3 support
series this one only contains the changes required for the Type-C PHY.
The generic tunable support inside driver/soc/apple will also be re-used
for Thunderbolt later but it's fine to take it through the PHY tree
since thunderbolt will depend on that anyway.
Changes in v2:
- Link to v1: https://patch.msgid.link/20251026-b4-atcphy-v1-0-f81b1225f9c6@kernel.org
- Picked up tags from Rob and Janne, thanks!
- Added additional sanity checks for the tunables to guard against bugs
in our bootloader (Janne)
- Used struct_size from overflow.h instead of open-coding it inside
tunables.c (Janne)
- Fixed a bunch of typos in atc.c pointed out by Mark Kettenis via IRC
Changes since v2 of the combined series:
- Link to v2: https://lore.kernel.org/asahi/20250906-atcphy-6-17-v2-0-52c348623ef6@kernel.org/
- atc.c:
- Removed a bunch of outdated safety checks from atc.c that were only
required in a previous version that did not rely on the dwc3-glue
driver
- Addressed Philipp's review comments:
- Added documentation for struct apple_atcphy (and a bunch of other
things while I was at it)
- Moved the mutex guard from atcphy_dpphy_configure to atcphy_dp_configure
since the first one doesn't touch any shared structures or MMIO
- apple,atcphy.yaml:
- Added a generic apple,tunable definition that uses uint32-matrix
and refer to that one from the individual tunable properties
- Adjust the tunable description to make it easier to understand
- Limited all lines to 80 chars
- Used > for longer descriptions
- Fixed some typos
- Picked up r-b tags (thanks!)
Best,
Sven
Signed-off-by: Sven Peter <sven@kernel.org>
---
---
Sven Peter (3):
soc: apple: Add hardware tunable support
dt-bindings: phy: Add Apple Type-C PHY
phy: apple: Add Apple Type-C PHY
.../devicetree/bindings/phy/apple,atcphy.yaml | 222 ++
MAINTAINERS | 2 +
drivers/phy/Kconfig | 1 +
drivers/phy/Makefile | 1 +
drivers/phy/apple/Kconfig | 14 +
drivers/phy/apple/Makefile | 4 +
drivers/phy/apple/atc.c | 2294 ++++++++++++++++++++
drivers/soc/apple/Kconfig | 4 +
drivers/soc/apple/Makefile | 3 +
drivers/soc/apple/tunable.c | 80 +
include/linux/soc/apple/tunable.h | 62 +
11 files changed, 2687 insertions(+)
---
base-commit: 3a8660878839faadb4f1a6dd72c3179c1df56787
change-id: 20251013-b4-atcphy-d6a7c939d417
Best regards,
--
Sven Peter <sven@kernel.org>
next reply other threads:[~2025-11-23 21:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-23 21:19 Sven Peter [this message]
2025-11-23 21:19 ` [PATCH v2 1/3] soc: apple: Add hardware tunable support Sven Peter
2025-11-23 21:19 ` [PATCH v2 2/3] dt-bindings: phy: Add Apple Type-C PHY Sven Peter
2025-11-23 21:19 ` [PATCH v2 3/3] phy: apple: " Sven Peter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251123-b4-atcphy-v2-0-34cc7092b22a@kernel.org \
--to=sven@kernel.org \
--cc=alyssa@rosenzweig.io \
--cc=asahi@lists.linux.dev \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=j@jannau.net \
--cc=kishon@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=marcan@marcan.st \
--cc=neal@gompa.dev \
--cc=p.zabel@pengutronix.de \
--cc=robh@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox