From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2607F1FF5E3; Tue, 30 Dec 2025 01:35:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767058506; cv=none; b=eIRgcCYDwP/HdtbJjHNZI+ThMyue9WZ9k7Xfgq+iuZF+kSFsyprAy0kijZmZzm3jH6zruVlMaJaGs7JGsC2AYTsRDl1YezectKpcJRgl4tBY8RHql7mqck4TZTMRI+dI2mtF6jJM1FxTiY2fCE4BafwVqUhNu8I8FZED5e48+3Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767058506; c=relaxed/simple; bh=Tj9LHQA+IIT2RlXp2c5HhaFtv0tgYyyX0N8rDKsQDgU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=WGUOKpAy1wEIROaym4ydcpcYCRo2/XPPzgrs+H54nofY67eTiHDxbrKTmjwKPcNrsu4JpwEwaa1Ha2R0s2qQV3jb/WW4gKDUl/Lxyo9EgmoL2jIUBh1WmlGPpdoEnqlkC9vN6/C5APdiVm8Gm5ZEBWtZ2v571fY1U1DMkSf9fYg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=DjBBMpBn; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="DjBBMpBn" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C9493C4CEF7; Tue, 30 Dec 2025 01:35:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1767058506; bh=Tj9LHQA+IIT2RlXp2c5HhaFtv0tgYyyX0N8rDKsQDgU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=DjBBMpBn+cZZetPVWGTzI+d5MWX9W8emEsUr69Bw1L8QtapARppZ4FwAlP3y/guwa c2LuKMi2BWOmbt7eDYDIclvlePNZVTmgtZOJQwAbdU6SQ1eMoobyrW3NFEGNzgGZZQ 3Z4ZQWmaEaI7+71ahs9FAP381YmEfru0JF79TCF7pN/EgnrIXPxpSS57G5aUU3TEFY GOxUoAiLJO+7E+D0cB1x14WZmTQeFmx0NoajJvGhJ6bQ4Y0X8UGe/GlyGSWTUDP54e AGxqgBGJOqmVtGVESheapDugYywmjmnrt3Sxt8aeA6S9l4WDAUEgikrHoaxgFc7+yn 7wNfPVdjJNjkw== Date: Mon, 29 Dec 2025 19:35:04 -0600 From: Rob Herring To: James Calligeros Cc: Liam Girdwood , Mark Brown , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Kuninori Morimoto , Shengjiu Wang , Jaroslav Kysela , Takashi Iwai , Shenghao Ding , Kevin Lu , Baojun Xu , linux-sound@vger.kernel.org, devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, asahi@lists.linux.dev Subject: Re: [PATCH v2 1/7] ASoC: dt-bindings: convert tdm-slot to YAML Message-ID: <20251230013504.GB3037280-robh@kernel.org> References: <20251221-tdm-idle-slots-v2-0-ed4d96413aec@gmail.com> <20251221-tdm-idle-slots-v2-1-ed4d96413aec@gmail.com> Precedence: bulk X-Mailing-List: asahi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251221-tdm-idle-slots-v2-1-ed4d96413aec@gmail.com> On Sun, Dec 21, 2025 at 07:35:57PM +1000, James Calligeros wrote: > This schema was still in plaintext form. Convert to YAML format. > > Signed-off-by: James Calligeros > --- > .../bindings/sound/tdm-slot.txt | 29 --------------- > .../bindings/sound/tdm-slot.yaml | 49 +++++++++++++++++++++++++ > 2 files changed, 49 insertions(+), 29 deletions(-) > > diff --git a/Documentation/devicetree/bindings/sound/tdm-slot.txt b/Documentation/devicetree/bindings/sound/tdm-slot.txt > deleted file mode 100644 > index 4bb513ae62fc..000000000000 > --- a/Documentation/devicetree/bindings/sound/tdm-slot.txt > +++ /dev/null > @@ -1,29 +0,0 @@ > -TDM slot: > - > -This specifies audio DAI's TDM slot. > - > -TDM slot properties: > -dai-tdm-slot-num : Number of slots in use. > -dai-tdm-slot-width : Width in bits for each slot. > -dai-tdm-slot-tx-mask : Transmit direction slot mask, optional > -dai-tdm-slot-rx-mask : Receive direction slot mask, optional > - > -For instance: > - dai-tdm-slot-num = <2>; > - dai-tdm-slot-width = <8>; > - dai-tdm-slot-tx-mask = <0 1>; > - dai-tdm-slot-rx-mask = <1 0>; > - > -And for each specified driver, there could be one .of_xlate_tdm_slot_mask() > -to specify an explicit mapping of the channels and the slots. If it's absent > -the default snd_soc_of_xlate_tdm_slot_mask() will be used to generating the > -tx and rx masks. > - > -For snd_soc_of_xlate_tdm_slot_mask(), the tx and rx masks will use a 1 bit > -for an active slot as default, and the default active bits are at the LSB of > -the masks. > - > -The explicit masks are given as array of integers, where the first > -number presents bit-0 (LSB), second presents bit-1, etc. Any non zero > -number is considered 1 and 0 is 0. snd_soc_of_xlate_tdm_slot_mask() > -does not do anything, if either mask is set non zero value. > diff --git a/Documentation/devicetree/bindings/sound/tdm-slot.yaml b/Documentation/devicetree/bindings/sound/tdm-slot.yaml > new file mode 100644 > index 000000000000..5bc46048d689 > --- /dev/null > +++ b/Documentation/devicetree/bindings/sound/tdm-slot.yaml > @@ -0,0 +1,49 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/sound/tdm-slot.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Time Division Multiplexing (TDM) Slot Parameters > + > +maintainers: > + - Liam Girdwood > + > +select: false > + > +$defs: > + dai-tdm-slot-num: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: Number of slots in use > + > + dai-tdm-slot-width: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: Width, in bits, of each slot > + > + dai-tdm-slot-tx-mask: > + $ref: /schemas/types.yaml#/definitions/uint32-array > + description: Transmit direction slot mask. Optional. Drivers may specify an > + .xlate_tdm_slot_mask() to generate a slot mask dynamically. If neither > + this property nor a driver-specific function are specified, the default > + snd_soc_xlate_tdm_slot_mask() function will be used to generate a mask. > + The first element of the array is slot 0 (LSB). Any nonzero value will be > + treated as 1. > + > + dai-tdm-slot-rx-mask: > + $ref: /schemas/types.yaml#/definitions/uint32-array > + description: Receive direction slot mask. Optional. Identical to TX mask. Just move each of these to the properties below as they are only used once. > + > +properties: > + dai-tdm-slot-num: > + $ref: "#/$defs/dai-tdm-slot-num" > + > + dai-tdm-slot-width: > + $ref: "#/$defs/dai-tdm-slot-width" > + > + dai-tdm-slot-tx-mask: > + $ref: "#/$defs/dai-tdm-slot-tx-mask" > + > + dai-tdm-slot-rx-mask: > + $ref: "#/$defs/dai-tdm-slot-rx-mask" > + > +additionalProperties: true > > -- > 2.52.0 >