From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj2-f13.google.com (mail-pj2-f13.google.com [74.125.227.141]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5BA9A3CDBAA for ; Sun, 20 Sep 2026 04:56:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.227.141 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789880175; cv=none; b=gXZ81FjME3yZo7hcVi07CiXkhbqZcF+8IdVPf8GYD3Air086TG8du70stsTeXjevMM1JbHCs5MZIDXC5FgvW+OYQ2AQzt5GwDrMHNmIwwGsDhEmehn1Dp8efYTdcDJkIvmhg3idgJeqtiHU3CryopLC044+/WR14YgKdyoLVcek= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789880175; c=relaxed/simple; bh=N7Gm9GhSadDaVeGyGSMSt56iAjPKqX+nSRnxDMmatR8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=LBLY1zNMuf+ggqmuYR1/VrEseyapjkGY0vJcfs/91rEreg/pDrzOPDIpiqR0aoAGY7ahhqT0sXiTIyvAjOn1H38bSv9O4vKWxeuEg6H2i0NZSBaQuFMc22b/9hQWeYZ1zLH+bG0et5GrSZO6GEcpFKTHWkFyiCvSQYMfk1vFo4w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ksGKjXiC; arc=none smtp.client-ip=74.125.227.141 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ksGKjXiC" Received: by mail-pj2-f13.google.com with SMTP id d9443c01a7336-2dd77300825so20378495ad.1 for ; Sat, 19 Sep 2026 21:56:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789880174; x=1790484974; darn=lists.linux.dev; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Z4y87oy6OKAiqnu/jIL3XduDUN3BGcMssQM5AWBSQLw=; b=ksGKjXiCFIIvho4K+i87hagrp3bO9irvEhiKlRl5MctXighmNbpa2sjCNsL2YQlPiD nwzuZOdfgDaACjGfM4PQILzKnoxU3loUZaZK5bKsmcLtUqOvyoiEuz87W//UbTso7NPU 9ThVrWBeWedKue3sx830CJU0Fu5Dr7PTlLHvo2zSe1PgZvxmtdnq3MypLIAAzoGQERKI wx5qmZapD67KEfr4ze1pOCZZgTgPKvgMQldkRBlWlXZnX39fx8m0s2zruw/hrwoj1Zqc RRr/L4FxjGJ4awsFf4Tcij8rzSQsQ9yitl+GDs8QMNH3XADEKLjrsCxG2SYt7G1ZQJj7 lMOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789880174; x=1790484974; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=Z4y87oy6OKAiqnu/jIL3XduDUN3BGcMssQM5AWBSQLw=; b=dTyHaJCoq5K1JRqzdeOUacsrdh4b0TrV3iWMsO4jJL3KS9kEcvNA2kCj+TzKJ1NfqP EaQgR0kXC8iX20eHnnPSlffDVot7K0JRzgnYAlxG7S2GRSNavoRMU3kUffSpKOHqOkMy yAlRbE8m3H6dJXwPbLCjO6uwRIm7rXKQh7zbuKYZpjPhUNdlwFIzqlxKgVaIMU3JbhpT XIVT9+Mdbg0Nl3aIhVpS/oqIaIL9Jgv8eyPKqnA8pC0Ec5rA4ZYV90VtuLhceqX/l3QQ PRrATP5AlCaF61bRike+e/Iag0aFYicbmibXO9hxLtKhHH1DcM1+eIvdcrMEY71+RMIh H9TQ== X-Gm-Message-State: AFuF++lNCbnwsZqRQrama2v1Mod5DeVCm8+9L/eFbXdwv2UE5fH2bfXH cyrd3A3p003odEaLUVC2imCOVgJ6ywTntfoIHuLV1ww90jRCalM/vR/M X-Gm-Gg: AYBFou1CRmIQW2dCDImVpogMQ52QJFevaELXlfuXB+hQybls2ft0KWyWF2w3QgWJAgd QKx3c8FkQeU76SSm5IxWsIRNvTiHtsCtd/yweTtBTlV5oceo33eU2oTDNfKxxg4lyof5AaUOJea K7MP+RILWMd7ocf2po6sqHfv/2C9FZPcP3nAxYqD+AtVHw1sCKcCwGZGgkZuNHZpa6Y5a9mYMdv 5efYEBb3LRA7w3vcDMoMIfHPesn0UCdUp265ZB88dupxQSujMBuySeR8HjY5zvZPIuvGMVF/EMF Yz34P5n1l0Tj5uQO3Nj1ZjzDsL3LHAudbX5e2fPsKD0RAARBdw5sHjysLJJf5QrKc5MAj4g5noX fgEeFobi+7B6710kMpU1TPcynZ4ef0Lgw/d1BeTVAjd0Vd6StAXIQGozc5pY6xRWko+FqY8qvF0 uxLYhl+VAbwLUJL2hdDk7nNOMIxUVpizuDIriLnPNZ7wfXv38jYEWE2HpXLtBl+ZCRt6qG/aPWt ivVu1qYJJsI17ghMPMqYaq4SWMRj9Qm9Z7s6KdSVCftjO+8qWRIgRsJ5+d8vljDbghRytSkgezz a3YeEQepNMbncuDYkuTJZe1hg5JNemt7LPlrxDxyZgBlF84= X-Received: by 2002:a17:903:b48:b0:2c9:bf82:dd11 with SMTP id d9443c01a7336-2ddb1adc353mr126021925ad.7.1789880173735; Sat, 19 Sep 2026 21:56:13 -0700 (PDT) Received: from [192.168.2.3] ([2403:581e:d87e:0:fc2d:ed31:e80e:412d]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ddc17d712dsm16026765ad.64.2026.09.19.21.56.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 19 Sep 2026 21:56:13 -0700 (PDT) From: James Calligeros Date: Sun, 20 Sep 2026 14:53:46 +1000 Subject: [PATCH 07/28] ALSA: Support nonatomic dmaengine PCMs Precedence: bulk X-Mailing-List: asahi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Message-Id: <20260920-macaudio-v1-7-741cc20a74e5@gmail.com> References: <20260920-macaudio-v1-0-741cc20a74e5@gmail.com> In-Reply-To: <20260920-macaudio-v1-0-741cc20a74e5@gmail.com> To: =?utf-8?q?Martin_Povi=C5=A1er?= , Liam Girdwood , Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Sven Peter , Janne Grunau , Neal Gompa , David Rhodes , Richard Fitzgerald , Jaroslav Kysela , Takashi Iwai , Ulf Hansson , Amit Kucheria , "Rafael J. Wysocki" , Lars-Peter Clausen , Vinod Koul , Matthias Brugger , AngeloGioacchino Del Regno , Shenghao Ding , Kevin Lu , Baojun Xu , Sen Wang , James Calligeros , James Schulman Cc: asahi@lists.linux.dev, linux-sound@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, patches@opensource.cirrus.com, Takashi Iwai , linux-mediatek@lists.infradead.org X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2677; i=jcalligeros99@gmail.com; h=from:subject:message-id; bh=KObS9Pt9I+T74LqcNTQHQ5cFB2c2q8qsj/Np1ljqwI0=; b=owGbwMvMwCV2xczoYuD3ygTG02pJDFnr0xU2+4Xv/r+xROS6dVFDzcSiOyfWXf7+o3x2v8XN+ f7e1oJ/OyayMIhxMViKKbJsaBLymG3EdrNfpHIvzBxWJpAh0iINDEDAwsCXm5hXaqRjpGeqbahn aKRjrGPEwMUpAFP9+xXDX8GZ9xRU9+7bXXMt7eK5Zew5L14t2sB48Drv779sq+Sd1d8xMkxZv9d N4ur99eJhaqns17xjBA3fHwku4TzRxB7rpBbQwwsA X-Developer-Key: i=jcalligeros99@gmail.com; a=openpgp; fpr=B08212489B3206D98F1479BDD43632D151F77960 From: Martin Povišer Add support for nonatomic dmaengine PCMs. Signed-off-by: Martin Povišer Signed-off-by: James Calligeros --- sound/core/pcm_dmaengine.c | 32 ++++++++++++++++++++++++- 1 file changed, 31 insertions(+), 1 deletion(-) diff --git a/sound/core/pcm_dmaengine.c b/sound/core/pcm_dmaengine.c index e59b561b849d..839ff2711f5e 100644 --- a/sound/core/pcm_dmaengine.c +++ b/sound/core/pcm_dmaengine.c @@ -22,6 +22,8 @@ struct dmaengine_pcm_runtime_data { struct dma_chan *dma_chan; dma_cookie_t cookie; + struct work_struct complete_wq; /* for nonatomic PCM */ + struct snd_pcm_substream *substream; unsigned int pos; }; @@ -147,6 +149,24 @@ static void dmaengine_pcm_dma_complete(void *arg) snd_pcm_period_elapsed(substream); } +static void dmaengine_pcm_dma_complete_nonatomic(struct work_struct *wq) +{ + struct dmaengine_pcm_runtime_data *prtd = container_of(wq, + struct dmaengine_pcm_runtime_data, + complete_wq); + struct snd_pcm_substream *substream = prtd->substream; + + dmaengine_pcm_dma_complete(substream); +} + +static void dmaengine_pcm_dma_complete_nonatomic_callback(void *arg) +{ + struct snd_pcm_substream *substream = arg; + struct dmaengine_pcm_runtime_data *prtd = substream_to_prtd(substream); + + schedule_work(&prtd->complete_wq); +} + static int dmaengine_pcm_prepare_and_submit(struct snd_pcm_substream *substream) { struct dmaengine_pcm_runtime_data *prtd = substream_to_prtd(substream); @@ -169,7 +189,11 @@ static int dmaengine_pcm_prepare_and_submit(struct snd_pcm_substream *substream) if (!desc) return -ENOMEM; - desc->callback = dmaengine_pcm_dma_complete; + if (substream->pcm->nonatomic) + desc->callback = dmaengine_pcm_dma_complete_nonatomic_callback; + else + desc->callback = dmaengine_pcm_dma_complete; + desc->callback_param = substream; prtd->cookie = dmaengine_submit(desc); @@ -322,6 +346,10 @@ int snd_dmaengine_pcm_open(struct snd_pcm_substream *substream, if (!prtd) return -ENOMEM; + if (substream->pcm->nonatomic) + INIT_WORK(&prtd->complete_wq, dmaengine_pcm_dma_complete_nonatomic); + + prtd->substream = substream; prtd->dma_chan = chan; substream->runtime->private_data = prtd; @@ -361,6 +389,8 @@ static void __snd_dmaengine_pcm_close(struct snd_pcm_substream *substream, */ dmaengine_terminate_async(prtd->dma_chan); dmaengine_synchronize(prtd->dma_chan); + if (substream->pcm->nonatomic) + flush_work(&prtd->complete_wq); if (release_channel) dma_release_channel(prtd->dma_chan); kfree(prtd); -- 2.55.0