From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f178.google.com (mail-dy1-f178.google.com [74.125.82.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0417049364C for ; Thu, 8 Oct 2026 10:39:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791455947; cv=none; b=QuezjkcbmMYc4V8u77wVTZmYZIP7FoZAkJoGxzbGh6cwcDVAQbjIczBAf7eeX6b2Nkz4UJGQY7TEZZoffce1MaPbrjX2Bwg5LQwWvj9O53/jhSycId+m1iRpbxfjBOy+JmzS37AzTu2u/OSRFcHphFhQ1SSsgNTb4LIwRNm/LOI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791455947; c=relaxed/simple; bh=dtrga2aJHDAstvyuSs6qpZWc6QvyFtEPlzZuunhkMfg=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=BmtNtADdxpJItp0s0hebHXQ2lFBIrmLl/C2S7NcTj9Cz2S0zlLZRToMQfnIqUT+U44eMpHZjKRZfGAjT0UPwW8M9b0E/oGKdV21PwJLkSIsfj1fdPw2BtqLmNqCVEqgCZb+NqbnXL/DTgU9YnEo2hlKyBp7szfiUD8Rt88wPbUY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ZLntyze3; arc=none smtp.client-ip=74.125.82.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZLntyze3" Received: by mail-dy1-f178.google.com with SMTP id 5a478bee46e88-33e6279a1d7so1898602eec.1 for ; Thu, 08 Oct 2026 03:39:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1791455945; x=1792060745; darn=lists.linux.dev; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=2hpUwEsGMPkIBbYBiNYjLbx5Pg/A2Eh/bQSXX+ThuQY=; b=ZLntyze3CS5abkkVRTWbX+bw9NmtKUB32XZoOAE6QCO0VD7ec+zsypA79hEfG+qSbu bB5TiPXt8QEtlD9wZ6c6JHIgvukbaZLuGMtGo7Dc8KOMxw4ljhvfJVpw0XtLQ8bW5N9Y s/H6TSYdXMxkuVCPaoTtS/Q3DcqMtO6R/6KIxW4qGOhkSdwdyqHDt53Cu+IJftJ3T7fr w/MLunrr86up9JWdHxs2n8xgrtNBqlue+J80b61K3Rp5NfzqFtnD44Rq8vI5buulWLUo nlyoS/Pn0jROHVk4UQcR3nBE8pWd1pqfViC2RhBdRA7rH93Z0eWc1L1xQJDciXjDVLhb hLHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791455945; x=1792060745; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=2hpUwEsGMPkIBbYBiNYjLbx5Pg/A2Eh/bQSXX+ThuQY=; b=Kz0reAcW33EMsr4JUj+7bXKXmHBtEnF6YLVWSCKsFlmcZsQgBunhQ0xRAxzIUkojqo SwWfSwuMqEHK6HVX24eJxN3dI2F0u77ZqvRh15/yWzMLh872IsLOC55U1UcBj8ck799V SBKUTXezM34c8G+qXaWTCjibzFTq7zycCpXDdJynjiyzzB7FFtWLNm+SxLAuGhKTWdNI mdJ5dnIi/twxJ7CdeQFs0+VIkmu+ytuGiXmP9nnKc9sC0UDU4ODcRl+Z2+IXawqPORa5 2U5gUZuFri09b3W8RVB9YF3GcHvl3IKyWibaJf850N52GHMbgmebSNwGCbHB1y9D8hAx 1/oQ== X-Forwarded-Encrypted: i=1; AKwUvBxVWdjhybyF/S9aBmJNRHdkPrzaRt/Q0fxtSgjKK+1M8ffrCAMns7DrW06xPVCLmm5RGxrIIg==@lists.linux.dev X-Gm-Message-State: AFuF++nzueAwmsE9z5SPRk3MhlLJHLfsZOujI0NoEcecdd/ojRNfM/Fj n5Tg7y+Fl3MJWe4eBBUo8TgPd9mL3PlwYU7fqys8fF35CYDlc02Y6VzX X-Gm-Gg: AYBFou3vwszZc5+mZddvus3DhFCktQJS0cC5MUNAgtWCGQUDRb8IZfq7BSk7c+v4Jmr p+fs8pj0CS2E6UI0QMpkPC1L3jCL463gwo3p2qdYxSLJRKhpa7BrFdwfkHSVsnNicjhNfUE5NTl DJ138FfllvpXxx9VaUAo/Vy4fWNjJYVnGZSqnz/rCvTPTH9Bifs8QtoRUNTX8ZxIzg+Qlp7xT63 sf8DETiin5o5yKFMRRXAnoG0AD8xC8nKJ3CXuh25ZnEsuV45pY6LxaqWueWoP6RK94Q5NTw/wSb TTPKTmUg6iX8FwglYoTohxj8acSbXLn6yYc7MOsSyjsKy42Ft3MY1BLh0ONooG5oz0SZFH9+LWh Yum+iIOuBa1ngpJYTCA1VyiTTcYnqRs1t8gtGY6AdDiTUysDOiGwQjmkCwEu6PhDtF7mJiRJ/rp lo8vnMfLaKqX6QeWANn47oJGIUODvnrABHzRcdz1LVpHfwfVym6KPsuwBVSCI+r5jhC3Rn1hmbh vjPESluUnZoZHOfr4BNZeRqZrDo6GQ6V5vTXKCupGzv1qfb12K7Xg59j6eqNGfkvrZP8GYXs+sJ bDqOdfdRd+akUQ== X-Received: by 2002:a05:693c:8819:10b0:352:2e15:49a9 with SMTP id 5a478bee46e88-3522e154b4amr965099eec.33.1791455944704; Thu, 08 Oct 2026 03:39:04 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3517810b895sm7496369eec.17.2026.10.08.03.38.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Oct 2026 03:39:03 -0700 (PDT) From: phucduc.bui@gmail.com To: Vijendar Mukunda , Venkata Prasad Potturu , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , povik+lin@cutebit.org, Claudiu Beznea , Andrei Simion , Nicolas Ferre , Alexandre Belloni , David Rhodes , Richard Fitzgerald , Shengjiu Wang , Xiubo Li , Fabio Estevam , Nicolin Chen , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Cezary Rojewski , Peter Ujfalusi , Bard Liao , Kai Vehmanen , Pierre-Louis Bossart , Kuninori Morimoto , Geert Uytterhoeven , Magnus Damm , Biju Das , Lad Prabhakar , Heiko Stuebner Cc: Kees Cook , Syed Saba Kareem , wangdicheng , Chris Bainbridge , Linus Walleij , Charles Keepax , Neo Chang , Krzysztof Kozlowski , u.kleine-koenig@baylibre.com, Pengpeng Hou , Cristian Ciocaltea , Hemanth Selam , Md Shofiqul Islam , Bjorn Helgaas , Zain Aboobacker , Sang-Heon Jeon , Ajit Kumar Pandey , Ravulapati Vishnu vardhan rao , Bo Shen , Vinod Koul , linux-sound@vger.kernel.org, asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, patches@opensource.cirrus.com, linuxppc-dev@lists.ozlabs.org, imx@lists.linux.dev, linux-rockchip@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH 00/24] ASoC: Fix constraint return value handling Date: Thu, 8 Oct 2026 17:38:07 +0700 Message-ID: <20261008103831.542533-1-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: asahi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: bui duc phuc Hi all, snd_pcm_hw_constraint_minmax() and snd_pcm_hw_constraint_integer() may return positive values on success. However, ASoC only marks the DAI, link, or component as started or opened when the corresponding callback returns 0. This series fixes affected ASoC drivers to return 0 on success and properly handle rollback paths. Found by manual code inspection. Compile-tested only. Best regards, Phuc bui duc phuc (24): ASoC: amd: acp: Fix .close() being skipped on rollback ASoC: amd: ps: Fix acp63_pdm_dma_close() being skipped on rollback ASoC: amd: ps: Fix acp63_sdw_dma_close() being skipped on rollback ASoC: amd: raven: Fix acp3x_dma_close() being skipped on rollback ASoC: amd: renoir: Fix acp_pdm_dma_close() being skipped on rollback ASoC: amd: vangogh: Fix acp5x_dma_close() being skipped on rollback ASoC: amd: yc: Fix acp6x_pdm_dma_close() being skipped on rollback ASoC: apple: mca: Ensure the DAI is marked as started on success ASoC: atmel: atmel-pcm-pdc: Fix atmel_pcm_close() being skipped on rollback ASoC: codecs: cs42l42: Ensure the DAI is marked as started on success ASoC: codecs: nau8325: Ensure the DAI is marked as started on success ASoC: codecs: nau8540: Ensure the DAI is marked as started on success ASoC: codecs: nau8821: Ensure the DAI is marked as started on success ASoC: codecs: nau8824: Ensure the DAI is marked as started on success ASoC: codecs: nau8825: Ensure the DAI is marked as started on success ASoC: codecs: wm8580: Ensure the DAI is marked as started on success ASoC: codecs: wm8782: Ensure the DAI is marked as started on success ASoC: imx-pcm-rpmsg: Fix imx_rpmsg_pcm_close() being skipped on rollback ASoC: intel: atom: Fix .shutdown() being skipped on rollback ASoC: renesas: fsi: Ensure the component is marked as opened on success ASoC: renesas: msiof: Fix msiof_close() being skipped on rollback ASoC: renesas: rz-ssi: Ensure the component is marked as opened on success ASoC: rockchip: rk3399_gru_sound: Mark the link as started on success ASoC: rockchip: rockchip_max98090: Mark the link as started on success sound/soc/amd/acp/acp-platform.c | 2 +- sound/soc/amd/ps/ps-pdm-dma.c | 2 +- sound/soc/amd/ps/ps-sdw-dma.c | 2 +- sound/soc/amd/raven/acp3x-pcm-dma.c | 2 +- sound/soc/amd/renoir/acp3x-pdm-dma.c | 2 +- sound/soc/amd/vangogh/acp5x-pcm-dma.c | 2 +- sound/soc/amd/yc/acp6x-pdm-dma.c | 2 +- sound/soc/apple/mca.c | 11 ++++++++--- sound/soc/atmel/atmel-pcm-pdc.c | 2 ++ sound/soc/codecs/cs42l42.c | 11 ++++++++--- sound/soc/codecs/nau8325.c | 11 ++++++++--- sound/soc/codecs/nau8540.c | 11 ++++++++--- sound/soc/codecs/nau8821.c | 11 ++++++++--- sound/soc/codecs/nau8824.c | 11 ++++++++--- sound/soc/codecs/nau8825.c | 11 ++++++++--- sound/soc/codecs/wm8580.c | 10 ++++++++-- sound/soc/codecs/wm8782.c | 7 ++++++- sound/soc/fsl/imx-pcm-rpmsg.c | 2 +- sound/soc/intel/atom/sst-mfld-platform-pcm.c | 2 +- sound/soc/renesas/fsi.c | 6 ++++-- sound/soc/renesas/rcar/msiof.c | 6 ++++-- sound/soc/renesas/rz-ssi.c | 18 +++++++++++++++--- sound/soc/rockchip/rk3399_gru_sound.c | 9 +++++++-- sound/soc/rockchip/rockchip_max98090.c | 10 ++++++++-- 24 files changed, 119 insertions(+), 44 deletions(-) -- 2.43.0