From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f169.google.com (mail-dy1-f169.google.com [74.125.82.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1E3B2496D53 for ; Thu, 8 Oct 2026 10:42:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791456126; cv=none; b=UVV/ffcY5f4150iQKa7D9NtfpvYapsh6jtJVmHuc4rE6Y+c/QfyeW8NTWugjApKOEfQWCyPaN1aV3kt29v+d4rAxzeBdo9kmd6rzAXT0x23Nkw3pXqAGRgtwklJpp6NlgdwkkGtuB5GhPOIKnoI0AsZJPieDNOSY7S89zIy3fhA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791456126; c=relaxed/simple; bh=TY5nLnS6S9uHv32PdSTxcUN0ZHO58ghUjGE/8k1kBwE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=he/cJN0ml2SczMW2Ipfj4vpGQ6iiw8rczptxLseI7HL6LqQmkKHqWgLSeR2gUdZeIZ2NNx+YIvgS+Pv9eUjzASqN9KYaRvRM0N+bYRSsYFsMaq9zOjAqu8+LYH7B4QcfbCiTU3TnDPq1SzA/qaZCTmR452IRQk/vctQcyE1LbA0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=pUgF7/63; arc=none smtp.client-ip=74.125.82.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="pUgF7/63" Received: by mail-dy1-f169.google.com with SMTP id 5a478bee46e88-30b6dad2382so6460093eec.0 for ; Thu, 08 Oct 2026 03:42:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1791456124; x=1792060924; darn=lists.linux.dev; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=+TNcAidsp1/YnKu0SMvrWqoUUNkBNLGyi1C+4A88wdo=; b=pUgF7/63zR0oGocG1+aATfwJ2dsDz6yJYTiVgs6Ls8R06pcHnCoFzaGjuiLrUjbTYj vT3pUC9e5jZUiZaut04WB04bsRhJpytoNJ39TKtiG+Vf/8cJI0TU/mHHhD1AHMxy2O54 HcnUH1DMUtSHc9il7oRArNGEGMhA4grtyb9PquVnGj2+U1NqsjyBYsdyI8YuJDIsIFoK T5BkM37XEVbx+9xvR+eyIVbjVE5qagoHajh5aI1vfup2vudpvZvOQebmz7hJJSRmHNvI 4lMvol3mTV10Yur2RkSEeImaERZXEt2qe9GAv9/fHxkHtLeJTU5fbRPDvrqqZr57Cnqp M+EQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791456124; x=1792060924; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=+TNcAidsp1/YnKu0SMvrWqoUUNkBNLGyi1C+4A88wdo=; b=M2oCqan/4b6myQnK65xw17qSLPjtNf//0VsBmQRMgnD2G0Ee7zbHS6NSQtNCrGSJsh uiDjU6LAwOzPEqfSUocI7GY06hGle8xxVEK11bz7DQ54pcSWw9XdJkon5iq6kn/YVk0K MEHCED4kUqsSD9rrqaCkSgjoG63PJYUHuTXi4Mrmoa/kTBqLtBatfStgxapQV2f9UKtm 26w43Rpj/pCoR2bjNMGlRtQLezor4hYdllok3NFQe1OmmWQqIm9yBv6xWfS7dHNxA0Ho smFcCVQvaw1InIlNZvHIp2jiuts1H1XhmnKCa+W26/7psu40TlilKB/xR1H+IcJU8fds gZoA== X-Forwarded-Encrypted: i=1; AKwUvBx+tcQ1Rhd1seE90h73O5/befnrlkW0gHtp8tQ7kcMCxfas3bo6mCKk8hleJIzzOxSppN6uaQ==@lists.linux.dev X-Gm-Message-State: AFq9FYLKCPN+4gydN9kBXiSesLyVb2Y8eEIrwgrzjte8O+T5I9KSEeRQ KlAGszDMRPef+QniQSGoNQGIr2JxQwUY8fD6dRLDn4FdQAVzsZgn/h5D X-Gm-Gg: AYBFou1KfeiMgKjpg+rIEylJS7cAEHXLN/HSjhIPikMX5LrFm2p+iZ7xdHuJlox1H6T MblmlN55MZ28/5GNyBFSjnS3lPFjrD/TMZPpR80ktawglw//7CapPeIV3og8R0kWHR7dyFN4TdN hQs1tcCwwsMyr+H+AnxQ8kcoyNAuf43CRK3w5ldqGplvxNYCKRZycqrHAV5AUNyDfRmlCBdZvcf 9ohi6i7wtoxKnQl2r4y1FUSd7Pva+d1fu4qJOUNa+qdYLrEGzFHFyhRYrOu4gliRmnLDfQsZbwO uotW4borYN2k+Lbsci3lY3B5ZeDY9CGEAaBYMNy6FjLTz1NlMVPx4vgwOK6yxVbPV8rtK82CqcZ 813LW9Bk7iQCMIFwpKWXHrqj3HV1sVapHHmrZpRRIkXmlSy1WHDKbxYv0fBSxvpG7rSkU7dAJ2l XaYxT58nndqrPJsXCoaY+UdBAsnsNssDcxwggCRypgQPAvIfD0SvrSX970zL4PDTZh+LL1fbQT1 4RzMczuzWiwltfsfUn4qCaB/S7EWGFnD8o6NndR1nFXSsiS2cQvXMm8ig0JrPlurmO4FvxYUUTK GapaVjPr/ri4zA== X-Received: by 2002:a05:7301:7a0a:b0:351:1230:5087 with SMTP id 5a478bee46e88-3515dd3322amr6214040eec.12.1791456124010; Thu, 08 Oct 2026 03:42:04 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3517810b895sm7496369eec.17.2026.10.08.03.41.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Oct 2026 03:42:03 -0700 (PDT) From: phucduc.bui@gmail.com To: Vijendar Mukunda , Venkata Prasad Potturu , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , povik+lin@cutebit.org, Claudiu Beznea , Andrei Simion , Nicolas Ferre , Alexandre Belloni , David Rhodes , Richard Fitzgerald , Shengjiu Wang , Xiubo Li , Fabio Estevam , Nicolin Chen , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Cezary Rojewski , Peter Ujfalusi , Bard Liao , Kai Vehmanen , Pierre-Louis Bossart , Kuninori Morimoto , Geert Uytterhoeven , Magnus Damm , Biju Das , Lad Prabhakar , Heiko Stuebner Cc: Kees Cook , Syed Saba Kareem , wangdicheng , Chris Bainbridge , Linus Walleij , Charles Keepax , Neo Chang , Krzysztof Kozlowski , u.kleine-koenig@baylibre.com, Pengpeng Hou , Cristian Ciocaltea , Hemanth Selam , Md Shofiqul Islam , Bjorn Helgaas , Zain Aboobacker , Sang-Heon Jeon , Ajit Kumar Pandey , Ravulapati Vishnu vardhan rao , Bo Shen , Vinod Koul , linux-sound@vger.kernel.org, asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, patches@opensource.cirrus.com, linuxppc-dev@lists.ozlabs.org, imx@lists.linux.dev, linux-rockchip@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH 12/24] ASoC: codecs: nau8540: Ensure the DAI is marked as started on success Date: Thu, 8 Oct 2026 17:38:19 +0700 Message-ID: <20261008103831.542533-13-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20261008103831.542533-1-phucduc.bui@gmail.com> References: <20261008103831.542533-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: asahi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: bui duc phuc snd_pcm_hw_constraint_minmax() may return 1, which is then returned from nau8540_dai_startup(). ASoC only marks the DAI as started when .startup() returns 0. This currently has no functional impact, as nau8540_dai_ops has no .shutdown() callback. Still, return 0 explicitly on success to match what ASoC expects and ensure the DAI is correctly marked as started. Signed-off-by: bui duc phuc --- sound/soc/codecs/nau8540.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/sound/soc/codecs/nau8540.c b/sound/soc/codecs/nau8540.c index d4211a76b096..9484388ab262 100644 --- a/sound/soc/codecs/nau8540.c +++ b/sound/soc/codecs/nau8540.c @@ -419,14 +419,19 @@ static int nau8540_dai_startup(struct snd_pcm_substream *substream, struct snd_soc_component *component = dai->component; struct nau8540 *nau8540 = snd_soc_component_get_drvdata(component); const struct nau8540_osr_attr *osr; + int ret; osr = nau8540_get_osr(nau8540); if (!osr || !osr->osr) return -EINVAL; - return snd_pcm_hw_constraint_minmax(substream->runtime, - SNDRV_PCM_HW_PARAM_RATE, - 0, CLK_ADC_MAX / osr->osr); + ret = snd_pcm_hw_constraint_minmax(substream->runtime, + SNDRV_PCM_HW_PARAM_RATE, + 0, CLK_ADC_MAX / osr->osr); + if (ret < 0) + return ret; + + return 0; } static int nau8540_hw_params(struct snd_pcm_substream *substream, -- 2.43.0