From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f182.google.com (mail-dy1-f182.google.com [74.125.82.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 84F69496D2A for ; Thu, 8 Oct 2026 10:42:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791456156; cv=none; b=BnKgeV0SyWvBU+wXmKlKuP6vrTKfZQMIYysRwc58UNwfkrmPz5jJjcwtWdaaxaEFKk6n2os83JFE5icroT9PxWLwAPDFoIp99CnlaOZIJWwTfnhpHvZqfquE1MjAZzariWqyq9XqWu8nzzB+dLPLFDSzkHe46AokIhatFPUSSlI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791456156; c=relaxed/simple; bh=jz760ztqgga0RO/+vAvDuVyLPPNpmX23pq1M+Bivpxo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=fU5efp+hEe0e3JJUO366XpX+hwgNaplDkTPgoWebk8lmvGb8zF/V8gt8d6+wFYzoU/0crpu+JbB9rqihVgbatpYUyTk2f7oQlDMC0kL5Ih2p+0UUtNeiN4+D9mHtG9DcfGN7KRKuYSuG7WwYkAs2H3X9xrHTvkcxnAlcCaw2YB8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Nu+eUiAB; arc=none smtp.client-ip=74.125.82.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Nu+eUiAB" Received: by mail-dy1-f182.google.com with SMTP id 5a478bee46e88-3282db206d3so796561eec.0 for ; Thu, 08 Oct 2026 03:42:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1791456155; x=1792060955; darn=lists.linux.dev; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Uc00trQPX7RuBM3kvjd0hrBbedJ5QhnOwvfpAMsSqmQ=; b=Nu+eUiAB2t82C4Xm7MklhKF9pY8m1kpG0dw+dF76eG88GRGqH1cNp2MasL0cNNLgzV Gr1aiZdxajWPHb4WKB7yg8mHWpVD7XT+4VhR81YQrU92tJRPZwiJcW4Adxs/RUD5RSOW cYsyV7Q4SoOtQ9z7oYAhCEg183D+RcL58j+gkia4w9b72UWa16igpvSOHiX/Iulef+2f c94XSrvIqDJJtvZDmh4Pi9F7tcg6bDaZ/duIch0XJn2de3S4LMGqQbwlXnt93z8W7bNM OpX5DhKIG19sAgQKK/eOLQzlvwmJh/YOEggc2bne0k9jMsa1RS3mJT07Vt4mUIAC+Hb6 i+gA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791456155; x=1792060955; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=Uc00trQPX7RuBM3kvjd0hrBbedJ5QhnOwvfpAMsSqmQ=; b=IUxeI8hvwiUWAag5ThYKgv7JdJ+ONxgDcoc9qgorWoc59XesFVqF++OXSPBbn9vy3d 5Lrp85D3UFdp8NOP7x0DzaM1g2pxo6cD1Ygn8nAbPIQnlo0gVynrBVukGnlpUYhc/Qmv gXtLkerx95IKFFBYBp2AWZ3cUo5z6vJ+XTXRNAhSDBY3XCWPFxefAM+2I/kKBNREfumx Rhm+XCSylnOS+SGpvXUAPTtnEYVtIoIOKOijUQsjyc/lI2mWGhbLEGRF/YWxtnr4uHDV dV9Mhq9E30xhnAmA14+bxiAnOid6EnzuXFegpQlxWrarP+95K1HyGpd1DkwV4PA293ux 56Tg== X-Forwarded-Encrypted: i=1; AKwUvBy0BhGANu7YtPHlLvoUL2w4llovrPirqpx1V/4bEqyCIfEBNnRwmNfU5Fr5MmQRVxtgdnfU0Q==@lists.linux.dev X-Gm-Message-State: AFuF++koCWmkTbIz50HgAJfJemFaTlmCPzl/27Kwz9OX215GpPS0VFCY qBWJnpiqw332PSVMIgc8+fLkwhS+fTKJcRsz4gv4NA+GjcH0bKQ3fkhI X-Gm-Gg: AYBFou2OuiKEmvzjJEHw3YeXFThUW0Aoo6nXTjpNg+sK8AlmwZyNkirlciVsJU76egW lll2ycKqgSr4dw7ke/QnqNDkRBMkQuB93rL+vj1Skp5LAccvDT/Gc9dgcnlfkrAwscfpvMK+Gxe u7Ytyqbk+QXfxvT8I6gxYSrYl9LNnAGPFNsl72q+vbI8GOvrUfzNTKCllnTpS3wyVKIFqT63K/+ 9eb+5Z8jz9+5Q28VJib0TqYhAO2SAkfPJeE6vGqfiuO7vAwAovMjPz/khrN7ZE448xxEGa+IIu2 ak8INDBd53IXa9L/gdiRRlXbejJFpdgXeWIldIcmZSQu65J3agZDcrK/uDIlmsLIIhhaNKgZa/Z imAHFigcfx3a9M421l/kaQqbVf3KqSFmVQmXjpt/Mt6vJ2ZHPaMDgg3d7L3zZEi4tC66C5RqGNp 5/IRTnPxQs10Od5X75RNuVdZYT/uvSP68EVFurNPr1joCgFl9sRjTNa5C/2vucgpufLEfaXBHVB R3vHBkp7Wi6T0cHZ62CBiTFolZvpZAuPL4kfeLa79fA1dzfWu9rbGcdGZKQ8RcdSQip6HdAz5Jp T95hFJEhL2+EiA== X-Received: by 2002:a05:7301:d194:b0:351:28eb:8cd8 with SMTP id 5a478bee46e88-3515ddee11cmr6279341eec.18.1791456154501; Thu, 08 Oct 2026 03:42:34 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3517810b895sm7496369eec.17.2026.10.08.03.42.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Oct 2026 03:42:33 -0700 (PDT) From: phucduc.bui@gmail.com To: Vijendar Mukunda , Venkata Prasad Potturu , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , povik+lin@cutebit.org, Claudiu Beznea , Andrei Simion , Nicolas Ferre , Alexandre Belloni , David Rhodes , Richard Fitzgerald , Shengjiu Wang , Xiubo Li , Fabio Estevam , Nicolin Chen , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Cezary Rojewski , Peter Ujfalusi , Bard Liao , Kai Vehmanen , Pierre-Louis Bossart , Kuninori Morimoto , Geert Uytterhoeven , Magnus Damm , Biju Das , Lad Prabhakar , Heiko Stuebner Cc: Kees Cook , Syed Saba Kareem , wangdicheng , Chris Bainbridge , Linus Walleij , Charles Keepax , Neo Chang , Krzysztof Kozlowski , u.kleine-koenig@baylibre.com, Pengpeng Hou , Cristian Ciocaltea , Hemanth Selam , Md Shofiqul Islam , Bjorn Helgaas , Zain Aboobacker , Sang-Heon Jeon , Ajit Kumar Pandey , Ravulapati Vishnu vardhan rao , Bo Shen , Vinod Koul , linux-sound@vger.kernel.org, asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, patches@opensource.cirrus.com, linuxppc-dev@lists.ozlabs.org, imx@lists.linux.dev, linux-rockchip@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH 14/24] ASoC: codecs: nau8824: Ensure the DAI is marked as started on success Date: Thu, 8 Oct 2026 17:38:21 +0700 Message-ID: <20261008103831.542533-15-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20261008103831.542533-1-phucduc.bui@gmail.com> References: <20261008103831.542533-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: asahi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: bui duc phuc snd_pcm_hw_constraint_minmax() may return 1, which is then returned from nau8824_dai_startup(). ASoC only marks the DAI as started when .startup() returns 0. This currently has no functional impact, as nau8824_dai_ops has no .shutdown() callback. Still, return 0 explicitly on success to match what ASoC expects and ensure the DAI is correctly marked as started. Signed-off-by: bui duc phuc --- sound/soc/codecs/nau8824.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/sound/soc/codecs/nau8824.c b/sound/soc/codecs/nau8824.c index 853eb9472af9..c89889aa420e 100644 --- a/sound/soc/codecs/nau8824.c +++ b/sound/soc/codecs/nau8824.c @@ -1061,14 +1061,19 @@ static int nau8824_dai_startup(struct snd_pcm_substream *substream, struct snd_soc_component *component = dai->component; struct nau8824 *nau8824 = snd_soc_component_get_drvdata(component); const struct nau8824_osr_attr *osr; + int ret; osr = nau8824_get_osr(nau8824, substream->stream); if (!osr || !osr->osr) return -EINVAL; - return snd_pcm_hw_constraint_minmax(substream->runtime, - SNDRV_PCM_HW_PARAM_RATE, - 0, CLK_DA_AD_MAX / osr->osr); + ret = snd_pcm_hw_constraint_minmax(substream->runtime, + SNDRV_PCM_HW_PARAM_RATE, + 0, CLK_DA_AD_MAX / osr->osr); + if (ret < 0) + return ret; + + return 0; } static int nau8824_hw_params(struct snd_pcm_substream *substream, -- 2.43.0