From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f177.google.com (mail-dy1-f177.google.com [74.125.82.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A24E63EE1F8 for ; Thu, 8 Oct 2026 10:44:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791456252; cv=none; b=nEd3kYBv8h02Es42/USkFhJTUSIuTpHmuHWyoJkfS4ks2wXnujsZn/Yl/fI+jMlySW4Wb7LIWhvQXMInnonmyVkAJ/w2MKqJr9djpe6C8ck/ZWhFVnnOlbvWklJgupryvUgUoBF331ZiZOhulJ0xfei0ocVwkWyafvvoGxdlbrI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791456252; c=relaxed/simple; bh=l1HC2BErZTeFg9PacGbdvzlNTd3R8UQWG+h9EUzSDPU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=UBb7E/eEB2t9BUtiIkVFcklfvr0UDI5aYgslJ88lacKZTS70CsHsKpnLXraYCr5U80jozCA2B/5IW/c5iZvpP+UvxBfldile356q6I8p1gngRU43BS9tUOLZaEZku8RsIGzRoBZEMBZ9qtZEeWChcT3DuiaYCsPt58lgvzPlvAA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=MhgwfNnN; arc=none smtp.client-ip=74.125.82.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="MhgwfNnN" Received: by mail-dy1-f177.google.com with SMTP id 5a478bee46e88-351767ef18cso1965170eec.1 for ; Thu, 08 Oct 2026 03:44:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1791456250; x=1792061050; darn=lists.linux.dev; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=uLXKgERfdgngku3yQUE+LcMSxD8yCQ+a/l+GKCCFjt4=; b=MhgwfNnN+pcQloLH3t2wAfdvMmZ+HfR7c1FOS21TfYg66M8RbfRLWzc8VeOi8tGXeF MoysF3poH6O/5DStmLtfDw6DDThuaFmO7YRVqisKKIxw61b7RoUZ/X3p+00jVArG4+s+ gy3Mf9bdpLkvZqQT3PYtrxML04FL/boUCKU0u9MKcbwtMpJBNjkmz4zsj/qMEyD5lmm2 xhKyAFbhgZsY+yluy16lxeKVTUHhgCOuZvHqlbXLXxQvG5fybU26NTDUIHzYS+5Jhwaz ZUXX+C/GEcekrAAJvTDrdQpvhvUAEIWocZVogElXOKOniStU4N6FCjnuVaoTMEf25MHR La/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791456250; x=1792061050; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=uLXKgERfdgngku3yQUE+LcMSxD8yCQ+a/l+GKCCFjt4=; b=cARoywo94wzUDAbmemOgn8vZWbSeHk9Ce5s4nSKc9+w2orlBb/ACrGYlTbMRCCMuPL 7V1PXurtbroYGDXwc/FHijOGmyrcK/7AYW9Q5FxcfX5CH2Q4at8Q722/cquoXhw1gDwc uXVMlcXDWZKlqmyEElbV0Ak24HGhSAdDsLgEZWgD/c7yhLR0mhLRGZ8n0yL1cNS6mG43 uhO4iFMPI/wawxxWlnP9muzPOHtCfIipABKieftkh6bP4xnl39QdumqN3olYWmVmeTpc gOJe7j8ZrYmUA0jLmy/nfn1E2UuoHGDGEwgzElaEOiL+/mSNPTSLK4eVVW+NbGr1AZah c3uw== X-Forwarded-Encrypted: i=1; AKwUvBzEYo5juo3a98Iypi6wxOeZAc//O0/7sZPzOl28+VR5kmEL1DmsoFCjCXNo5bq+/O96e/fStw==@lists.linux.dev X-Gm-Message-State: AFq9FYKRpSSVaDzdx+k/j/n0V8u9EDc698hOZXWuCo+WL7rzM4xcaOYJ fLN0lTQVYQwHLeEYmDUanAFPJXy05KuvFNYcKzBjsSTLyhtDxzA4H88p X-Gm-Gg: AYBFou2j0AbMmkCTS+RYGQnBJ4qYXYuqzx53IkIRoZyGDedCg+vmSKy5NMj2DkGboOI Z/jwmrjlp8I1kSgzTcXi22GB8wLLkGdBycR1QVM/2PCeJoljnyO8jxRoTaZPcvcpGos55Mqa2Zz 4JGxtRQTmwiXEbxO5kqi5dOK2BftO+yMtQjMuUpHbK1RZkBlXKd2x83OMpc9CmBBNx44TbtxSmQ pBFFoyOQS3Y4aElufAaGqczspEgBRjtiLdvtRPb5zJXiycF67cHXTh0EUqgnL12pi3ypS/NVOnE cWwYN+JVpuGPpArWOGmjUSczBJiR8jt0uoHBRm1JBT693HCvFZGqu+c6Jm1ea9ovkNUXbl81fiH UbdUpeUxEhKerCKnTVWZ115OgImPgT2X1t+5vaoGb8yDi+4F7jDoSZ4MP5RPhQeQcevWHVaBhmc aa8+oDyZTGdulCPiRvw27FdpbEf+jg/sLQTiH9CV/Yr6eEMOc+wCxXwc/dY+KaTJmVcCjUhmE8x AOSOwNgrQF7BzoBy5N7A3AzqkjGzDIuA6dKoMPIhy/yNsZ1i8Qy1tjrivQ/O5vmo5OM//vZYgpy 7/P0pAqBNjgHmw== X-Received: by 2002:a05:7300:d214:b0:352:2e10:10c3 with SMTP id 5a478bee46e88-3522e10401bmr948755eec.36.1791456249630; Thu, 08 Oct 2026 03:44:09 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3517810b895sm7496369eec.17.2026.10.08.03.43.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Oct 2026 03:44:09 -0700 (PDT) From: phucduc.bui@gmail.com To: Vijendar Mukunda , Venkata Prasad Potturu , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , povik+lin@cutebit.org, Claudiu Beznea , Andrei Simion , Nicolas Ferre , Alexandre Belloni , David Rhodes , Richard Fitzgerald , Shengjiu Wang , Xiubo Li , Fabio Estevam , Nicolin Chen , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Cezary Rojewski , Peter Ujfalusi , Bard Liao , Kai Vehmanen , Pierre-Louis Bossart , Kuninori Morimoto , Geert Uytterhoeven , Magnus Damm , Biju Das , Lad Prabhakar , Heiko Stuebner Cc: Kees Cook , Syed Saba Kareem , wangdicheng , Chris Bainbridge , Linus Walleij , Charles Keepax , Neo Chang , Krzysztof Kozlowski , u.kleine-koenig@baylibre.com, Pengpeng Hou , Cristian Ciocaltea , Hemanth Selam , Md Shofiqul Islam , Bjorn Helgaas , Zain Aboobacker , Sang-Heon Jeon , Ajit Kumar Pandey , Ravulapati Vishnu vardhan rao , Bo Shen , Vinod Koul , linux-sound@vger.kernel.org, asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, patches@opensource.cirrus.com, linuxppc-dev@lists.ozlabs.org, imx@lists.linux.dev, linux-rockchip@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH 20/24] ASoC: renesas: fsi: Ensure the component is marked as opened on success Date: Thu, 8 Oct 2026 17:38:27 +0700 Message-ID: <20261008103831.542533-21-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20261008103831.542533-1-phucduc.bui@gmail.com> References: <20261008103831.542533-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: asahi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: bui duc phuc snd_pcm_hw_constraint_integer() may return 1, which is then returned from fsi_pcm_open(). ASoC only marks the component as opened when .open() returns 0. This currently has no functional impact, as fsi_soc_component has no .close() callback. Still, return 0 explicitly on success to match what ASoC expects and ensure the component is correctly marked as opened. Signed-off-by: bui duc phuc --- sound/soc/renesas/fsi.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/sound/soc/renesas/fsi.c b/sound/soc/renesas/fsi.c index 23b7e63596d3..88618e4b052d 100644 --- a/sound/soc/renesas/fsi.c +++ b/sound/soc/renesas/fsi.c @@ -1811,14 +1811,16 @@ static int fsi_pcm_open(struct snd_soc_component *component, struct snd_pcm_substream *substream) { struct snd_pcm_runtime *runtime = substream->runtime; - int ret = 0; + int ret; snd_soc_set_runtime_hwparams(substream, &fsi_pcm_hardware); ret = snd_pcm_hw_constraint_integer(runtime, SNDRV_PCM_HW_PARAM_PERIODS); + if (ret < 0) + return ret; - return ret; + return 0; } static snd_pcm_uframes_t fsi_pointer(struct snd_soc_component *component, -- 2.43.0