From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f180.google.com (mail-dy1-f180.google.com [74.125.82.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AE6AA3E9C11 for ; Thu, 8 Oct 2026 10:40:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791456009; cv=none; b=ufsYd0qq1ToYX9szh6+K6ZQT5djz977CUe/96ncLcH1GIn43Bhv2tOPOiBKHWo1MqxC1SFMAeJsj5aBQiSMDp0h8mrCE1zlj1q6cV4/FOL5UTrrH1j7W8J3O879LCMw/SJIrb/4I2KqW0/bHzgZTHlvkmCiI2gTMBTNuFhK1+9U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791456009; c=relaxed/simple; bh=DQpdidc1ReLLfSxwfYnPC+Bi6IVnbVwubPbLgmRRb1Q=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=tPMExwuR0DqmFouHvEdIlebPulu6pjgY1rDtKV3S1TD4oAbpmVLjEzNwoBviEFv/W5ZtjoC5KofKJIF4twXlNoUBReluFB/XfV9U98LRR9zqPQ9SbMVT0PRDjKqlwVr0Ay9vSxrNYZR+fpgL0W9YXGGx/qgkIHH75NF1u4vraFo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=oTUSI9lV; arc=none smtp.client-ip=74.125.82.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="oTUSI9lV" Received: by mail-dy1-f180.google.com with SMTP id 5a478bee46e88-34ceab2900eso4962427eec.0 for ; Thu, 08 Oct 2026 03:40:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1791456008; x=1792060808; darn=lists.linux.dev; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=l9nxhJUopT9Lxb0IcO/P1HkSQbbENhmHQ1cr6x4IK+g=; b=oTUSI9lVQ2z1uwU36aJ9YqZN9LoId9kyunbS8B1Aq9hMiRvUtD14bhsskXQrK1PpWZ klUQUGpBAeJZzxW1o1L5T5x9XoaMTTj/IHXWtrrYO1nFASR7gY4glLDBm4HvsnV5Hwcj JxhGvJcv2Pivw1No/Vhmt6KDGacw1FwxWfzhr08kmO2rQAyCSyLpuhsuJDsLPHngH7r3 jlcn7WNaDBRnt3BmbVWn4z9Xk0Nk/gSO/PrJIyYpE4tomhRxtTkhvZ0c9XptXIDMFGEb Zw3aUTeRhPcDHjcbxhQALypunXosfmXjyta3enbQ9yUlQFtZax4W1EBYvi5P46K54oW2 DfGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791456008; x=1792060808; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=l9nxhJUopT9Lxb0IcO/P1HkSQbbENhmHQ1cr6x4IK+g=; b=a8EIYkuc98hGyLvgjGflSAR5evIJWnVIldnBnH1ErpDyjDZVl3fu/JO/GQwMY8jlDI rxrcJXQMY7+pQh2X9ASgDANbtOKPb2ndTw6NWWaf1P9CYRwatY7CAXHp1wKDzsD/cEma KU8yDr3aTsMSnU5bfJqOPjkp6rxLLk1D/Vbi6kcZ36FeoanUMI8uaCeqtl0LpV93GKfg 2AivW3oR+xia+A0pC9weBOEOZMXsnLegodLJqPH1QxpIcPskKEnhJX0KognmrrbpwGD4 8X/rbbYZV0Zp6Oec/G+VYXIi7PYOtwS7q/s1xgpZq3zHNy6JofF+wrcud5d025Vi/o2J CDBw== X-Forwarded-Encrypted: i=1; AKwUvBwOGwXH8wlL/qu/gPwOOlr2BZGaun3GLshEVVtfCkwzppP6M4sh7n7v3aIgcsbWPjkrHSgPcQ==@lists.linux.dev X-Gm-Message-State: AFq9FYKeOhO+FGi2UxK/yEErh9yYbBAc9jeZvmF4md2p+wAxwxp5NIss V5PSGgv3fC/EOwZySbeo8eadXN78P5UCUhF7q+KtJv4Jg6esUcw44zXr X-Gm-Gg: AYBFou0DKOiYWoXKg+wzSucEHeOcfepCHfs1Fww/1NUKMfh6Ka+qq4s1NtdTbbXEGYI blb4UiZQzRlIS7QlyFh4av7mm6fYJfUC5gqTCMxD/cpM+WwibtB+Hsr0U6mavuqHrD0ZimUI/JV dnx72JITdxwbsjmKsvPzfaniwbDijN99haBP+lZDeP843kS08LlmikKT4p7U6l2ZIBHncqNU67m 6V3TTKlW/0+uyQOjOnjZ+e8vG3t4v6H22NrzwlssYjXC4M9uWInpIVDIROs/hPzj1Ij57uFVvGW GubHNeitwiflcCnkA0m0S9zR2KWFZe1LCBUIXjnpD2B7E2dKidyFAFEAsHTwpAJJWH2AkzYPxgx mFCtUY9MhDBtDRHA2MCnnteLmtI4kihzTgsIio/4GcD4zl0vx0YjCnqm12+54Ze6IMTPe+PLOg/ 8DK7bwvJDylc6RMFKrMm4e1pPLqafvsKy5QQ/VY8C1EWsSL1WZWmKrDzfbS2TezzY5PdLvGvmDu FgDtHKqkPJFrGK0xu6zZ0NVIJRYA1ZsldDfnwHc7Z7cAM6hVnPqCBRXFoWObJfdbsg3fwjIRhxh 4e4NhJUlTZ9MuA== X-Received: by 2002:a05:7301:1e84:b0:350:89a8:5598 with SMTP id 5a478bee46e88-3515ddb2b12mr7233126eec.9.1791456007627; Thu, 08 Oct 2026 03:40:07 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3517810b895sm7496369eec.17.2026.10.08.03.39.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Oct 2026 03:40:05 -0700 (PDT) From: phucduc.bui@gmail.com To: Vijendar Mukunda , Venkata Prasad Potturu , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , povik+lin@cutebit.org, Claudiu Beznea , Andrei Simion , Nicolas Ferre , Alexandre Belloni , David Rhodes , Richard Fitzgerald , Shengjiu Wang , Xiubo Li , Fabio Estevam , Nicolin Chen , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Cezary Rojewski , Peter Ujfalusi , Bard Liao , Kai Vehmanen , Pierre-Louis Bossart , Kuninori Morimoto , Geert Uytterhoeven , Magnus Damm , Biju Das , Lad Prabhakar , Heiko Stuebner Cc: Kees Cook , Syed Saba Kareem , wangdicheng , Chris Bainbridge , Linus Walleij , Charles Keepax , Neo Chang , Krzysztof Kozlowski , u.kleine-koenig@baylibre.com, Pengpeng Hou , Cristian Ciocaltea , Hemanth Selam , Md Shofiqul Islam , Bjorn Helgaas , Zain Aboobacker , Sang-Heon Jeon , Ajit Kumar Pandey , Ravulapati Vishnu vardhan rao , Bo Shen , Vinod Koul , linux-sound@vger.kernel.org, asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, patches@opensource.cirrus.com, linuxppc-dev@lists.ozlabs.org, imx@lists.linux.dev, linux-rockchip@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH 04/24] ASoC: amd: raven: Fix acp3x_dma_close() being skipped on rollback Date: Thu, 8 Oct 2026 17:38:11 +0700 Message-ID: <20261008103831.542533-5-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20261008103831.542533-1-phucduc.bui@gmail.com> References: <20261008103831.542533-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: asahi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: bui duc phuc snd_pcm_hw_constraint_integer() may return 1, which is then returned from acp3x_dma_open(). ASoC only marks the component as opened when .open() returns 0, so .close() can be skipped on rollback. Return 0 explicitly on success. Fixes: 703a6e22888b ("ASoC: amd: Enabling I2S instance in DMA and DAI") Signed-off-by: bui duc phuc --- sound/soc/amd/raven/acp3x-pcm-dma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/amd/raven/acp3x-pcm-dma.c b/sound/soc/amd/raven/acp3x-pcm-dma.c index 37ea5c572eb9..072f3dc35d40 100644 --- a/sound/soc/amd/raven/acp3x-pcm-dma.c +++ b/sound/soc/amd/raven/acp3x-pcm-dma.c @@ -237,7 +237,7 @@ static int acp3x_dma_open(struct snd_soc_component *component, i2s_data->acp3x_base = adata->acp3x_base; runtime->private_data = i2s_data; - return ret; + return 0; } -- 2.43.0