From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9509F36195D for ; Thu, 15 Oct 2026 01:46:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792028805; cv=none; b=YgDuA4n9OZIEK0qiZpzMFeyQV6sjslLfvSBPAzm0EJZmCEGXCoLQ2uCYHe909Bp6AwKhlbUzkA+lNu5MIyuwKDrEAE77cd4fPNgakCVUEiWqnoutGCyWzmhIOY12PqbCTOrJClyTpPtDxLx5+Zf8I/CP3aycvPUES9SoWMVe/rk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792028805; c=relaxed/simple; bh=HEnoir5YUU9pRtHiCZMnqTe7yfBh5BOFRRnUCPqrwfQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=VwMTCA5kClSV5xeATIeOyMoxUfibl3uoHVQ6ponX9rJjc/hpxzH0DPZ/RwCGFawNalMw9fQyxsZLqjbRrDPfbw9N2azL1iTZG+Gc+aeV3uUQZzfMfl2BwB+B4EdrB/EydqA0Esy+whBi4BkYHd95/vs+9PExsM+Scf9EzlkyS74= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=iEGabYiW; arc=none smtp.client-ip=209.85.214.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="iEGabYiW" Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-2db710396ffso36899865ad.1 for ; Wed, 14 Oct 2026 18:46:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1792028803; x=1792633603; darn=lists.linux.dev; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=tNKaoas0suhXoNZM631qYPKJn33cxyMQnmMBR8n2e68=; b=iEGabYiWsLfHzj3llCzDp410Qog7s7BvmQrTBcEqbf6AavJIIe5xvvFMVFyMEfjcQt 2EOPHnyi5SfE6uaURcYybcdrVrIXxwI3b94664yTclhwNeBIjI2ZgVsmFThnqBKyqbyK OICRpwd6UmoUk4YlD4ReB8OWY+Hl+lZoM7j1PxSi1usBmTjqE5tUqPWaEEhMdfY3AcBX uc5fcmoUvid84GakbfCluzZyEAi0g09R1A9r7LdIJ66T6Cme/ps55eeJ2vI2QWiReuRM MLJ+69fPUSx7hiqCTlD8yD2Gknm07XvuEkwKvv6/oLctxIyF861Ela92y9oRj1nR/kTs Os3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792028803; x=1792633603; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=tNKaoas0suhXoNZM631qYPKJn33cxyMQnmMBR8n2e68=; b=TMkymNKjYiFqKHHOx/VrKkQvgdYs2iOliRLNBTfpc1uoMxbn9ntEeY4Vl1/Rh8VD/j uUCiRqsG48SRMPptvcgyFdepsfumtnbOyZmqoGJ2ZydzkYvamBEPYeFGBRS7gObMqsHO /gIyb1ZTWDMkRIBqU4YUrCIvhICQouUpQyaH6H5xRUhEeD6hbJhrHgVAsrIitJgGRJ+h g7QRufn3V4CQ8fD+kDFmqOQTAuw3XkRJqmHCnQrlco27e+XMiByvy6j0lOputeCYsK8z 7+Y70eKmFA9IHC11gEOlFIXaw15Fej5OcAn5eM2Qx96gWT7aaV1GhaESYOJDtHIb6UER 9NVA== X-Forwarded-Encrypted: i=1; AKwUvBxzHsX4pmKRpuFddrnflRaMq217OY4SFRzR0twEcozkuF+qsnq8UDkwpnnBssiuW83q72Bqdg==@lists.linux.dev X-Gm-Message-State: AFq9FYKBDG7s9qE+V7J0a6SDbYaoG2PX6TnE0i9Rl0pvZWYEUdJp7mI8 04PZK1kd8U1bQTiNbDVVwzqcvu0e6b2kVc05PxMwScxnLv6EYkekRieZ X-Gm-Gg: AYBFou0++zxq3Nhq2G8ONH8LErGIHJ8z6a6NK/ouCbhBIYPQhmdA8Huj5BbZ+WX6D8K EkUSPMhk5TgPPoh8tTr/tkb686nfSxFkUKrvag15F7HTEV5049EBq8WqNdI0ZCU2LxcwQeYbfx7 zr+ceIo5sOlMRnmVwjGa0g7JmKy27/CL6rlvJVNe9MdacakygRH5+aLaDxkinXGBNZzOQpmqzvz SnjFQZy7IFiSPYt3Q0LVnXMVWHa5TRfXrDdWqqX7CHwwjVie/cQkfX44YXWMOp5gGsmafpixZZw uoCZTQFqu+91JG2LYz97nVr9fNhmR+wPjgU1D8MObDvW0zxXktef46mV47NL2mnMTCCG92OqkPP cQlE9oq2Nt2NWtOEAkr9+CMHlEsGeNa8nVkZ2lg9hwXRswds9vPRqAfChETEAmSzoiGa0dtmUvd mNcDFi2vVy3qTYAFRVqagrMO+nfjxrDB1j8bfY2deFo8DbGV/pndsc15D1phXYutSbmzHdtF7uG JE7K3OfYYPafK7VohJoUMYdbfZeB4GQQ9bvYycQ9h8ZP7fCAU/o1pDkXX90wXjt5dyvezDlK2RT qOudEMamyy8xcw== X-Received: by 2002:a17:903:37cd:b0:2e8:5857:b5f4 with SMTP id d9443c01a7336-2e85857ba34mr106063185ad.10.1792028802766; Wed, 14 Oct 2026 18:46:42 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2e8422b8cc1sm73202995ad.54.2026.10.14.18.46.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Oct 2026 18:46:41 -0700 (PDT) From: phucduc.bui@gmail.com To: Vijendar Mukunda , Venkata Prasad Potturu , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , povik+lin@cutebit.org, Claudiu Beznea , Andrei Simion , Nicolas Ferre , Alexandre Belloni , David Rhodes , Richard Fitzgerald , Shengjiu Wang , Xiubo Li , Fabio Estevam , Nicolin Chen , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Cezary Rojewski , Peter Ujfalusi , Bard Liao , Kai Vehmanen , Pierre-Louis Bossart , Kuninori Morimoto , Geert Uytterhoeven , Magnus Damm , Biju Das , Lad Prabhakar , Heiko Stuebner Cc: Kees Cook , Syed Saba Kareem , wangdicheng , Chris Bainbridge , Linus Walleij , Charles Keepax , Neo Chang , Krzysztof Kozlowski , u.kleine-koenig@baylibre.com, Pengpeng Hou , Cristian Ciocaltea , Hemanth Selam , Md Shofiqul Islam , Bjorn Helgaas , Zain Aboobacker , Sang-Heon Jeon , Bo Shen , Vinod Koul , linux-sound@vger.kernel.org, asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, patches@opensource.cirrus.com, linuxppc-dev@lists.ozlabs.org, imx@lists.linux.dev, linux-rockchip@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH v2 10/25] ASoC: codecs: cs42l42: Ensure the DAI is marked as started on success Date: Thu, 15 Oct 2026 08:43:09 +0700 Message-ID: <20261015014324.5569-11-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20261015014324.5569-1-phucduc.bui@gmail.com> References: <20261015014324.5569-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: asahi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: bui duc phuc snd_pcm_hw_constraint_minmax() may return 1, which is then returned from cs42l42_dai_startup(). ASoC only marks the DAI as started when .startup() returns 0. This currently has no functional impact, as cs42l42_ops has no .shutdown() callback. Still, return 0 explicitly on success to match what ASoC expects and ensure the DAI is correctly marked as started. Signed-off-by: bui duc phuc --- sound/soc/codecs/cs42l42.c | 16 +++++++++++++--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/sound/soc/codecs/cs42l42.c b/sound/soc/codecs/cs42l42.c index b5d69d5516a6..18d6cb9bfa2c 100644 --- a/sound/soc/codecs/cs42l42.c +++ b/sound/soc/codecs/cs42l42.c @@ -890,6 +890,7 @@ static int cs42l42_dai_startup(struct snd_pcm_substream *substream, struct snd_s { struct snd_soc_component *component = dai->component; struct cs42l42_private *cs42l42 = snd_soc_component_get_drvdata(component); + int ret; /* * Sample rates < 44.1 kHz would produce an out-of-range SCLK with @@ -900,9 +901,18 @@ static int cs42l42_dai_startup(struct snd_pcm_substream *substream, struct snd_s return 0; /* Machine driver has not set a SCLK, limit bottom end to 44.1 kHz */ - return snd_pcm_hw_constraint_minmax(substream->runtime, - SNDRV_PCM_HW_PARAM_RATE, - 44100, 96000); + ret = snd_pcm_hw_constraint_minmax(substream->runtime, + SNDRV_PCM_HW_PARAM_RATE, + 44100, 96000); + if (ret < 0) + return ret; + + /* + * ASoC only marks the DAI as started when .startup() returns 0. + * Since snd_pcm_hw_constraint_minmax() may return 1, explicitly + * return 0 to ensure the DAI is correctly marked as started. + */ + return 0; } static int cs42l42_pcm_hw_params(struct snd_pcm_substream *substream, -- 2.43.0