From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E3C5835F5ED for ; Thu, 15 Oct 2026 01:47:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792028857; cv=none; b=jIA0J9Sr9QNQom1pC2trYkC6EusSA4ki7OXkPZ61WmfpQ3jRX6TyhtOhsCDx7/lSr973+mSUCqnjOdO6ArgrxDqz6lRRprSLwy/rLd7e1bsHbIMOekKP2X5Uw8LlYJMta1C5mLe29UlRr6v9N9HbgHYksvfGbvz8s5GEW0fGrEM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792028857; c=relaxed/simple; bh=gbKxRXgxq8DVqFsIIwbQbc//22j1RiqNWHX1MLDGpQA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=HIGkqH5C6bnqoXYs6cFcJxW/b8VzoOaw6vJd4PdIV8Zt5DwUrFHb0YBqRxF+cYFHVIyXW7vPu1PH7HGqeYSLw05LkpCRUypQxDydigc3RAdDk1JWFs91Ct6aHU9wmIQQ3A6ovAQNIFtRqVCtesscwlyf9yisPqwHd5d9reFrGoQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=I0wJiLwo; arc=none smtp.client-ip=209.85.214.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="I0wJiLwo" Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-2e86dce4510so24249425ad.3 for ; Wed, 14 Oct 2026 18:47:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1792028855; x=1792633655; darn=lists.linux.dev; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=qvYpMSlsoaD702JqdWz6T2bQ1dialbnMpsVm+cSYlj4=; b=I0wJiLwoInljfw64YYx/Kll6VugXOFLE6+cBwsWAqCfkkXIhVfxcijNyLPpDIRxNmI 0zr00Z7a0JFWL9gWpyThkktHVdW3T3EFZa/j9ZSsphu8YqaN/S0uDsOm2CHkNLs8jcKD QgxUG/NzXzToCjFm1YSQOPgQy51qIiF8IbbA3jn1+mKGcHLjou9iGlFplXSNbESDoVVL QKXDQlQmz6er7oH1hnES39yvt8o8nxQQzjswmR57vV+gTYWcZ0EqszX8zZe8Fd9gcVUS M8B9nVokFXAzp09yAKV+YQNH+jxsfd+t9mNg+ARxW3tX57Dae9Tfv26hpWR/6+OprZpj uEtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792028855; x=1792633655; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=qvYpMSlsoaD702JqdWz6T2bQ1dialbnMpsVm+cSYlj4=; b=DVvKUI4edN0i8hxQJVRcfexDMBReqVpuVLL7D7ntJssxu5kR7fMUrWOjqYSxR7yjvt k0nvrowxbxdU7gvh7Y1yMGOQZSaG5yLtAMDWbKA1sDw/eqnNj0pFJ2kIBdkIPsb9Zsdf yBeAYOr+zbJmH0FHwb3vsgw291S/MbX0r/hNi4O1/FgGZ+vGgGLXsO3yvdYty745O4dR kr7y4ydKvz7diCUUZGIs5xVnQp5qL4l9WH4n9kiwYnFbcbZtSPim5T6oFm74mRCHDiq4 5TM6zivLmsTanQscg/X84yUd5f7MtKglQdph1k+DPs3VuGHP1lGSPyw/yzU5Vy318Wsc f7UA== X-Forwarded-Encrypted: i=1; AKwUvBzfSwl0oNY6vwII9sQi5//BlKq3UDE4HsMlbUu9q7Oo3BNvgHDJ/7b1oGq2GoU+4CpR/3LYIw==@lists.linux.dev X-Gm-Message-State: AFq9FYLhYuZFmteUERCyykzxV5mCR6++M83U0WuLVWIEIoX32qqg+/Ff Jm0u7a36tGAKhkZ0dKXf0uM1UUh8BuHazreWCZETIU+NBKBOIJdiWqKw X-Gm-Gg: AYBFou282ofvAKzIEFrA+zSr+jTE8zdwcmXgrHBPjqO3iu9cQk4K4GQyakfrnxUg9JV IOmwGcjKsn9kDd65xuB395knfBnsJ0+W80Ab/Ux4jxRICW3Y07PqKt5MT+uPMb0zSGUnRkYZEKM bpEwXj4+nQM2hloFmezgxpKh1RxlcC2osmjPDAcuQI6WeDTI/s3jqiHvFsAAyvHHSdGOKqgjbCk vEVyT7R0O9AYa0RlilTH8Qr3IwJnlaUksSzLU+gJ+Fe1SCzteezdCNYmD3UTqOOYdl215AsIZ58 cwy2qMI/IvMgVyXD/1tx2B9Tarjnb4N+JbqpJuwaL1GHufxFKT8rQ+XxwVzSTNSRnNlfxRGKSkj Qr5SJXT+wBqHA9UfVscRzq5EUC6jeVRxPRTLLq3SYBNYFmU8aG2J/8Oz/iKoYBJV6KbW8ThGNCF 4hS9VFdgRlS06PnQTK8jxjAH2wG0sWJPZNY6O3bEKAIpCU/IasiucxfQfoZ5RsuBCkZGZEdzHfQ XNshFzxSMSq+pkQzESCpBrrryjie2YhWHk8A0sZVx7EU+3D0TtvecQrUOUNGz6gwFoxaw8PWmy8 Z1dZXYCyoxT+DQ== X-Received: by 2002:a17:903:2442:b0:2e8:422e:19c5 with SMTP id d9443c01a7336-2e842dfd28emr133980465ad.55.1792028855139; Wed, 14 Oct 2026 18:47:35 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2e8422b8cc1sm73202995ad.54.2026.10.14.18.47.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Oct 2026 18:47:34 -0700 (PDT) From: phucduc.bui@gmail.com To: Vijendar Mukunda , Venkata Prasad Potturu , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , povik+lin@cutebit.org, Claudiu Beznea , Andrei Simion , Nicolas Ferre , Alexandre Belloni , David Rhodes , Richard Fitzgerald , Shengjiu Wang , Xiubo Li , Fabio Estevam , Nicolin Chen , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Cezary Rojewski , Peter Ujfalusi , Bard Liao , Kai Vehmanen , Pierre-Louis Bossart , Kuninori Morimoto , Geert Uytterhoeven , Magnus Damm , Biju Das , Lad Prabhakar , Heiko Stuebner Cc: Kees Cook , Syed Saba Kareem , wangdicheng , Chris Bainbridge , Linus Walleij , Charles Keepax , Neo Chang , Krzysztof Kozlowski , u.kleine-koenig@baylibre.com, Pengpeng Hou , Cristian Ciocaltea , Hemanth Selam , Md Shofiqul Islam , Bjorn Helgaas , Zain Aboobacker , Sang-Heon Jeon , Bo Shen , Vinod Koul , linux-sound@vger.kernel.org, asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, patches@opensource.cirrus.com, linuxppc-dev@lists.ozlabs.org, imx@lists.linux.dev, linux-rockchip@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH v2 13/25] ASoC: codecs: nau8821: Ensure the DAI is marked as started on success Date: Thu, 15 Oct 2026 08:43:12 +0700 Message-ID: <20261015014324.5569-14-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20261015014324.5569-1-phucduc.bui@gmail.com> References: <20261015014324.5569-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: asahi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: bui duc phuc snd_pcm_hw_constraint_minmax() may return 1, which is then returned from nau8821_dai_startup(). ASoC only marks the DAI as started when .startup() returns 0. This currently has no functional impact, as nau8821_dai_ops has no .shutdown() callback. Still, return 0 explicitly on success to match what ASoC expects and ensure the DAI is correctly marked as started. Signed-off-by: bui duc phuc --- sound/soc/codecs/nau8821.c | 16 +++++++++++++--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/sound/soc/codecs/nau8821.c b/sound/soc/codecs/nau8821.c index ecadbaee1037..7b88ee3159d1 100644 --- a/sound/soc/codecs/nau8821.c +++ b/sound/soc/codecs/nau8821.c @@ -829,14 +829,24 @@ static int nau8821_dai_startup(struct snd_pcm_substream *substream, struct snd_soc_component *component = dai->component; struct nau8821 *nau8821 = snd_soc_component_get_drvdata(component); const struct nau8821_osr_attr *osr; + int ret; osr = nau8821_get_osr(nau8821, substream->stream); if (!osr || !osr->osr) return -EINVAL; - return snd_pcm_hw_constraint_minmax(substream->runtime, - SNDRV_PCM_HW_PARAM_RATE, - 0, CLK_DA_AD_MAX / osr->osr); + ret = snd_pcm_hw_constraint_minmax(substream->runtime, + SNDRV_PCM_HW_PARAM_RATE, + 0, CLK_DA_AD_MAX / osr->osr); + if (ret < 0) + return ret; + + /* + * ASoC only marks the DAI as started when .startup() returns 0. + * Since snd_pcm_hw_constraint_minmax() may return 1, explicitly + * return 0 to ensure the DAI is correctly marked as started. + */ + return 0; } static int nau8821_hw_params(struct snd_pcm_substream *substream, -- 2.43.0