From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 73D3C45A2B2 for ; Fri, 16 Oct 2026 10:34:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792146860; cv=none; b=s4OQF71rDHK7sudStfwpHxa3Gpi9cN6SZsY4aevjwV3gQ6A6FQSnIrS5ah5ptTyytdU9S8RH5xJLIc9XbneK9pct0EbM9GO3qhStwvVatqJMXkjJwrGPfLsFohN2UapMEptUStClUUQirVjRmSFVsFn09jlY1exu6fcgtP3HTgg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792146860; c=relaxed/simple; bh=Nv8VQkbUiPG1aZzPVXB79Tte0iN24CS3tAzHXZLKcRQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=BjJjRkmCEFRpY30hHpllmE2Yf86nGdspMALGxPWjAsEKqmWEi8MwnmrTxnqvoS2STjbMMfO2Hh9O6ap4VlPKKbu2Xtv7/5xNxZerlI/b4/5APwneFkiVPRBclWuVRTPaRXb714lgopqMP1Dhd8Y6zFLu7sUcv62AuwNZpA486Os= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=amarulasolutions.com; spf=pass smtp.mailfrom=amarulasolutions.com; dkim=pass (1024-bit key) header.d=amarulasolutions.com header.i=@amarulasolutions.com header.b=Eou87oda; arc=none smtp.client-ip=209.85.221.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=amarulasolutions.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=amarulasolutions.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amarulasolutions.com header.i=@amarulasolutions.com header.b="Eou87oda" Received: by mail-wr1-f41.google.com with SMTP id ffacd0b85a97d-48df54150dfso1029586f8f.0 for ; Fri, 16 Oct 2026 03:34:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; t=1792146857; x=1792751657; darn=lists.linux.dev; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=x+lEaq8UIfWxZ/tIjV0SG6p5OStGVbQ7BX4PDBI90Lg=; b=Eou87odaVK4sIHsIifTxGG/TMHLKme9ThMiyJDbi6yeWmLWuK383J0aHTo86Wn09Qp 8XfPvocsES6ENPS6FlFc4G5ox4l3ssQ2V032zPSSvfGLbf/eMNCEN1HCevtG+Ah4ts+a pw06fjaP07ggiW9Fv3YoV7Vw7cJS6SD5A6OVA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792146857; x=1792751657; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=x+lEaq8UIfWxZ/tIjV0SG6p5OStGVbQ7BX4PDBI90Lg=; b=fco7H9LFNkQoXXwJaSmS5R52VnxEYDHajPiw2op+hg1TScQW/vMc+THp4YK47aRab0 53qj/cyphC12lPetMvMod6AH6k9vB1/u382JNnQZ6RU0VfNg0oeC2qq0uvMyuv5ebTw2 T/dUtY/oBNVynQW0eG4TcZN4JtONTdKZmcZWZv2owXFZRkAzLDKFtpHpxxKIPm9jVb9A ZBC8+KGz/ZuJqxDP+RsOW8ClKfKfJKtKYPptKSH2rJkK5acYThYd17Ys9jcmSJncc1zv Y+dh79+bL2NHPEz62cPFLRq5FhHNbioDVbSdJl+giokHx6eWd+qhJla9Sx4Y924h89ib Cphg== X-Gm-Message-State: AFq9FYJo5kRnRcdJTyrUyRjYSf9RC9v8mPBU0Gss9JiCq/gFc3AcGIhF s94ynTHDHEWenM6EpU6Xao5Wyvg+tdSyF3/n01hF1FHfQJxzOXuvmmHiW1Jl4Ds0aKY= X-Gm-Gg: AYBFou0kUspkK9hBxsrvRXEwiZn2REXZAqR1RTcAe3iFMOfnwMpJCsJlIVe/KG5IpH+ FxCTX2Fy/+Na0N5oqRpcN+FusCKXQJx5oV0xS1Q0wFXO6ftLojHyrFg68dnbhy6SASwtOgXjaaf aVImwk1mNvDE8svuwnI2ribX7NV/sbUKgJPR7wkQ/6bt0wllye9+v2O2tQZlwcYHIRkJ5jekjyU eTCWmT1/UgDuTmVA9jonYK3Y3vzuK2lN1IN6OffiIQoGehYHDByc5qFAHJ2VQnq47jT9/+kgciY YoJqb+VvXEiGRB1h5fmiI6vCL5fM8WEGl1uR11AQZEDG9FutTOViW0iMcmFlf/20URTzMlJge4v DAzkTNof8E7dA/Ao56RBvQzX8Sf1aZcjYrJUDHBNw24w8h9WAerv7bCX8LFW1Hl7bgVdpbkXEXy 9XuD++ips+6H3CCVrOGicRMDHBLK2Ac4Pj+T3T4sWOflMYftRm9UV+WH+lJ+4BzUes+JqRZz/to VTTT1ZMtRSsMju5ciTbRZKY29ngf5WCo4JqR1kFIhLu47SZnw/rt/s= X-Received: by 2002:a05:6000:2905:b0:48c:6d9d:9f90 with SMTP id ffacd0b85a97d-48dba9d0b47mr43566956f8f.26.1792146856850; Fri, 16 Oct 2026 03:34:16 -0700 (PDT) Received: from localhost (dynamic-2a00-1028-8382-0206-0000-0000-0000-0bc0.ipv6.o2.cz. [2a00:1028:8382:206::bc0]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-48dfd503862sm4154979f8f.46.2026.10.16.03.34.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Oct 2026 03:34:16 -0700 (PDT) From: =?utf-8?q?Roman_Smr=C5=BE?= Date: Fri, 16 Oct 2026 12:33:55 +0200 Subject: [PATCH v2 2/5] ASoC: pcm179x: Refactor regmap value lookup Precedence: bulk X-Mailing-List: asahi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Message-Id: <20261016-work-v2-2-9340b9555fbb@amarulasolutions.com> References: <20261016-work-v2-0-9340b9555fbb@amarulasolutions.com> In-Reply-To: <20261016-work-v2-0-9340b9555fbb@amarulasolutions.com> To: Peter Rosin , =?utf-8?q?Martin_Povi=C5=A1er?= , Lars-Peter Clausen , =?utf-8?q?Nuno_S=C3=A1?= , Liam Girdwood , Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shenghao Ding , Kevin Lu , Baojun Xu , Sen Wang , Jaroslav Kysela , Takashi Iwai Cc: asahi@lists.linux.dev, linux-sound@vger.kernel.org, patches@opensource.cirrus.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-amarula@amarulasolutions.com, =?utf-8?q?Roman_Smr=C5=BE?= X-Mailer: b4 0.16.0 Use a table lookup to find values for fmt register instead of switch statements to prepare for additional codec variants of the same family. Signed-off-by: Roman Smrž --- sound/soc/codecs/pcm179x.c | 60 +++++++++++++++++++++++----------------------- 1 file changed, 30 insertions(+), 30 deletions(-) diff --git a/sound/soc/codecs/pcm179x.c b/sound/soc/codecs/pcm179x.c index cb70927872aa..61b87dab3266 100644 --- a/sound/soc/codecs/pcm179x.c +++ b/sound/soc/codecs/pcm179x.c @@ -65,6 +65,31 @@ struct pcm179x_private { unsigned int rate; }; +struct pcm179x_fmt_table { + unsigned int fmt; /* SND_SOC_DAIFMT_* */ + unsigned int width; /* sample width in bits */ + unsigned int value; /* FMT[2:0] */ +}; + +static const struct pcm179x_fmt_table pcm1792a_fmt[] = { + { SND_SOC_DAIFMT_RIGHT_J, 16, 0 }, + { SND_SOC_DAIFMT_RIGHT_J, 24, 2 }, + { SND_SOC_DAIFMT_RIGHT_J, 32, 2 }, + { SND_SOC_DAIFMT_I2S, 16, 4 }, + { SND_SOC_DAIFMT_I2S, 24, 5 }, + { SND_SOC_DAIFMT_I2S, 32, 5 }, +}; + +static int pcm179x_fmt_value(struct pcm179x_private *priv, unsigned int fmt, + unsigned int width) +{ + for (unsigned int i = 0; i < ARRAY_SIZE(pcm1792a_fmt); i++) + if (pcm1792a_fmt[i].fmt == fmt && pcm1792a_fmt[i].width == width) + return pcm1792a_fmt[i].value; + + return -EINVAL; +} + static int pcm179x_set_dai_fmt(struct snd_soc_dai *codec_dai, unsigned int format) { @@ -96,40 +121,15 @@ static int pcm179x_hw_params(struct snd_pcm_substream *substream, { struct snd_soc_component *component = dai->component; struct pcm179x_private *priv = snd_soc_component_get_drvdata(component); - int val = 0, ret; + int val, ret; priv->rate = params_rate(params); - switch (priv->format & SND_SOC_DAIFMT_FORMAT_MASK) { - case SND_SOC_DAIFMT_RIGHT_J: - switch (params_width(params)) { - case 24: - case 32: - val = 2; - break; - case 16: - val = 0; - break; - default: - return -EINVAL; - } - break; - case SND_SOC_DAIFMT_I2S: - switch (params_width(params)) { - case 24: - case 32: - val = 5; - break; - case 16: - val = 4; - break; - default: - return -EINVAL; - } - break; - default: + val = pcm179x_fmt_value(priv, priv->format & SND_SOC_DAIFMT_FORMAT_MASK, + params_width(params)); + if (val < 0) { dev_err(component->dev, "Invalid DAI format\n"); - return -EINVAL; + return val; } val = val << PCM179X_FMT_SHIFT | PCM179X_ATLD_ENABLE; -- 2.55.0