From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F1436382383 for ; Fri, 16 Oct 2026 04:11:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792123912; cv=none; b=lYZqsJZJJHFquvcfHVtJSMYYF8ZWjSPy9U3owQ9ckwsm44YX/s57GgYHB5UsynGgs8rWMB8MQHdHkU4BEzAdRkKgvUHsUHdldogAk0cedJ0N0Rs0FM0s4Hwuu9bUcFzWRy3W9h/6XWX4tlPbejMn6vLDPuAos2opvJHbrQn6YV4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792123912; c=relaxed/simple; bh=4ChQc4DpaiRpFVYZQOX6JdbhBOh/CN3kyOWjnYuDL7A=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=GQ8bXvPw7vDexLKzg57EfD60yGyBDrTFdNSaMXfCH0nMOeilGmMeddop8r+x8OAe499p8Hd7bysuIKjwD/085DoFK+fuTLEPlkAaHhk4A1c+nc+RZNa8UiB43UQpd8qGdywGUXKMonIpaX1BOP+2HLITYWxIbG4nYeBAUPoYFeY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=e7C3b7hc; arc=none smtp.client-ip=209.85.214.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="e7C3b7hc" Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-2e977109392so5456145ad.0 for ; Thu, 15 Oct 2026 21:11:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1792123910; x=1792728710; darn=lists.linux.dev; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=DnS3efznOy4aR/sEoOKiH1O7kNcA8JAEG4dTp1VvwAA=; b=e7C3b7hcq+BCPXHUHAbTbTn40WOrKpyxZ++XJoq5gx67YZ7+sDhlxDfB7i8bi1S6ne vBd3vOznDEMKyCejB4MJREfvTdn43ylWbkfPcWmn6Q62pJK0i56l194GlnVQZ+7Vdy32 18GGHWP5liXMng+QH5SNcjF1xCsSlqPi5XSn/ZR9hfdZYFGZwRgiwmVQdZtHy9Q2vBsS TN4DQZ1MS6pZzlaNiGDfC44Q3qyRK/NheBMm3VAnsPltb0qtRlJ+/axk9lkjtVu/QZ1j ZFUNkImtt4OTAz+wcZXxYpTnqCRWe4g8h/uVHASEptg4ezGq2AvKiXOIBJmGSIKLC/h7 Gm2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792123910; x=1792728710; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=DnS3efznOy4aR/sEoOKiH1O7kNcA8JAEG4dTp1VvwAA=; b=qo6WeffwDKIHvNmJMI0ef7GdhMsBAAAcyInKEz6AtCa96B9h6AFiwc0mnjIFAGO5S+ LlUzwIlAfKC0Fh51AGjQTKC1wAXEXXRxyb7Lwt01uYAVq8aru/Bw113IJEGpJ+34UshQ dNdc8lej2T4bZbaf7MVQUok2GAWCAVC3h4RWDTffZ4ROX15GEdQ3gKFNVYKXVCFxX5Jw 8MBhsEuYO0SnnZ04G0q7zqCanGIsSpLGsSWiWU334o4TYHoH4B9TPBZzIPmRFfXICTem K0o6l67ynJZNV6rLEQSLu5/IGVwmlWd652X3E9EG9+mGuQHLhVj0AGb03740AzqSnMmN cqZg== X-Forwarded-Encrypted: i=1; AKwUvBy2tyVeYyQXQiMF+Gt8J2puadfIlNbumG1+0C5lwzoDyevf1sEij7RJ7xBrsJfvZD1WgDsdmw==@lists.linux.dev X-Gm-Message-State: AFq9FYI0pMB4MmdAFv5OV5lpGhys2VTsJUIDdB+0mqLGrwBjAjhfDWoW FeIyKKd8Y2W7XC2aaxX1auB3nyGzh4S/NYRTmmiXRVKrLxjzKFBc0Zx+ X-Gm-Gg: AYBFou0LZ2E3+E4eLFIdD12XW3w3FefXP7rms1o9xHoraKUhXLMj7LKZzv+XXJ6SqIG qRNW0yx6M/lYkhgVIl7zaoMMxJ/iSitoVVXMD1Nuwj8+C0DOkyoZdxT6jOmT8U4lVyV5DPeinD9 uQUJjp1H9OekkZQIknKEG9VT0xEDyiEvb6b+mHUcHutVoQHayiq4pE5J2+2IVs9J4n93lI7W+Ji WskUpU5+5PuqXSEiwPlPAEhhqPCD16Bs9c3KFMda+mac/XMsJEh/pKo30eOZhN2l255b4iyLYnJ WWB06EXZcInuYDFHsoykCBUnZ2QXQjgcClE8/DZAcPi+KzB9h6MJSRW4uOApDe86A9r/w84BBnT n+RyCf/SP4WiHtFfaZFJxUl4SwjlRIWYCEBFSAh3EMiMQRNOgv6ggYdIbl4YzhPIHDxqBr44AVB UkuTqKgMUJIlno5dRY4YKH7rzqBjyMcMsKieFLH6tei11UKWixoT8ej/JFcZ99Q0vyo9SgSqkdB DnXy7YQtpqtmSxjgqetjFOSkpTpL+XPUljYBUpS659z3m+vmn/QOFB8R+/AgUiNuQ0GfEc8RfFN zVGnvX4sgtb2fw== X-Received: by 2002:a17:903:38c4:b0:2dd:c100:4257 with SMTP id d9443c01a7336-2e842f11875mr181177615ad.59.1792123910214; Thu, 15 Oct 2026 21:11:50 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2e97e8ab443sm3815785ad.65.2026.10.15.21.11.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Oct 2026 21:11:49 -0700 (PDT) From: phucduc.bui@gmail.com To: Vijendar Mukunda , Venkata Prasad Potturu , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , povik+lin@cutebit.org, Claudiu Beznea , Andrei Simion , Nicolas Ferre , Alexandre Belloni , David Rhodes , Richard Fitzgerald , Shengjiu Wang , Xiubo Li , Fabio Estevam , Nicolin Chen , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Cezary Rojewski , Peter Ujfalusi , Bard Liao , Kai Vehmanen , Pierre-Louis Bossart , Kuninori Morimoto , Geert Uytterhoeven , Magnus Damm , Biju Das , Lad Prabhakar , Heiko Stuebner Cc: Kees Cook , Syed Saba Kareem , wangdicheng , Chris Bainbridge , Linus Walleij , Charles Keepax , Neo Chang , Krzysztof Kozlowski , u.kleine-koenig@baylibre.com, Pengpeng Hou , Cristian Ciocaltea , Hemanth Selam , Md Shofiqul Islam , Bjorn Helgaas , Zain Aboobacker , Sang-Heon Jeon , Bo Shen , Vinod Koul , linux-sound@vger.kernel.org, asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, patches@opensource.cirrus.com, linuxppc-dev@lists.ozlabs.org, imx@lists.linux.dev, linux-rockchip@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH 08/11] ASoC: renesas: msiof: Remove redundant period constraint Date: Fri, 16 Oct 2026 11:09:43 +0700 Message-ID: <20261016040946.521195-9-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20261016040946.521195-1-phucduc.bui@gmail.com> References: <20261016040946.521195-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: asahi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: bui duc phuc snd_pcm_hw_constraint_integer() is already called by snd_dmaengine_pcm_open(). Calling it again in msiof_open() is unnecessary, as the constraint is already applied and the second call returns 0. Remove the redundant constraint call. Acked-by: Kuninori Morimoto Signed-off-by: bui duc phuc --- sound/soc/renesas/rcar/msiof.c | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/sound/soc/renesas/rcar/msiof.c b/sound/soc/renesas/rcar/msiof.c index 9fead9a22cdc..11a6f22ec0ad 100644 --- a/sound/soc/renesas/rcar/msiof.c +++ b/sound/soc/renesas/rcar/msiof.c @@ -419,19 +419,13 @@ static int msiof_open(struct snd_soc_component *component, return PTR_ERR(chan); ret = snd_dmaengine_pcm_open(substream, chan); - if (ret < 0) - goto open_err_dma; - - snd_soc_set_runtime_hwparams(substream, &msiof_pcm_hardware); - - ret = snd_pcm_hw_constraint_integer(substream->runtime, SNDRV_PCM_HW_PARAM_PERIODS); - -open_err_dma: if (ret < 0) { dma_release_channel(chan); return ret; } + snd_soc_set_runtime_hwparams(substream, &msiof_pcm_hardware); + return 0; } -- 2.43.0