From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=74.125.82.179 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793264546; b=zzd4oG8m/gZNabhlAT+qX8qJ8e8v/tIyihkumEjAROGzcqPA2JPGFIpl8mGbE7uUq+th 0tdpZW2SQB+Y78gRbxhE9/XUKXTq22OmRwkRzAHY5Sj7/uS8/CdfZA7ZJb9TeIs7jjPbR 3LH1Eby1Hwh7ua9y+ZykMu/TIXkjazsyaHXZPQAQc2tzrK9UhYoJMjkjUgBtQ2QPetTrj 8cGQ67JyQWfqRkRGCD1KImSGiZor+1Kz4hlMunbN0jg85utTBavyiPo2i8yYIQw/1uNi+ q0bPxFbz83fXS/JSFUFu6uqucxUPOkSD3WafSXP4HFuP6U+Ar1Payqjs1l3fn8/h1fg== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793264546; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: From:To:Cc:Subject:Date:Message-ID:X-Mailer:In-Reply-To:References: MIME-Version:Content-Transfer-Encoding; bh=Em6bj94swsrfUrSQCXEn0xceZl+9/C90nnaFaaRvExo=; b=A4X7MDVJhuR5Czjl6TohmpdG9Prk3w7qkMcRf996oA1Ij86Cf0iHrmgQT4j7Khl47ZVy MVNAiu1JrNlNDNvnjSnmw8WSgFf8hYb37RvMIcptlyvTtMrN/hboTaTgfFC4zibTTrFHw c92P1YHq4UctksBnBVLl815XBaLOpU12wOIwHbBZwgKy7dRbHI4CATCfrVQ3+H5Tz7NHD tTa4/bQIKTGqyYcps95r/qdTmwdISht5SITDRBYktDgYSHUZ1XuuEjI0kh/JFk/iOf93Y 8AUDLcMPofMdZAn3hPgNrHcwfUsdo6fT5Hu9Z4bj7j3GsvmiMnFkdiPm9NyVsPHTz4g== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=qcyNSOiL; arc=none smtp.remote-ip=74.125.82.179 Received: from mail-dy1-f179.google.com (mail-dy1-f179.google.com [74.125.82.179]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F018F60A260B for ; Thu, 29 Oct 2026 09:02:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org F018F60A260B Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=qcyNSOiL Received: by mail-dy1-f179.google.com with SMTP id 5a478bee46e88-35c76e9614aso2709216eec.0 for ; Thu, 29 Oct 2026 02:02:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20260707; t=1793264545; x=1793869345; darn=lists.linux.dev; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Em6bj94swsrfUrSQCXEn0xceZl+9/C90nnaFaaRvExo=; b=qcyNSOiLbtwhCBs2CTMoCdSqska6I/ZCmWpl+g7gZ0nguh0pq3qF1/3pcpuYg20/am zslM7IsgYgH3ouw29yxzLOaFUUonUFNP579PAl4HfdP5Cbwk8FakDE4D0gb7Wq6SmNdB HsGp/FoqAqoGtcOap9OLKLK4+usMWcH3DV4h5buvb7+uSw3jRdZ/aY7WyADgHWPhHYl9 68TVEZjWHT+Nn4CdQ2iqbuThGMQaq2hUdSb5W2PCC2NzdqKFtd1Ygei6phgttApexLLn wt+R1SsJLl2fAk4WsnCV2d2WtGx2UlSfChrtEwInZhW0PogfBoskZFWl/Mi4PAnFVQRa b0bA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1793264545; x=1793869345; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=Em6bj94swsrfUrSQCXEn0xceZl+9/C90nnaFaaRvExo=; b=Y0pJrWU4RNvE+jYwCzQhdFmWoT60nOJIEllu2UvfJmEN03q/zmvIys4BowGRwehYFn E2Y4ALZgP2nqOFzFBzxyhOzV1NpMRd+GchCzckzTox4Jhfvnx8VIwTU39g6hm6bCPHIl 7gWsUK511b6+8vN4ohqH5O/GaG/Klp6wDskFqN3iYrBLYVdt705074beYCxfY9BlZkCI nkmoiToy5hqgguOpW8+GhHxf+5qbQZN3XUeX3+VdRx2T0GjuJawnuVPPAc4koAkS9Qdt K/VtDjAqfoSu1UaI/B3BGV26MTYPJbZLGXYO3SHYjTM9s/qOkkIfldTA/ip3DVCewDMH vEkQ== X-Forwarded-Encrypted: i=1; AKwUvBzxhaFVOThA1e66n+W1Ej/WSsgmo3MevvOm1pylBfwEsl2kYhdEX1aNyXQBcAduAKqTZmwoqQ==@lists.linux.dev X-Gm-Message-State: AFq9FYJ1jwh87bK3j85cI0B6SnkxPfrP6ZNCkM1rq/WwZas+PprJM+sF zpeFJQ5/GlYpO5+EA+5lY8LO/Tf0mVujby49rE6GisyaDUCVZqQQA5U= X-Gm-Gg: AYBFou3tqHkN+8BFRRZVXMS4wBfPkAIs5YXSma37VEa1Iga7sueW37FlWHKJP7D9PPh IympLIVojaO8AbJEFEIKZB7OD2/Ce2gjqa2pHPAoSX1YyRIP4rLHamW2uXAYuUwzIo83kSOSPOU 92SBQj5gw3+8EKMk3jARQ5VxXYN4RBry+oM6KmMijsbsV7rwvXxKM5k8Qb2tSVVKuTUVj0MOaO9 D8o8CledTLXdbQpXWnP5Yuv/CET513YTXdiyF4rcqE749zlN/3rn66c5u3T9H/L6pp/f94La6r4 afTfL6ilzxzwEBu3rrPkGvlnRd6lZ/WOwMgxcST+NvgflaalkyBcleqWiyjE1o/ojhlNTV4Y3Wh wlNXJhbcZ27xbVL3QZFUi7U4sm5QiVPT5ikOrUpRYHGQ6QlykjOHEm9kVpoSW8n9+m2Y8nkcl3k RM5ia2TQiyCJmKcPO0+iTC46cSMu3qUX6qlCBZZzNctcOU7gDsELMMnBNLULf79SzxFTC0Sxj5M vLfypMSK/FSI+4Dbd4Bzu8vSduCHj6G8sTki7T8H0RSxcGOEXYG57qYPwhjU+mEEGgTMx0yUJuk 1MwtFeAcKJ5o9FGlwQ4i69WYJHZGuI7x96+h1PUDh1JUDyIBh7NUQvKm3NJd3fhhDo2hIfDmF+c JxUTqCW4= X-Received: by 2002:a05:7300:7312:b0:358:ec5c:bef1 with SMTP id 5a478bee46e88-36a204773c0mr9949917eec.39.1793264544951; Thu, 29 Oct 2026 02:02:24 -0700 (PDT) Received: from at-Standard-PC-Q35-ICH9-2009 ([27.60.20.232]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-36a23641e78sm16497937eec.0.2026.10.29.02.02.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Oct 2026 02:02:24 -0700 (PDT) From: Atharva Tiwari To: Cc: Atharva Tiwari , Bjorn Helgaas , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , "Rafael J. Wysocki" , Len Brown , Linus Walleij , Bartosz Golaszewski , Sven Peter , Janne Grunau , Neal Gompa , Guenter Roeck , Jonathan Cameron , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , Lee Jones , Pavel Machek , Griffin Kroah-Hartman , Hans de Goede , =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= , Sebastian Reichel , Alexandre Belloni , Wim Van Sebroeck , Jarkko Sakkinen , Mimi Zohar , Roberto Sassu , Dmitry Kasatkin , Eric Snowberg , Paul Moore , James Morris , "Serge E. Hallyn" , linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-acpi@vger.kernel.org, linux-gpio@vger.kernel.org, asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-hwmon@vger.kernel.org, linux-iio@vger.kernel.org, linux-leds@vger.kernel.org, mfd@lists.linux.dev, platform-driver-x86@vger.kernel.org, linux-pm@vger.kernel.org, linux-rtc@vger.kernel.org, linux-watchdog@vger.kernel.org, linux-integrity@vger.kernel.org, keyrings@vger.kernel.org, linux-security-module@vger.kernel.org Subject: [RFC PATCH 14/14] mfd/macsmc: add ioctl to access smc keys Date: Thu, 29 Oct 2026 04:52:11 -0400 Message-ID: <20261029085504.3547-15-atharvatiwarilinuxdev@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20261029085504.3547-1-atharvatiwarilinuxdev@gmail.com> References: <20261029085504.3547-1-atharvatiwarilinuxdev@gmail.com> X-Mailing-List: asahi@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add a /dev/smc device so userspace can talk to the SMC directly. Some keys that need to be written aren't handled by any driver, or affect several drivers at once, so they can't be exposed cleanly through the kernel interfaces. Keys already managed by kernel drivers can't be written this way, to avoid conflicts. Signed-off-by: Atharva Tiwari --- drivers/mfd/macsmc-core.c | 155 +++++++++++++++++++++++++++++++++++++ include/linux/mfd/macsmc.h | 27 +++++++ 2 files changed, 182 insertions(+) diff --git a/drivers/mfd/macsmc-core.c b/drivers/mfd/macsmc-core.c index bc4200f57..a30f7386e 100644 --- a/drivers/mfd/macsmc-core.c +++ b/drivers/mfd/macsmc-core.c @@ -6,10 +6,13 @@ #include #include +#include #include #include +#include #include #include +#include static const struct mfd_cell apple_smc_rtkit_devs[] = { MFD_CELL_NAME("macsmc-input"), @@ -112,6 +115,144 @@ static void apple_smc_disable_notifications(void *data) smc->be->disable_notifications(smc->be_cookie); } +static long apple_smc_fops_ioctl(struct file *file, unsigned int cmd, unsigned long arg) +{ + struct apple_smc *smc = file->private_data; + void __user *argp = (void __user *)arg; + int ret; + + switch (cmd) { + case IOCTL_SMC_READ: { + struct ioctl_smc_rw_payload payload; + struct apple_smc_key_info info; + + if (copy_from_user(&payload, argp, sizeof(payload))) + return -EFAULT; + + ret = apple_smc_get_key_info(smc, payload.key, &info); + if (ret < 0) + return ret; + + if (payload.size != info.size) + return -EINVAL; + + if (payload.size > 32) + return -EINVAL; + + ret = apple_smc_read(smc, payload.key, payload.buf, payload.size); + if (ret < 0) + return ret; + + if (copy_to_user(argp, &payload, sizeof(payload))) + return -EFAULT; + return 0; + } + case IOCTL_SMC_WRITE: { + struct ioctl_smc_rw_payload payload; + struct apple_smc_key_info info; + + if (copy_from_user(&payload, argp, sizeof(payload))) + return -EFAULT; + + ret = apple_smc_get_key_info(smc, payload.key, &info); + if (ret < 0) + return ret; + + if (payload.size != info.size) + return -EINVAL; + + if (payload.size > 32) + return -EINVAL; + + switch (payload.key) { + case __SMC_KEY('C', 'H', '0', 'I'): + case __SMC_KEY('C', 'H', '0', 'C'): + case __SMC_KEY('C', 'H', '0', 'K'): + case __SMC_KEY('C', 'H', '0', 'B'): + case __SMC_KEY('C', 'H', 'T', 'E'): + case __SMC_KEY('C', 'H', 'L', 'S'): + case __SMC_KEY('B', 'C', 'L', 'M'): + case __SMC_KEY('M', 'B', 'S', 'E'): + case __SMC_KEY('C', 'L', 'K', 'L'): + case __SMC_KEY('C', 'L', 'K', 'O'): + case __SMC_KEY('O', 'S', 'W', 'D'): + case __SMC_KEY('N', 'A', 'T', 'J'): + case __SMC_KEY('N', 'A', 'T', 'i'): + case __SMC_KEY('N', 'E', 'S', 'N'): + case __SMC_KEY('M', 'O', 'C', 'N'): + case __SMC_KEY('L', 'K', 'S', 'B'): + case __SMC_KEY('N', 'T', 'O', 'K'): + case __SMC_KEY('N', 'T', 'A', 'P'): + case __SMC_KEY('F', '0', 'T', 'g'): + case __SMC_KEY('F', '1', 'T', 'g'): + case __SMC_KEY('F', '0', 'M', 'd'): + case __SMC_KEY('F', '1', 'M', 'd'): + case __SMC_KEY('F', 'S', '!', ' '): + return -EPERM; + } + + ret = apple_smc_write(smc, payload.key, payload.buf, payload.size); + if (ret < 0) + return ret; + + return 0; + } + case IOCTL_SMC_GET_KEY_INDEX: { + struct ioctl_smc_index_payload payload; + + if (copy_from_user(&payload, argp, sizeof(payload))) + return -EFAULT; + + ret = apple_smc_get_key_by_index(smc, payload.index, &payload.key); + if (ret < 0) + return ret; + + if (copy_to_user(argp, &payload, sizeof(payload))) + return -EFAULT; + + return 0; + } + case IOCTL_SMC_GET_KEY_INFO: { + struct ioctl_smc_info_payload payload; + + if (copy_from_user(&payload, argp, sizeof(payload))) + return -EFAULT; + + ret = apple_smc_get_key_info(smc, payload.key, &payload.info); + if (ret < 0) + return ret; + + if (copy_to_user(argp, &payload, sizeof(payload))) + return -EFAULT; + + return 0; + } + default: + return -EINVAL; + } +} + +static int apple_smc_fops_open(struct inode *inode, struct file *file) +{ + struct miscdevice *misc = file->private_data; + + file->private_data = container_of(misc, struct apple_smc, miscdev); + return 0; +} + +static const struct file_operations apple_smc_fops = { + .owner = THIS_MODULE, + .open = apple_smc_fops_open, + .unlocked_ioctl = apple_smc_fops_ioctl, + .compat_ioctl = compat_ptr_ioctl, + .llseek = noop_llseek, +}; + +static void apple_smc_misc_unregister(void *data) +{ + misc_deregister(data); +} + int apple_smc_probe(struct device *dev, const struct apple_smc_backend_ops *ops, void *cookie, struct blocking_notifier_head *event_handlers, bool is_acpi) { @@ -150,6 +291,20 @@ int apple_smc_probe(struct device *dev, const struct apple_smc_backend_ops *ops, if (ret) return ret; + smc->miscdev.minor = MISC_DYNAMIC_MINOR; + smc->miscdev.name = "smc"; + smc->miscdev.fops = &apple_smc_fops; + smc->miscdev.parent = dev; + smc->miscdev.mode = 0600; + + ret = misc_register(&smc->miscdev); + if (ret) + return ret; + + ret = devm_add_action_or_reset(dev, apple_smc_misc_unregister, &smc->miscdev); + if (ret) + return ret; + if (smc->is_acpi) { ret = devm_mfd_add_devices(dev, -1, apple_smc_acpi_common, ARRAY_SIZE(apple_smc_acpi_common), NULL, 0, NULL); diff --git a/include/linux/mfd/macsmc.h b/include/linux/mfd/macsmc.h index 4b4368b99..29fd7b20c 100644 --- a/include/linux/mfd/macsmc.h +++ b/include/linux/mfd/macsmc.h @@ -8,6 +8,8 @@ #ifndef _LINUX_MFD_MACSMC_H #define _LINUX_MFD_MACSMC_H +#include +#include #include /** @@ -125,6 +127,7 @@ struct apple_smc_backend_ops { * @is_acpi: Is the backend ACPI based * @mutex: Mutex for non-atomic mode * @lock: Spinlock for atomic mode + * @miscdev: Misc Device struct for ioctl ops */ struct apple_smc { struct device *dev; @@ -141,8 +144,32 @@ struct apple_smc { struct mutex mutex; spinlock_t lock; + + struct miscdevice miscdev; +}; + +struct ioctl_smc_rw_payload { + smc_key key; + size_t size; + u8 buf[32]; +}; + +struct ioctl_smc_index_payload { + int index; + smc_key key; +}; + +struct ioctl_smc_info_payload { + smc_key key; + struct apple_smc_key_info info; }; +#define APPLE_SMC_MAGIC 'S' +#define IOCTL_SMC_READ _IOWR(APPLE_SMC_MAGIC, 1, struct ioctl_smc_rw_payload) +#define IOCTL_SMC_WRITE _IOW(APPLE_SMC_MAGIC, 2, struct ioctl_smc_rw_payload) +#define IOCTL_SMC_GET_KEY_INDEX _IOWR(APPLE_SMC_MAGIC, 3, struct ioctl_smc_index_payload) +#define IOCTL_SMC_GET_KEY_INFO _IOWR(APPLE_SMC_MAGIC, 4, struct ioctl_smc_info_payload) + /** * apple_smc_read - Read size bytes from given SMC key into buf * @smc: Pointer to apple_smc struct -- 2.55.0