From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=74.125.82.173 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793264328; b=3sFIJMriOi2ZixIOQkizyTLUlC3GaVJd7iWZPhn5ZXR+nSTQTR9liZ8Sm5Bk9ndGDr3f dgDrZd6qM46zVfPswRZBdV4IOJD3JtuUC0Y3gZrPP9iGiBsK8QY3+VSJ1hNRaLPbk/kaV oV47luDZS7TsNXw0znV5AgZMygdxkQdJnrWGetXXK1FOfPSDZRZJlj8dM487Hwp4Rzb7R a+orU1r6GrKcPcH9O47jwjp7VVSsImtBmlxGJu/vBR3nLE3WWRjn3GtAoXFRhpAmQGd0d duVrFVdpJJ69HYQNCdrMWrgTK93DdpC9zyhKB+r9awmSd90hHFmnM5+YAXknU/03e+Q== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793264328; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: From:To:Cc:Subject:Date:Message-ID:X-Mailer:In-Reply-To:References: MIME-Version:Content-Transfer-Encoding; bh=MA1va5T9XE5xJNcHi+mBsnQRuzOaQ1MDpEcJoNwX+FE=; b=GKcIcRddM9Psa6oOutzkvoIoEMNXxmMfHT30HlICcBBFnTI+57/RJKZGQdCrhA3HtMgD 3qYwHXKh2mzZtbLVPphzuZQegNqxkLnwTjTjo69vKeTx9cWexfA3SdiUrTYE9ElYfNqDX mPJvF7U60+XT6JNJToG8/FYAC4jqRKUboARaeEyoFAaQB2pdrWqHYZADruJ1DPEj1hpmj g3V8+cVX1wgZinj+7bqrD8riqOG0hPgGvxP58GFzUWLa8MB9ir8vQFfvu92e/CY4jm0WS 30pMcbnTBnOXvfESziweCWxZw6yyCeUX2bvjl8UVzSMzqS2eUylMhMxXKm5pgkjnjrg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=DGJMzKjf; arc=none smtp.remote-ip=74.125.82.173 Received: from mail-dy1-f173.google.com (mail-dy1-f173.google.com [74.125.82.173]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3D05C606A322 for ; Thu, 29 Oct 2026 08:58:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 3D05C606A322 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=DGJMzKjf Received: by mail-dy1-f173.google.com with SMTP id 5a478bee46e88-33fb4680717so813243eec.1 for ; Thu, 29 Oct 2026 01:58:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20260707; t=1793264327; x=1793869127; darn=lists.linux.dev; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=MA1va5T9XE5xJNcHi+mBsnQRuzOaQ1MDpEcJoNwX+FE=; b=DGJMzKjf5czlcX93tUZBvefEHvgGn6iFjVK1vkH3oBvbBFGEXgwhzDHYsakcM4Vi1+ bdb+RY9EUAjMMplxCpV4zKp3Ut8RIJYtRIG7MK9hFH4FnhhfISi/diMtD6rU2Nkzgl6k 4CqRN8fX0rLtcRxP05/npFKmx1q/4LnPKlDqaIHqMAhAHNNm0FnZFz3aUzvTQ1Xigchl IOkl/qECaBsUpSMQ8mpay5du+wffSsOFeH3IdGa33ZO8iGMUl+DioRUMm4bd/BAlvb/n McWPXPiAWfeDiNO781w92Ulr5YjIiKOi2YhxGdTCiyz4+MU65oTQed4ZnxOMW1xroRUC Tphw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1793264327; x=1793869127; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=MA1va5T9XE5xJNcHi+mBsnQRuzOaQ1MDpEcJoNwX+FE=; b=cX/cxtMEzET6ry6EnWg4106hEDpSb4hE9aoV1tmgHv8xPRYlp/3sG15G8AVYpq5C4I R1b4bZdfZ799bNurz/1sT1H1PR8q/++Oa42/+Y0Az/EiAdhGLtZuLsUYyhbNgd6Mc6cZ ECEBJecLr1XXGGmhRLoZ3Hf8BP0N0uT7xGfMMiBZvnrluAqwCea4DNtiMrA4NPQusILJ ix4Bd/aNVZAgDD4nGoRWHOFmBBFe/0PSlrmlkuoREpUjY162NmF7aQra9VfhM4YbalH2 g4Csu0KNar4BCi3SrsLaLoCU972pAWkjpOR8DfxdmHvULqxt3J11M+TMvmm5oF8hWzrC m3Qw== X-Forwarded-Encrypted: i=1; AKwUvBxMaBeSt0neoprN1oMrx052Tbknd5o9Eof5NlbSM2xz4/belS7o0FUXBfY3at5eQmxFBgBEJA==@lists.linux.dev X-Gm-Message-State: AFq9FYI/ivzhVtGoUlkQ2zgby3pthDNlVwKR0yQgRkOJn/WaKAhLS4mJ Xy0xbljBmA6BQbh8FrPhLIM35cTcDOU7kEGVmdenumkXDt4qLAKviIQ= X-Gm-Gg: AYBFou0Zv0Hllwiod45BOEGp5dShcHjMwjprY74PhT7Mc/xOl7XdrG3SnFKGLzqMpLY eljWFCsek/hXgzEQsfEYNNKEAAvAfbeTa74RB1w0ZogLeG57uj481FNtNzWMfNqxJw8MKC5xIuv 2nTQi3Z9dcmKq69LtjNSNIi4OLoPD4Hq0/Au2JGpBXf0e478UQyAkGtFNArjOedDWV848DjmJB9 nJZD/MIzuMQmwGyi63b7Q6f70QThntG/PyyiqV+QxloG6nKCwBoutYN7YoYepxAFCfJa+BdlhZW fgpFBVvpUjgs7vHBi50sTYPQthQD+9LOIhGNHi5sOoaBVa0LB/CKxv8nXH04l6kHAO06R04Hy+2 yA8Ygs0+//qjdIxk50Jpb0FG+hW6VYFiJQ8dmt7howEZcOKAkCfnVvBNmNzll2KuwIawiRcsIqI Z+kuf7cZrs1ebFsaue9zSMSFF8h8Z76KZ1TkzMh+pLTd4lFVmEZwwGBqnYK4COeDjjre97glODp I2p5Vl9sl0rz14qL81D4IMyUy1PUfgu0ApfaCJw5uekAxQ81IbitGSl9RCfMznsgb3KnWTekCBp hH2TBs1sb2zE5MAFE4+YOijGYoLC7+tvekqGJ/JeptsuQV/Uz4Cdkr6mPKrMfPR21yWYnVDyAzX KPDHL5djn X-Received: by 2002:a05:693c:2411:b0:359:9302:a526 with SMTP id 5a478bee46e88-36a203ad100mr6959524eec.7.1793264327087; Thu, 29 Oct 2026 01:58:47 -0700 (PDT) Received: from at-Standard-PC-Q35-ICH9-2009 ([27.60.20.232]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-36a23641e78sm16497937eec.0.2026.10.29.01.58.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Oct 2026 01:58:46 -0700 (PDT) From: Atharva Tiwari To: Cc: Atharva Tiwari , Bjorn Helgaas , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , "Rafael J. Wysocki" , Len Brown , Linus Walleij , Bartosz Golaszewski , Sven Peter , Janne Grunau , Neal Gompa , Guenter Roeck , Jonathan Cameron , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , Lee Jones , Pavel Machek , Griffin Kroah-Hartman , Hans de Goede , =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= , Sebastian Reichel , Alexandre Belloni , Wim Van Sebroeck , Jarkko Sakkinen , Mimi Zohar , Roberto Sassu , Dmitry Kasatkin , Eric Snowberg , Paul Moore , James Morris , "Serge E. Hallyn" , linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-acpi@vger.kernel.org, linux-gpio@vger.kernel.org, asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-hwmon@vger.kernel.org, linux-iio@vger.kernel.org, linux-leds@vger.kernel.org, mfd@lists.linux.dev, platform-driver-x86@vger.kernel.org, linux-pm@vger.kernel.org, linux-rtc@vger.kernel.org, linux-watchdog@vger.kernel.org, linux-integrity@vger.kernel.org, keyrings@vger.kernel.org, linux-security-module@vger.kernel.org Subject: [RFC PATCH 06/14] leds: add support for macsmc kbl Date: Thu, 29 Oct 2026 04:52:03 -0400 Message-ID: <20261029085504.3547-7-atharvatiwarilinuxdev@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20261029085504.3547-1-atharvatiwarilinuxdev@gmail.com> References: <20261029085504.3547-1-atharvatiwarilinuxdev@gmail.com> X-Mailing-List: asahi@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add a LED class driver to control the keyboard backlight. This replaces the keyboard backlight support in applesmc. Signed-off-by: Atharva Tiwari --- drivers/leds/Kconfig | 11 ++++++ drivers/leds/Makefile | 1 + drivers/leds/leds-macsmc.c | 69 ++++++++++++++++++++++++++++++++++++++ drivers/mfd/macsmc-core.c | 11 ++++++ 4 files changed, 92 insertions(+) create mode 100644 drivers/leds/leds-macsmc.c diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig index 7ec2c8d78..30cd64d41 100644 --- a/drivers/leds/Kconfig +++ b/drivers/leds/Kconfig @@ -729,6 +729,17 @@ config LEDS_ADP5520 To compile this driver as a module, choose M here: the module will be called leds-adp5520. +config LEDS_MACSMC + tristate "Keyboard Backlight support for Intel-Macs" + depends on LEDS_CLASS + depends on MACSMC_ACPI + help + This option enables support for the Keyboard backlight in + Intel-Macs using macsmc. + + To compile this driver as a module, choose M here: the module will + be called leds-macsmc. + config LEDS_MAX5970 tristate "LED Support for Maxim 5970" depends on LEDS_CLASS diff --git a/drivers/leds/Makefile b/drivers/leds/Makefile index 4d4b08915..7c38dbef4 100644 --- a/drivers/leds/Makefile +++ b/drivers/leds/Makefile @@ -12,6 +12,7 @@ obj-$(CONFIG_LEDS_KUNIT_TEST) += led-test.o obj-$(CONFIG_LEDS_88PM860X) += leds-88pm860x.o obj-$(CONFIG_LEDS_ACER_A500) += leds-acer-a500.o obj-$(CONFIG_LEDS_ADP5520) += leds-adp5520.o +obj-$(CONFIG_LEDS_MACSMC) += leds-macsmc.o obj-$(CONFIG_LEDS_AN30259A) += leds-an30259a.o obj-$(CONFIG_LEDS_APU) += leds-apu.o obj-$(CONFIG_LEDS_ARIEL) += leds-ariel.o diff --git a/drivers/leds/leds-macsmc.c b/drivers/leds/leds-macsmc.c new file mode 100644 index 000000000..f38ef2113 --- /dev/null +++ b/drivers/leds/leds-macsmc.c @@ -0,0 +1,69 @@ +// SPDX-License-Identifier: GPL-2.0 OR MIT +/* + * Apple SMC Keyboard backlight driver + * + * Copyright (C) 2026 Atharva Tiwari + * + * Based on drivers/hwmon/applesmc.c + * Copyright (C) 2007 Nicolas Boichat + * Copyright (C) 2010 Henrik Rydberg + * + */ + +#include +#include +#include + +struct macsmc_led { + struct led_classdev cdev; + struct apple_smc *smc; + u8 brightness; +}; + +static enum led_brightness macsmc_led_get_brightness(struct led_classdev *cdev) +{ + struct macsmc_led *drv = container_of(cdev, struct macsmc_led, cdev); + + return drv->brightness; +} + +static void macsmc_led_set_brightness(struct led_classdev *cdev, enum led_brightness value) +{ + struct macsmc_led *drv = container_of(cdev, struct macsmc_led, cdev); + + drv->brightness = (u8) value; + + apple_smc_write_u16(drv->smc, SMC_KEY(LKSB), drv->brightness); +} + +static int macsmc_led_probe(struct platform_device *pdev) +{ + struct macsmc_led *drv; + + drv = devm_kzalloc(&pdev->dev, sizeof(*drv), GFP_KERNEL); + if (!drv) + return -ENOMEM; + + drv->smc = dev_get_drvdata(pdev->dev.parent); + + drv->cdev.name = "macsmc-led"; + drv->cdev.max_brightness = 255; + drv->cdev.brightness_get = macsmc_led_get_brightness; + drv->cdev.brightness_set = macsmc_led_set_brightness; + drv->cdev.dev = &pdev->dev; + + return devm_led_classdev_register(&pdev->dev, &drv->cdev); +} + +static struct platform_driver macsmc_led_driver = { + .probe = macsmc_led_probe, + .driver = { + .name = "macsmc-led", + }, +}; +module_platform_driver(macsmc_led_driver); + +MODULE_AUTHOR("Atharva Tiwari "); +MODULE_DESCRIPTION("LED keyboard backlight driver for Intel-macs using macsmc"); +MODULE_LICENSE("Dual MIT/GPL"); +MODULE_ALIAS("platform:macsmc-led"); diff --git a/drivers/mfd/macsmc-core.c b/drivers/mfd/macsmc-core.c index 6567d2f1f..bc4200f57 100644 --- a/drivers/mfd/macsmc-core.c +++ b/drivers/mfd/macsmc-core.c @@ -33,6 +33,10 @@ static const struct mfd_cell apple_smc_acpi_common[] = { MFD_CELL_NAME("macsmc-power"), }; +static const struct mfd_cell apple_smc_acpi_led[] = { + MFD_CELL_NAME("macsmc-led"), +}; + static const struct mfd_cell apple_smc_acpi_light[] = { MFD_CELL_NAME("macsmc-light"), }; @@ -179,6 +183,13 @@ int apple_smc_probe(struct device *dev, const struct apple_smc_backend_ops *ops, if (ret < 0) return ret; } + + if (apple_smc_key_exists(smc, SMC_KEY(LKSB))) { + ret = devm_mfd_add_devices(dev, -1, apple_smc_acpi_led, + ARRAY_SIZE(apple_smc_acpi_led), NULL, 0, NULL); + if (ret < 0) + return ret; + } } else ret = devm_mfd_add_devices(dev, -1, apple_smc_rtkit_devs, ARRAY_SIZE(apple_smc_rtkit_devs), NULL, 0, NULL); -- 2.55.0