From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=91.216.248.207 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794398585; b=Jt/+Rfm2RXeIBmeg5g6sbSD+w6Pi2TqMjogt7xQJBoHHMj8ZbgKrne1lm46V3Wd56+C1 CafuxTnZCodZTJE6pn5rCZrFNjx6XZnPgh2GjaRYSfoyxRmoDh2hvbp2FXYqbujeBQuw8 wRzK/4jLnNheprG7LpPEhntMybGVf/BCTD9EbXohNq5lB9rUKBchoYPTgN4S+Qt086TAF 3WCb8PXGZHer5CeAMQL0yndO27c0pDw1Fo4OLq1AqC0uDl7A3dQMug9Ffr6TQlg7U+QEL 6EQRI7nxrcgBky4zJE+P1d/JdLUR8sQSqg7OV7ztI4wdLWocx09Axgt4eIKchdMDQag== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794398585; h=DMARC-Filter:From:DKIM-Signature:To:Cc:Subject:Date:Message-ID: X-Mailer:In-Reply-To:References:MIME-Version: Content-Transfer-Encoding; bh=GU1rR6DOyFxE66mLliEw1hVk/Ddk8r/dNCEfmv4kUDw=; b=sjbgVh1R8E1v2Gks+3FezvcX4ukfxL99PAeKI5ueJkQzEYsvJ1OfuBop1rM852rBdYKa yQv6qNNdlzTcBxdkd00d3v/M1UVDiq62Qf9TUwz5/u/asIgaHHvJh3DOOQ1dohicsojyG A1v3aa+1gfYTdD/OSGWruSX2HXPaS3X7HTMPDNmalEKZbY7d0NwIHL+TCyTUHxxCA72/a QmZQBr7no2wZm62zmxQwQ21VtRmoLnWpiLntzZq5Xgn73GmYy++iqawt7RueioCVV3ziI 2fgxL3RKWAb/oBoFQHTxRyudIc5OX28J4zaQdjMd2oelKCHAEzNhG6jp5eOv0udxMRw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none header.from=deq.rocks; spf=none smtp.mailfrom=deq.rocks; dkim=pass header.d=deq.rocks header.i=@deq.rocks header.a=rsa-sha256 header.s=securedbylima-20251205 header.b=JbpPxQlk; arc=none smtp.remote-ip=91.216.248.207 Received: from mx5.mail-out.lima-city.de (mx5.mail-out.lima-city.de [91.216.248.207]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 59399606B60D for ; Wed, 11 Nov 2026 12:03:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 59399606B60D Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=deq.rocks Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=deq.rocks Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=deq.rocks header.i=@deq.rocks header.a=rsa-sha256 header.s=securedbylima-20251205 header.b=JbpPxQlk From: Andre Eikmeyer DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=deq.rocks; s=securedbylima-20251205; t=1794398575; bh=yawQ4E02fUTwAlaYm0llbngJGLthGeeE2ZDGDd72jJM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=JbpPxQlkys15RVAJz3GjgfOx3YBNrGh80v6rH8HnDaHjqxID5IuXUqB6zQ2vd660j jGtbdlcNKFhOb6V386Wy4c5KKcrd9ELSJEtC4U3VFdWt0cVYVndEibYWDXyuw3BNqM 8mrUTHkB41bMQoshQjFj9YYORvHnoDQqGK2fLAqC1xV8Et/xjDJVpQzs0h9Y4crNUY PpPoKx4x8qjr2Ir2D7x2fvUAgLm/QwneO44IZFkoLJLEH7Hq9H9Q///wtWMrUO4ASR kvYiPjMvCAsyNOjU4cBeqdkuZhIL3pjcCPt6OgpdH2E8FEZeyHUUiSWy7tJto7VTSL CiCz4Be2+tXBg== To: sven@kernel.org, marcel@holtmann.org, luiz.dentz@gmail.com Cc: j@jannau.net, neal@gompa.dev, asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org, Andre Eikmeyer Subject: [PATCH v2 1/3] Bluetooth: hci_bcm4377: treat only negative hci_register_dev() returns as errors Date: Wed, 11 Nov 2026 13:02:46 +0100 Message-ID: <20261111120248.21062-2-dev@deq.rocks> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261111120248.21062-1-dev@deq.rocks> References: <20261111120248.21062-1-dev@deq.rocks> X-Mailing-List: asahi@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit If another controller already holds hci0, a USB Bluetooth dongle for example, the BCM4377 is registered as hci1 and probe returns 1. The PCI core takes that as success, but the devm action that unregisters the controller is never added, so it stays registered after unbind while its driver data is freed. hci_register_dev() returns the index of the new controller on success. Check for a negative return, as the other drivers do. Fixes: 8a06127602de ("Bluetooth: hci_bcm4377: Add new driver for BCM4377 PCIe boards") Signed-off-by: Andre Eikmeyer --- drivers/bluetooth/hci_bcm4377.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/bluetooth/hci_bcm4377.c b/drivers/bluetooth/hci_bcm4377.c index 66d49b47154..da0a48c2be3 100644 --- a/drivers/bluetooth/hci_bcm4377.c +++ b/drivers/bluetooth/hci_bcm4377.c @@ -2410,7 +2410,7 @@ static int bcm4377_probe(struct pci_dev *pdev, const struct pci_device_id *id) return ret; ret = hci_register_dev(hdev); - if (ret) + if (ret < 0) return ret; return devm_add_action_or_reset(&pdev->dev, bcm4377_hci_unregister_dev, hdev);