From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id CDBCF20DD71 for ; Thu, 12 Dec 2024 11:09:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734001744; cv=none; b=ef894jaLl4VYDoO7Y9E/ksMrcOmUwxvM0DuU0wr2Pn8cft51DTatdELXQH4Ob4xxlnCkBmTZA7E5p/EEFisbWoSAe7u/OlyluXPOGDQFg8Tzljn3i5V4KgqspnLrRqeHCqQLXsrqyiD+QlSqKif94EPZflm+UYfO+vKgnXEKdhk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734001744; c=relaxed/simple; bh=ZJDjwjbC1CKzMZcB6/ZePDOrO0Zf/UkPbY7IkUCpXH8=; h=Message-ID:Date:MIME-Version:Subject:From:To:References: In-Reply-To:Content-Type; b=Slco9bhPgz7/V3GabpPdmaACxdS6z+LAojCNaNZzfVgXFakFftxa+I5ZCUd/PoiAyLXvj4LWH7M7lD4YZr3GmJHUUiQVv8dMff00nAa8emfsBDV2hsR/moiTf9n3hhP6c4yrvOqAUaGiLvTmAwkKm38XIwmL7suqWFWkzBQTzss= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 2F346153B; Thu, 12 Dec 2024 03:09:30 -0800 (PST) Received: from [10.1.37.59] (e127648.arm.com [10.1.37.59]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 504363F720; Thu, 12 Dec 2024 03:08:59 -0800 (PST) Message-ID: <2d262f80-81cf-4957-8d4d-ccb5f45e5d75@arm.com> Date: Thu, 12 Dec 2024 11:08:57 +0000 Precedence: bulk X-Mailing-List: asahi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 6/7] cpufreq: apple-soc: Set fallback transition latency to APPLE_DVFS_TRANSITION_TIMEOUT From: Christian Loehle To: Nick Chan , Hector Martin , Sven Peter , Alyssa Rosenzweig , "Rafael J . Wysocki" , Viresh Kumar , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Asahi Linux , Linux ARM Kernel Architecture , Linux power management , Devicetree , LKML References: <20241212070344.3858-1-towinchenmi@gmail.com> <20241212070344.3858-7-towinchenmi@gmail.com> Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 12/12/24 11:06, Christian Loehle wrote: > On 12/12/24 07:03, Nick Chan wrote: >> The driver already assumes transitions will not take longer than >> APPLE_DVFS_TRANSITION_TIMEOUT in apple_soc_cpufreq_set_target(), so it >> makes little sense to set CPUFREQ_ETERNAL as the transition latency >> when the transistion latency is not given by the opp-table. >> >> Signed-off-by: Nick Chan > > Reviewed-by: Christian Loehle > >> --- >> drivers/cpufreq/apple-soc-cpufreq.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/cpufreq/apple-soc-cpufreq.c b/drivers/cpufreq/apple-soc-cpufreq.c >> index 94e57f055a5f..c9f31a3653e2 100644 >> --- a/drivers/cpufreq/apple-soc-cpufreq.c >> +++ b/drivers/cpufreq/apple-soc-cpufreq.c >> @@ -291,7 +291,7 @@ static int apple_soc_cpufreq_init(struct cpufreq_policy *policy) >> >> transition_latency = dev_pm_opp_get_max_transition_latency(cpu_dev); >> if (!transition_latency) >> - transition_latency = CPUFREQ_ETERNAL; >> + transition_latency = APPLE_DVFS_TRANSITION_TIMEOUT * 1000; s/1000/NSEC_PER_USEC would have been the cleaner choice in case you respin. >> >> policy->cpuinfo.transition_latency = transition_latency; >> policy->dvfs_possible_from_any_cpu = true; > >