From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E62916A001 for ; Sat, 14 Mar 2026 02:32:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773455564; cv=none; b=fIfgfcZq64+xA8xsNQS2oZ1e/zTRp05UcmhrJicP6B2ynP+mgyCLloxXs0pMBdcVXB6ltOBZxwchjvqsuhQKXxVlDSC9iYY+tc8WELWypJPi5elb/EiBHnXU71up6QYV9r1n9OEVW4wS59DtcVYSHNFWsgif93RN3ZuYDQTd+44= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773455564; c=relaxed/simple; bh=VoXeC9IHasi/UAtluQskzXJbdOFysDaXJJx65ggrMMg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=IceeQ/PKyHnkeq+4S5fcFMLnmVzVyNOO4v1eogYzIimrbDyDBYxUdjjOldCR3AcADdgRA1XNiw2blEd09rU63t5Sa8I9ZRvvAcvDjMaiq3dxxsAUVn7rg7JxIKspE4wOVCs2Kid9B0qmZdlNOm4La8TmlB9N9UmKcmw3d+yBV2E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=HylEy45d; arc=none smtp.client-ip=209.85.214.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HylEy45d" Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-2adff872068so13271015ad.1 for ; Fri, 13 Mar 2026 19:32:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773455562; x=1774060362; darn=lists.linux.dev; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=QXws6LkfRc01I28IbH0KBFSnQLO6Cva5ehRLzaS0ijo=; b=HylEy45d7aMJ/juoHicCd8WBueNS9748F8SOU5nQdFW2ofXHYtTr/JClS5zuq56JUv 28bHMVfV19Qx0aUlKYssfK8NZTkFYAzYfshRZMq/N6ezcFcK4wG3EDg+5pSj2iqYvbb4 kzhZf/HtWbAUze/xt/xqYG3hIfDJ3U+A7eMrqxs50Qybd3u5ASSIj8Jf0GBJl7N1hTrb o7R6ZcwVl82f7DQh3ntgKd1FwIaAYwDIXvoeLJa1TrLYcbq4kidOohpXgA0/vGBeYvCU qKZgC2AVk/xgNAQ1lduz2sJz3KaseVzmwlDrrDwFPXGd6fD563quhAKe/gwCAPj/NWpk nBkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773455562; x=1774060362; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=QXws6LkfRc01I28IbH0KBFSnQLO6Cva5ehRLzaS0ijo=; b=pqqMw2Ye7L83dBAGxAPpYxkJovr3tTh61CTM2VgbeJMpRarzFzkFV0th/Ay38svJgp oUy1WE9rsK/KqFbHEcbcS7H30B8V8Nk8HVx6WfdZNq5ky5OqUlOu4VcXISFHTejRZJAo iR/TMGmL5ykO7m925BKEkATgFXxG8FKVibvoiMmIbH9A6T8U7Y+ZKzfmLY5fYQDG/p9X s7LMeXUYaYWkVRPYDcm/ZfboZjQCZxW+MbqSG+vr2PwLREKkfTAM/ixrwS2BddGpydHf Q84o9ft+GIc1b7rm28RNZyIO9tHF9WSIK7XrtN2DQLg81LR683oyz7z6xGi+ZfUig+lc Gz0g== X-Forwarded-Encrypted: i=1; AJvYcCXhHFg1WVaJFUSDyzhH7Sc2w7fCPeAAxGcOPsoETIyDmaffmC0w49FbkxFqXyQi92znRdGiGA==@lists.linux.dev X-Gm-Message-State: AOJu0YzD76CMaegoqnkCKEU58+75EemGtPdsWdSLR68yHYc4iORdrws2 9mja6+LS0NHqBF1BLvIMDr/5tjJ8y+iUpemAeCYM59v/D0PszXALQe2P X-Gm-Gg: ATEYQzzkBIFaEmawUdog0DgKgrTFmZJdjAcgLsZB/aZs4lT43EsqtL1Us3C3+z5BI/G DT1dXcFpZy/9BW8UImeMzfT4Hq0BVefreXtb3BFBGDP58Sfq1l/cfXMJKqrKcrKS5ULcTzlVOaf bCn7szwhT27PHGhXvw+JQlPaJXUU/2WwseJwJUKLQytVH3RD2CrvYC4LFuFv1/dR4vu+22uWEjC UPU5PJxViWqWyRGYudGxtWOAyJyF9yhEY1Ob1e3AohtjYVykjZqe/GNe3uQAqbRidZjykWPyC9Y vwWvaHCo3G5JDO/wLLkv6DeIV5voq5g776/L3uhlnORq+l2WFZAkEoWfXdXfFl18Z1Gv4Ou86rm pHRniclvO5XUmYazhHdoF5o6mBUtgHEIj8RXk84tZ3lJZRGvznyvXB2BWnx6ckvnvInj1TjH9zZ kanBJ45iYYpuqIyQnmTiAAY53jOxg7JcAf9GYvyNfmknjmRJjNuRCKWE2sQIiOLW0+mNOy7H4Na o/OZ1S41P9SPbPtNH3h2rnZB17fttXA/Xh2t5eVeForPPuWC/Xek1vYxis6tdO2vqLuZiCBxuXp wcIhv+Z2sPnAIw== X-Received: by 2002:a17:903:28f:b0:2ad:edc4:1796 with SMTP id d9443c01a7336-2aecaa4d681mr54393645ad.39.1773455562268; Fri, 13 Mar 2026 19:32:42 -0700 (PDT) Received: from setsuna.localnet ([2403:581e:d87e:0:fc2d:ed31:e80e:412d]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2aece8093casm35373165ad.61.2026.03.13.19.32.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Mar 2026 19:32:41 -0700 (PDT) From: James Calligeros To: Mark Brown Cc: Liam Girdwood , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Kuninori Morimoto , Shengjiu Wang , Jaroslav Kysela , Takashi Iwai , Shenghao Ding , Kevin Lu , Baojun Xu , Frank Li , linux-sound@vger.kernel.org, devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, asahi@lists.linux.dev Subject: Re: [PATCH v3 7/7] ASoC: tas2770: expose SDOUT bus keeper via set_tdm_idle Date: Sat, 14 Mar 2026 12:32:26 +1000 Message-ID: <5796105.LvFx2qVVIh@setsuna> In-Reply-To: <6a3cc78a-77bc-473e-bfbf-caffbe8f25bb@sirena.org.uk> References: <20260301-tdm-idle-slots-v3-0-c6ac5351489a@gmail.com> <20260301-tdm-idle-slots-v3-7-c6ac5351489a@gmail.com> <6a3cc78a-77bc-473e-bfbf-caffbe8f25bb@sirena.org.uk> Precedence: bulk X-Mailing-List: asahi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" On Friday, 13 March 2026 12:33:05=E2=80=AFam Australian Eastern Standard Ti= me Mark Brown wrote: > On Sun, Mar 01, 2026 at 06:05:26PM +1000, James Calligeros wrote: > > +static int tas2770_set_dai_tdm_idle(struct snd_soc_dai *dai, > > + unsigned int tx_mask, > > + unsigned int rx_mask, > > + int tx_mode, int rx_mode) > > +{ > >=20 > > + switch (tx_mode) { > > + case SND_SOC_DAI_TDM_IDLE_PULLDOWN: > > + ret =3D snd_soc_component_update_bits(component, TAS2770_DIN_PD, > > + TAS2770_DIN_PD_SDOUT, > > + TAS2770_DIN_PD_SDOUT); > > + if (ret) > > + return ret; > > + > > + break; >=20 > This and all the other cases only updates the bits it's specifically > setting for the mode, so _ZERO and _HIZ don't update the pull and this > doesn't update the _KEEP/_FILL settings. Not sure how often anyone is > going to change this at runtime though. I didn't notice any side effects caused by not explicitly turning off the weak pulldown, but it makes sense to do if the consumer has asked for a mode that is not pulldown. > > + case SND_SOC_DAI_TDM_IDLE_OFF: > > + ret =3D snd_soc_component_update_bits(component, TAS2770_DIN_PD, > > + TAS2770_DIN_PD_SDOUT, 0); > > + if (ret) > > + return ret; > > + > > + ret =3D snd_soc_component_update_bits(component, TAS2770_TDM_CFG_REG= 4, > > + TAS2770_TDM_CFG_REG4_TX_KEEPER, 0); >=20 > Actually this does _KEEP but not _FILL. _KEEPER is the important one. _FILL just controls the behaviour of the bus keeper (zero or Hi-Z) when _KEEPER is set. If _KEEPER is cleared, the bus keeper is turned off and the value of _FILL doesn't matter.