From: Sven Peter <sven@kernel.org>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Rob Herring <robh@kernel.org>,
Saravana Kannan <saravanak@kernel.org>,
Daniel Golle <daniel@makrotopia.org>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
asahi@lists.linux.dev
Subject: Re: [PATCH 2/2] dt-check-style: Handle indented fragments in indent-consistent
Date: Tue, 1 Sep 2026 10:49:05 +0200 [thread overview]
Message-ID: <8e3633ca-6e82-4c2e-b441-adeac02d3eff@kernel.org> (raw)
In-Reply-To: <20260901-platinum-dalmatian-of-intensity-b18743@quoll>
On 9/1/26 10:22, Krzysztof Kozlowski wrote:
> On Sun, Aug 30, 2026 at 08:24:55PM +0200, Sven Peter wrote:
>> diff --git a/scripts/dtc/dt-style-selftest/expected/dts-fragment-indent.dtsi.txt b/scripts/dtc/dt-style-selftest/expected/dts-fragment-indent.dtsi.txt
>> new file mode 100644
>> index 000000000000..84ec8eb73468
>> --- /dev/null
>> +++ b/scripts/dtc/dt-style-selftest/expected/dts-fragment-indent.dtsi.txt
>> @@ -0,0 +1,3 @@
>> +# mode=strict
>> +bad/dts-fragment-indent.dtsi:9: [indent-consistent] indent mismatch (expected depth 2 * '\t')
>> +bad/dts-fragment-indent.dtsi:10: [indent-consistent] indent mismatch (expected depth 2 * '\t')
>> diff --git a/scripts/dtc/dt-style-selftest/good/dts-fragment.dtsi b/scripts/dtc/dt-style-selftest/good/dts-fragment.dtsi
>> new file mode 100644
>> index 000000000000..58735112d3aa
>> --- /dev/null
>> +++ b/scripts/dtc/dt-style-selftest/good/dts-fragment.dtsi
>> @@ -0,0 +1,19 @@
>> +// SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
>> +/* Include fragment indented for its inclusion context. */
>> +
>> + bus@10000 {
> So here is a good example... and this is code is wrong.
>
> You CANNOT have MMIO node outside of MMIO bus or a new node outside of
> root node indented with one tab.
Fair enough, just ignore this series then.
I'll just do the whitespace fix then and un-indent the -dieX files for
apple which I think should make them pass the checker then.
Sven
next prev parent reply other threads:[~2026-09-01 8:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-30 18:24 [PATCH 0/2] dt-check-style support for indented include fragments Sven Peter
2026-08-30 18:24 ` [PATCH 1/2] dt-check-style: Handle indented fragments in indent-unit-dts Sven Peter
2026-09-01 8:21 ` Krzysztof Kozlowski
2026-08-30 18:24 ` [PATCH 2/2] dt-check-style: Handle indented fragments in indent-consistent Sven Peter
2026-09-01 8:22 ` Krzysztof Kozlowski
2026-09-01 8:49 ` Sven Peter [this message]
2026-09-01 9:40 ` Krzysztof Kozlowski
2026-09-01 9:53 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8e3633ca-6e82-4c2e-b441-adeac02d3eff@kernel.org \
--to=sven@kernel.org \
--cc=asahi@lists.linux.dev \
--cc=daniel@makrotopia.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=saravanak@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox