From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DFF284420 for ; Tue, 14 Nov 2023 08:35:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=jannau.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=jannau.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=jannau.net header.i=@jannau.net header.b="PdWzvf2S"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="OlWZvFZi" Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 7DE443202312; Tue, 14 Nov 2023 03:35:51 -0500 (EST) Received: from imap53 ([10.202.2.103]) by compute1.internal (MEProxy); Tue, 14 Nov 2023 03:35:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jannau.net; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1699950951; x=1700037351; bh=3PkRuTsXewJgyFnJEAGNp7/muuh2dcfpARP RahjPeaw=; b=PdWzvf2SLKlIYYQ9ONE4quixniTTDzYEAxHhStJYEupaNVYz8K1 /hEiUg5wRmMkTrKpLBYnioLpL4fbklCe/aBwGEkZ2uokAydgP4Yip47+1dQEvYjF 3OLmFG2EtB7MlMSaT3A4qoKGyjPUG9c/mUpwiL4fFuJ3mnMAl6TLJ/z9BRYc/kC2 Bnji+oyKpnjyuegrKOfk4B/O0nomt485jv7/M6pNlo7ADWZTHLB4kNOAHfNboZ/8 w6nN6Ts/q3cuUG/j2GAyQ9fixM0+jkWiuXUQJ6rGIe+ZQyPojRgz/AYE2BthklUD POyZjgdvL7pLLHQUc/DPS015cfUiWLHpxWQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1699950951; x=1700037351; bh=3PkRuTsXewJgyFnJEAGNp7/muuh2dcfpARP RahjPeaw=; b=OlWZvFZiLN7EBGjXSJ4tCyaPDSBu7TVECV4GB9e4FVQ0g536vPB WZK8C5gN0PV2CXJACLxmWHq/2m01bjqjrBk0brX0f5n51m8MZkkgQudAsY0ogSCI nUU7LYtD2QfeCh5pTVNEMeQuGHpcen8hW9mGZPXuCjFNuMfxm+ur3xVrtfFvuDhU Ia3xji1EsX0bSUjVRXO0xhKf1PmQrUd+CBEUkMyrvHgbj76iYCdfLnD2QGj4kd42 AC1ZfCZC+nNOadcrLKoyH6ittMx3Y6WYL4uCx5K7Uq133rbqxSX04SMrOhIVL1p5 /K17fz6QMtklA0Uvub5F2FC/kwKHU5vS+sA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrudefuddguddvvdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefofgggkfgjfhffhffvvefutgfgsehtqhertderreejnecuhfhrohhmpedf lfgrnhhnvgcuifhruhhnrghufdcuoehjsehjrghnnhgruhdrnhgvtheqnecuggftrfgrth htvghrnhephfegteevteejheetgfeutddvuefgvdehiedufeelfeettdejgefgveevhfev feeinecuffhomhgrihhnpehprghsthgvsghinhdrtghomhenucevlhhushhtvghrufhiii gvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehjsehjrghnnhgruhdrnhgvth X-ME-Proxy: Feedback-ID: i47b949f6:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id 0E5F83640069; Tue, 14 Nov 2023 03:35:50 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.9.0-alpha0-1108-g3a29173c6d-fm-20231031.005-g3a29173c Precedence: bulk X-Mailing-List: asahi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <9308033b-971f-4cbf-9443-d41a3f09ac61@app.fastmail.com> In-Reply-To: <22582194-DE99-45E5-ABEE-C1C7900DA523@live.com> References: <22582194-DE99-45E5-ABEE-C1C7900DA523@live.com> Date: Tue, 14 Nov 2023 09:35:27 +0100 From: "Janne Grunau" To: "Aditya Garg" , "Hector Martin" , "Sven Peter" , "Alyssa Rosenzweig" , "marcel@holtmann.org" , "johan.hedberg@gmail.com" , "luiz.dentz@gmail.com" Cc: "Orlando Chamberlain" , "Kerem Karabay" , "Aun-Ali Zaidi" , "Asahi Linux" , LKML , "linux-bluetooth@vger.kernel.org" Subject: Re: [REGRESSION] Bluetooth is not working on Macs with BCM4377 chip starting from kernel 6.5 Content-Type: text/plain;charset=utf-8 Content-Transfer-Encoding: quoted-printable Hej, On Mon, Nov 13, 2023, at 21:57, Aditya Garg wrote: > Starting from kernel 6.5, a regression in the kernel is causing=20 > Bluetooth to not work on T2 Macs with BCM4377 chip. > > Journalctl of kernel 6.4.8 which has Bluetooth working is given here:=20 > https://pastebin.com/u9U3kbFJ > > Journalctl of kernel 6.5.2, which has Bluetooth broken is given here:=20 > https://pastebin.com/aVHNFMRs > > Also, the bug hasn=E2=80=99t been fixed even in 6.6.1, as reported by = users. There could be a possible regression in kernel 6.4 and later affecting B= luetooth low energy on bcm4377 devices specifically. 288c90224eec ("Blu= etooth: Enable all supported LE PHY by default") broke BLE connections o= n bcm4378 and bcm4387. I did not find any reports about broken BLE on bc= m4377 so I marked only bcm4378 and bcm4387 as broken with Coded Phy in 4= 1e9cdea9c4a ("Bluetooth: hci_bcm4377: Mark bcm4378/bcm4387 as BROKEN_LE_= CODED") If BLE devices like Logitech keyboards/mice are affected (mostly during= pairing) it would be worth testing the change below (against v6.7-rc or= stable releases): diff --git a/drivers/bluetooth/hci_bcm4377.c b/drivers/bluetooth/hci_bcm= 4377.c index a61757835695..bc8398cde3c3 100644 --- a/drivers/bluetooth/hci_bcm4377.c +++ b/drivers/bluetooth/hci_bcm4377.c @@ -2453,6 +2453,7 @@ static const struct bcm4377_hw bcm4377_hw_variants= [] =3D { .bar0_window2 =3D 0x1810c000, .disable_aspm =3D true, .broken_ext_scan =3D true, + .broken_le_coded =3D true, .send_ptb =3D bcm4377_send_ptb, }, =20 This should affect 6.4.8 as well so might be unrelated to the reported = issue. Janne