From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [78.32.30.218]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F03694416 for ; Mon, 5 Sep 2022 15:32:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=Pkv4WXNm7iE9vE05byre09zXOKz07p8cKrQykZtredI=; b=iFsIJjjSIt/lIDARm53CfftMma eLRKd3yzY0kSj9Mn2teC71wa+dCiE+wZ6l6XtUeKsdVhKMePTmuuAY+0vjJPzLi1D0uKB6gmrvBE1 W89fZsyvBlwxsuSnhRv2TFR22hzSONJ8yc1Tih7XBolErF9kA+TUE0a8wkkeHAq1iUK0b1kI7XLYd KYSkjNPC4j6v2mDH3W07cXNj9ItUq3hFT12c5clkUvXI3gKQd8otKdxa4onDCiv4bbHX9mdo1Z428 ycu+ULGq1TulWNzRPtUqECshbBEZZLmhIn7wA0pIsutCqRePJfS5U3u32LmpTkrLek0t2Z9O7yfAv +E1F74/A==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:34122) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1oVE50-0002Yf-DN; Mon, 05 Sep 2022 16:32:06 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1oVE4y-0007OT-PL; Mon, 05 Sep 2022 16:32:04 +0100 Date: Mon, 5 Sep 2022 16:32:04 +0100 From: "Russell King (Oracle)" To: Andy Shevchenko Cc: Arnd Bergmann , Lee Jones , Linus Walleij , Alyssa Rosenzweig , asahi@lists.linux.dev, Bartosz Golaszewski , Hector Martin , linux-arm Mailing List , "open list:GPIO SUBSYSTEM" , Sven Peter Subject: Re: [PATCH 5/6] gpio: Add new gpio-macsmc driver for Apple Macs Message-ID: References: Precedence: bulk X-Mailing-List: asahi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: Russell King (Oracle) On Mon, Sep 05, 2022 at 04:16:27PM +0300, Andy Shevchenko wrote: > On Mon, Sep 5, 2022 at 4:10 PM Russell King (Oracle) > wrote: > > On Mon, Sep 05, 2022 at 01:32:29PM +0300, Andy Shevchenko wrote: > > ... > > > Let me say again: I am not changing this. That's for Asahi people to > > do if they wish. I am the just middle-man here. > > While I agree on technical aspects, this mythical "they" is > frustrating me. They haven't participated in this discussion (yet?) so > they do not care, why should we (as a community of upstream)? > > P.S. Do you have a platform to test all these? Right, having addressed as many review comments as I possibly can, I've rebuilt and booted it on the platform - and the good news is, it still works _but_ I don't have enough support in the "mainline" kernel that I'm testing for anything to make use of any of the interrupt support in this patch set - so I can't actually test those changes. I'm going to drop the interrupt patch temporarily as it's unnecessary for what I want to do, which will be one less patch to worry about. I still need a resolution between you and Hector over the smc_key issue - specifically, do I pick up the patch that adds support for %p4ch, or do we re-architect the smc_key thing and also in doing so get rid of the need for your "endian conversion" thing. Given that Hector has rejected some of your comments, I now need to back out those changes that resulted from your NIH comments. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!