From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-187.mta1.migadu.com (out-187.mta1.migadu.com [95.215.58.187]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C80D5265CAD for ; Mon, 24 Feb 2025 18:10:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.187 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740420623; cv=none; b=XmlwGIOi1EvfCl+XT8BOUFp8+k3kuAOtUlb1oMoGvMzBGi108VRiyn5Cy2CciOBlm10ungezBHDYCgx7Sh5KdhPIf8TGRFkjvffCiSY7D2ice+sos4Sfq0jwwT65/BQ7APcsHmPpssfiBuaROaTig/ASFqshvgT9PvqdFTe3tZY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740420623; c=relaxed/simple; bh=K8beOpLbiTBb7WuCs45dhg2su3D6mrOfsgBQ3ukXY70=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=p4xICiFho2EEvWGLb3+nqeFCAQdywzJI7GvYJhY7GtSmWGcd0cv4Xdh+6iuhTgLwG2Hfb/OJC2+fklbZi6urbox0xSuHEi0LUSfgYK7nNkv6HlVqsG5eLEBw/yv5LPfNYv2AcHmYrFy7SXoP8xaP7yzNEOzHmlG93MoT+S686LE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=rosenzweig.io; spf=pass smtp.mailfrom=rosenzweig.io; dkim=pass (2048-bit key) header.d=rosenzweig.io header.i=@rosenzweig.io header.b=NtgrqWf2; arc=none smtp.client-ip=95.215.58.187 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=rosenzweig.io Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=rosenzweig.io Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=rosenzweig.io header.i=@rosenzweig.io header.b="NtgrqWf2" Date: Mon, 24 Feb 2025 13:10:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rosenzweig.io; s=key1; t=1740420619; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Hr9YqOCA8Y3071Ik6hsTPZ9M/v7Zg4ekFpBsl2WDaLY=; b=NtgrqWf2iPGHA0+vBammpPjvlGLIDfDmYo5fnf0gziuMNPJzJbQmocyMGO+ox2jCnZHARg jKyVbut4Vcpj5XI1V/JlarMPSv2qdzrDYvQrjBwvhG2OGPguFu4zspV2txlMsdwdYW8VvW IpJNM2SOaQs5k6zH803EMy44vyuBbMJSt6eJKemA9idbU7zqL+tlOxO+jqkTeiLnL7JIqH 1aJJ6hepTGrHbH98DJjANaM6UQG6JGABYSciCDiBJ9rna76wLRNzxqmi96uyzsOFH0mNPr brvBkZbWb2iUoMBMRQxb/GjsGXFo5Zo5ohwjSaHM0eZ5rR3rtNUMiE9qtr5mxw== X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Alyssa Rosenzweig To: sven@svenpeter.dev Cc: Janne Grunau , asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/4] soc: apple: rtkit: Use high prio work queue Message-ID: References: <20250222-apple-soc-misc-v1-0-1a3af494a48a@svenpeter.dev> <20250222-apple-soc-misc-v1-3-1a3af494a48a@svenpeter.dev> Precedence: bulk X-Mailing-List: asahi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20250222-apple-soc-misc-v1-3-1a3af494a48a@svenpeter.dev> X-Migadu-Flow: FLOW_OUT Reviewed-by: Alyssa Rosenzweig Le Sat , Feb 22, 2025 at 04:56:48PM +0000, Sven Peter via B4 Relay a écrit : > From: Janne Grunau > > rtkit messages as communication with the DCP firmware for framebuffer > swaps or input events are time critical so use WQ_HIGHPRI to prevent > user space CPU load to increase latency. > With kwin_wayland 6's explicit sync mode user space load was able to > delay the IOMFB rtkit communication enough to miss vsync for surface > swaps. Minimal test scenario is constantly resizing a glxgears > Xwayland window. > > Signed-off-by: Janne Grunau > Signed-off-by: Sven Peter > --- > drivers/soc/apple/rtkit.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/soc/apple/rtkit.c b/drivers/soc/apple/rtkit.c > index 35734ae8c9ce..b7f4654c3341 100644 > --- a/drivers/soc/apple/rtkit.c > +++ b/drivers/soc/apple/rtkit.c > @@ -695,7 +695,7 @@ struct apple_rtkit *apple_rtkit_init(struct device *dev, void *cookie, > rtk->mbox->rx = apple_rtkit_rx; > rtk->mbox->cookie = rtk; > > - rtk->wq = alloc_ordered_workqueue("rtkit-%s", WQ_MEM_RECLAIM, > + rtk->wq = alloc_ordered_workqueue("rtkit-%s", WQ_HIGHPRI | WQ_MEM_RECLAIM, > dev_name(rtk->dev)); > if (!rtk->wq) { > ret = -ENOMEM; > > -- > 2.34.1 > >