From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1AC622D6E4E for ; Mon, 11 Aug 2025 15:57:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754927866; cv=none; b=gazdQbUNoDIhE7gNIO9iPbgZEXNv5aYVjo1JC9jxgRYKgiBAA1Tf+O+K04PPXAP4qESfkl72Jfv9vQtcnEUEEWzdBDKt19pwVGZup5vfL+zIO+/S1yx2rZPJ1wuQ/6znLRw6Q/FVRpaFXKhiAyLq9g7X2K7Ah4u5kA4slJAWwts= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754927866; c=relaxed/simple; bh=07eO2bvYIRsiAjlhL5Ks2RMc74npsOWxeUj+fPHc9EM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: In-Reply-To:Content-Type:Content-Disposition; b=OrXEE3w6i1PCGU0FC3WBzER5GzfIjuO2CO/mV8k8UcU9M+G6vpp7k4HFmbYYTmNlFKBGYcCj8krfQjeWzek+waexI9CYHc3b7rmtrJkCckZuni66TG1hjj7lBnKD/BoQIrh1zroRTis813hJ/9sJZOSJ/CJ51QgmvLOrwLSb3jc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=GRQpjFmp; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="GRQpjFmp" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1754927864; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UPMcKR4Oi745bR8iqUsDP5qg1uYaCMtbYLompUhICNQ=; b=GRQpjFmpO5GdUEvVyF+h0OVLqDJTwrTSIpui3m9CjmTf/pnWP2ClxzKvGqyRv/ttEQMpzb 3qhJR2v5QEITh6AIU5Nwdoc8U1zPMpTesmg9PJyFcc9Rp9uKAJDjUlOhevm03uDkM2HvSR G1xA9jQ5uFe3SI7TDoMHdQ0UZI1Rcx0= Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-516-t8lwamJPNs6tzkU9qde9OQ-1; Mon, 11 Aug 2025 11:57:43 -0400 X-MC-Unique: t8lwamJPNs6tzkU9qde9OQ-1 X-Mimecast-MFC-AGG-ID: t8lwamJPNs6tzkU9qde9OQ_1754927862 Received: by mail-qv1-f72.google.com with SMTP id 6a1803df08f44-7074bad04efso100711786d6.1 for ; Mon, 11 Aug 2025 08:57:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754927862; x=1755532662; h=user-agent:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=UPMcKR4Oi745bR8iqUsDP5qg1uYaCMtbYLompUhICNQ=; b=K9vAYNbWhqjLKIThUO3CVgBl1a7wIlfiAcHnUpCKODTwCW7ECf+h6cRCaKBoRR8kk5 S1QaJ2guQB52umP98BzuPTNjTCIIcjBvqnagA0xwLLI6NoQ1030UQmZ+Q43OFAeuAuu8 HAdju5ziMcq5t2Qpxcfj8hHxdcO1mcKuqQutilKSTt32K6l2AKvor3Eh2ejXCVY1Q7h4 9QnQHgbzvbzMpafDdz+e8aGkJXS4bQD/BV6xKJ2MnbzSL9SPVsFLgLi1RuLrsDSAMZG0 LB/Q2QxS0bf2ATx677xVs4DLv0YA3XUC0FVl6Ne0w0itE/6YTZyKcOgmvUSiIhPVlXO+ Mm5Q== X-Forwarded-Encrypted: i=1; AJvYcCXo6/Fo1UA8gcib08Bj9lBUYjxfbWs8VhslWypi+5jvXo0SNQe7zkrRCWDNXBc5fMT/ScYo5g==@lists.linux.dev X-Gm-Message-State: AOJu0YxDH0M1IYmn37cKyJdamvgFRJEK679CqKMzp9hUmSDmO2EZHb7k GLy9gzdKhv7Afi4VXw4YHYkq6rMiTEhmiOdcdOB9ESjArGPf8QpGRpluI3hKY/p9GTMbmIf3FQJ fIPxehZLsuYOLDy6xaVRhy+fwPhv82z81xZG4NjLEVmy3TNhM2I2EpMIX X-Gm-Gg: ASbGncuLnOArj96Z5gAAaXnPRbg2fqNTYTS5MxXX6NcfmonghBf8uIZqmrd/0YKF19O ZDUSqm24ZHxvPmyHtlfnuzoLEMoyZL6+RsSwA64XAZ4juTNAC2J8ex8Is0SCJWW8HzCDpiWXbkV uU9CXGEdF+rs1gnAOtV68p9xb+vdXB0iIOz6IBxhzdegYLghyYoKkj4DoKS6RznjXk+BLDXE1m1 On1bOKfC49gQamj/Iu5BoRPhStvK4KubTuS/mD1+gHv0Ch2IqawhJnPWfmZRGyp+dBKPoVZrV/1 KdsIIFLoMuu+Z2UCvSnch0psXr+M/aLyte/BTQkTKVCIBtLfVI0j3jBLLoowVoA= X-Received: by 2002:ad4:5fce:0:b0:707:612d:3adb with SMTP id 6a1803df08f44-709d69b2c0emr1134786d6.18.1754927862142; Mon, 11 Aug 2025 08:57:42 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE83iNLxuXWBRGJIeIFUZHblancM50VRXiEQcjWFBbyuLTm1IZWPJbr6gZfh6Uj5SzS3+J40w== X-Received: by 2002:ad4:5fce:0:b0:707:612d:3adb with SMTP id 6a1803df08f44-709d69b2c0emr1133886d6.18.1754927861515; Mon, 11 Aug 2025 08:57:41 -0700 (PDT) Received: from x1 (c-73-183-52-120.hsd1.pa.comcast.net. [73.183.52.120]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-7077cde5b4esm155566456d6.69.2025.08.11.08.57.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Aug 2025 08:57:40 -0700 (PDT) Date: Mon, 11 Aug 2025 11:57:34 -0400 From: Brian Masney To: Alexander Sverdlin Cc: Michael Turquette , Stephen Boyd , Sudeep Holla , Cristian Marussi , Chen Wang , Inochi Amaoto , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Paul Cercueil , Keguang Zhang , Taichi Sugaya , Takao Orito , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Jacky Huang , Shan-Chun Hung , Vladimir Zapolskiy , Piotr Wojtaszczyk , Paul Walmsley , Samuel Holland , Yixun Lan , Steen Hegelund , Daniel Machon , UNGLinuxDriver@microchip.com, Orson Zhai , Baolin Wang , Chunyan Zhang , Maxime Coquelin , Alexandre Torgue , Michal Simek , Maxime Ripard , Andreas =?iso-8859-1?Q?F=E4rber?= , Manivannan Sadhasivam , Sven Peter , Janne Grunau , Alyssa Rosenzweig , Neal Gompa , Eugeniy Paltsev , Ray Jui , Scott Branden , Broadcom internal kernel review list , Max Filippov , Matthias Brugger , AngeloGioacchino Del Regno , Daniel Palmer , Romain Perier , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Bjorn Andersson , Geert Uytterhoeven , Heiko Stuebner , Andrea della Porta , Krzysztof Kozlowski , Sylwester Nawrocki , Chanwoo Choi , Alim Akhtar , Qin Jian , Viresh Kumar , Ulf Hansson , Luca Ceresoli , Alex Helms , Linus Walleij , Liviu Dudau , Lorenzo Pieralisi , Nobuhiro Iwamatsu , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, arm-scmi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, sophgo@lists.linux.dev, linux-mips@vger.kernel.org, imx@lists.linux.dev, linux-riscv@lists.infradead.org, spacemit@lists.linux.dev, linux-stm32@st-md-mailman.stormreply.com, patches@opensource.cirrus.com, linux-actions@lists.infradead.org, asahi@lists.linux.dev, linux-mediatek@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-samsung-soc@vger.kernel.org, soc@lists.linux.dev Subject: Re: [PATCH 048/114] clk: sophgo: sg2042-clkgen: convert from round_rate() to determine_rate() Message-ID: References: <20250811-clk-for-stephen-round-rate-v1-0-b3bf97b038dc@redhat.com> <20250811-clk-for-stephen-round-rate-v1-48-b3bf97b038dc@redhat.com> <9379f132e52c972b2735cad768242cb784b0ed2b.camel@gmail.com> Precedence: bulk X-Mailing-List: asahi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 In-Reply-To: <9379f132e52c972b2735cad768242cb784b0ed2b.camel@gmail.com> User-Agent: Mutt/2.2.14 (2025-02-20) X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: ijvHanuhFNqfSrKgIx2acWCHFTabxqDSKGJKaxFRm-M_1754927862 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit On Mon, Aug 11, 2025 at 05:45:57PM +0200, Alexander Sverdlin wrote: > On Mon, 2025-08-11 at 11:18 -0400, Brian Masney via B4 Relay wrote: > > @@ -192,15 +191,17 @@ static long sg2042_clk_divider_round_rate(struct clk_hw *hw, > >   bestdiv = readl(divider->reg) >> divider->shift; > >   bestdiv &= clk_div_mask(divider->width); > >   } > > - ret_rate = DIV_ROUND_UP_ULL((u64)*prate, bestdiv); > > + ret_rate = DIV_ROUND_UP_ULL((u64)*&req->best_parent_rate, bestdiv); > ^^ > May "*&" be redundand? Yes, I agree that needs dropped and something I missed when I cleaned things up by hand. I verified that this is the only case in this series, and all of the other series that I referenced on the cover letter, where this occurred. My Coccinelle semantic patch has a case when the parent rate is dereferenced, and I'm not sure why that wasn't converted here since it works elsewhere. long round_rate_name(struct clk_hw *hw_param, unsigned long rate_param, unsigned long *parent_rate_param) { <... ( - *parent_rate_param + req->best_parent_rate | - parent_rate_param + &req->best_parent_rate ) ...> } I'll wait a few weeks to send out a v2 to hopefully let big chunks of this series get merged so that I don't have to send out 114 patches again for a v2. Brian