Linux on Apple ARM platform development
 help / color / mirror / Atom feed
From: Hector Martin <marcan@marcan.st>
To: Sasha Finkelstein <fnkl.kernel@gmail.com>,
	u.kleine-koenig@pengutronix.de, thierry.reding@gmail.com,
	robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org
Cc: sven@svenpeter.dev, alyssa@rosenzweig.io, asahi@lists.linux.dev,
	linux-arm-kernel@lists.infradead.org, linux-pwm@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 4/5] arm64: dts: apple: t600x: Add PWM controller
Date: Sat, 7 Jan 2023 01:51:36 +0900	[thread overview]
Message-ID: <ced5bfbc-79f8-156a-32d5-27fe2be67236@marcan.st> (raw)
In-Reply-To: <20230106135839.18676-5-fnkl.kernel@gmail.com>

On 06/01/2023 22.58, Sasha Finkelstein wrote:
> Adds PWM controller and keyboard backlight bindings for M1 Pro/Max MacBook Pros
> 
> Signed-off-by: Sasha Finkelstein <fnkl.kernel@gmail.com>
> ---
>  arch/arm64/boot/dts/apple/t600x-die0.dtsi      |  9 +++++++++
>  arch/arm64/boot/dts/apple/t600x-j314-j316.dtsi | 18 ++++++++++++++++++
>  2 files changed, 27 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/apple/t600x-die0.dtsi b/arch/arm64/boot/dts/apple/t600x-die0.dtsi
> index 1c41954e3899..7065045dc43a 100644
> --- a/arch/arm64/boot/dts/apple/t600x-die0.dtsi
> +++ b/arch/arm64/boot/dts/apple/t600x-die0.dtsi
> @@ -154,6 +154,15 @@ i2c5: i2c@39b054000 {
>  		status = "disabled";
>  	};
>  
> +	fpwm0: pwm@39b030000 {
> +		compatible = "apple,t6000-fpwm", "apple,s5l-fpwm";
> +		reg = <0x3 0x9b030000 0x0 0x4000>;
> +		power-domains = <&ps_fpwm0>;
> +		clocks = <&clkref>;
> +		#pwm-cells = <2>;
> +		status = "disabled";
> +	};
> +

We usually keep device nodes sorted by address, so this is out of order
and should come before i2c (at least). No need to respin just for this
though, I can fix it when I apply it, so:

Acked-by: Hector Martin <marcan@marcan.st>

Maintainers: as we usually ask, please merge only the driver commit (#2)
via the PWM tree, we'll take care of DTs/MAINTAINERS/bindings via
asahi-soc so we can avoid serializing/blocking other DT changes.

- Hector

  reply	other threads:[~2023-01-06 16:51 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-06 13:58 [PATCH v6 0/5] PWM and keyboard backlight driver for ARM Macs Sasha Finkelstein
2023-01-06 13:58 ` [PATCH v6 1/5] dt-bindings: pwm: Add Apple PWM controller Sasha Finkelstein
2023-01-06 13:58 ` [PATCH v6 2/5] " Sasha Finkelstein
2023-01-10 23:06   ` Uwe Kleine-König
2023-01-13 18:25     ` Sasha Finkelstein
2023-01-13 18:39       ` Uwe Kleine-König
2023-01-06 13:58 ` [PATCH v6 3/5] arm64: dts: apple: t8103: Add " Sasha Finkelstein
2023-01-06 13:58 ` [PATCH v6 4/5] arm64: dts: apple: t600x: " Sasha Finkelstein
2023-01-06 16:51   ` Hector Martin [this message]
2023-01-06 13:58 ` [PATCH v6 5/5] MAINTAINERS: Add entries for Apple PWM driver Sasha Finkelstein

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ced5bfbc-79f8-156a-32d5-27fe2be67236@marcan.st \
    --to=marcan@marcan.st \
    --cc=alyssa@rosenzweig.io \
    --cc=asahi@lists.linux.dev \
    --cc=devicetree@vger.kernel.org \
    --cc=fnkl.kernel@gmail.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pwm@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=sven@svenpeter.dev \
    --cc=thierry.reding@gmail.com \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox