From: "Sven Peter" <sven@svenpeter.dev>
To: "Min-Hua Chen" <minhuadotchen@gmail.com>,
"Hector Martin" <marcan@marcan.st>,
"Alyssa Rosenzweig" <alyssa@rosenzweig.io>,
"Joerg Roedel" <joro@8bytes.org>, "Will Deacon" <will@kernel.org>,
"Robin Murphy" <robin.murphy@arm.com>
Cc: asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
iommu@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iommu/apple-dart: mark apple_dart_pm_ops static
Date: Thu, 20 Jul 2023 20:53:26 +0200 [thread overview]
Message-ID: <f176c331-f8cf-4a44-8ada-7d9c958b17ca@app.fastmail.com> (raw)
In-Reply-To: <20230719222033.117513-1-minhuadotchen@gmail.com>
On Thu, Jul 20, 2023, at 00:20, Min-Hua Chen wrote:
> This patch fixes the following sprse warning:
typo: sparse
>
> drivers/iommu/apple-dart.c:1279:1: sparse: warning: symbol
> 'apple_dart_pm_ops' was not declared. Should it be static?
>
> No functional change intended.
>
> Signed-off-by: Min-Hua Chen <minhuadotchen@gmail.com>
> ---
Acked-by: Sven Peter <sven@svenpeter.dev>
Thanks,
Sven
> drivers/iommu/apple-dart.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iommu/apple-dart.c b/drivers/iommu/apple-dart.c
> index 8af64b57f048..2082081402d3 100644
> --- a/drivers/iommu/apple-dart.c
> +++ b/drivers/iommu/apple-dart.c
> @@ -1276,7 +1276,7 @@ static __maybe_unused int
> apple_dart_resume(struct device *dev)
> return 0;
> }
>
> -DEFINE_SIMPLE_DEV_PM_OPS(apple_dart_pm_ops, apple_dart_suspend,
> apple_dart_resume);
> +static DEFINE_SIMPLE_DEV_PM_OPS(apple_dart_pm_ops, apple_dart_suspend,
> apple_dart_resume);
>
> static const struct of_device_id apple_dart_of_match[] = {
> { .compatible = "apple,t8103-dart", .data = &apple_dart_hw_t8103 },
> --
> 2.34.1
next prev parent reply other threads:[~2023-07-20 18:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-19 22:20 [PATCH] iommu/apple-dart: mark apple_dart_pm_ops static Min-Hua Chen
2023-07-20 18:53 ` Sven Peter [this message]
2023-07-20 23:18 ` Min-Hua Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f176c331-f8cf-4a44-8ada-7d9c958b17ca@app.fastmail.com \
--to=sven@svenpeter.dev \
--cc=alyssa@rosenzweig.io \
--cc=asahi@lists.linux.dev \
--cc=iommu@lists.linux.dev \
--cc=joro@8bytes.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcan@marcan.st \
--cc=minhuadotchen@gmail.com \
--cc=robin.murphy@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox