From: Marek Vasut <marex@denx.de>
To: j@jannau.net, Bin Meng <bmeng.cn@gmail.com>,
Tom Rini <trini@konsulko.com>, Simon Glass <sjg@chromium.org>,
Joe Hershberger <joe.hershberger@ni.com>
Cc: u-boot@lists.denx.de, asahi@lists.linux.dev, Neal Gompa <neal@gompa.dev>
Subject: Re: [PATCH v3 4/6] usb: Add environment based device ignorelist
Date: Fri, 22 Mar 2024 12:56:37 +0100 [thread overview]
Message-ID: <fcc7e54e-5e52-4b27-bc0c-801954ccf0ca@denx.de> (raw)
In-Reply-To: <20240322-asahi-keyboards-v3-4-3106dd4c4e19@jannau.net>
On 3/22/24 8:47 AM, Janne Grunau via B4 Relay wrote:
[...]
> @@ -1099,6 +1142,20 @@ int usb_select_config(struct usb_device *dev)
> le16_to_cpus(&dev->descriptor.idProduct);
> le16_to_cpus(&dev->descriptor.bcdDevice);
>
> + /* ignore devices from usb_ignorelist */
> + err = usb_device_is_ignored(dev->descriptor.idVendor,
> + dev->descriptor.idProduct);
> + if (err == -ENODEV) {
> + dev_dbg(dev->dev, "Ignoring USB device 0x%x:0x%x\n",
> + dev->descriptor.idVendor, dev->descriptor.idProduct);
> + return err;
> + } else if (err == -EINVAL) {
> + printf("usb_ignorelist parse error in \"%s\"\n",
> + env_get("usb_ignorelist"));
Please use dev_err() here consistently with dev_dbg() above.
With that fixed:
Reviewed-by: Marek Vasut <marex@denx.de>
Thanks !
next prev parent reply other threads:[~2024-03-22 11:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-22 7:47 [PATCH v3 0/6] USB keyboard improvements for asahi / desktop systems Janne Grunau via B4 Relay
2024-03-22 7:47 ` [PATCH v3 1/6] usb: xhci: refactor xhci_set_configuration Janne Grunau via B4 Relay
2024-03-22 7:47 ` [PATCH v3 2/6] usb: xhci: Set up endpoints for the first 2 interfaces Janne Grunau via B4 Relay
2024-03-22 8:17 ` Heinrich Schuchardt
2024-03-26 8:36 ` Janne Grunau
2024-03-22 7:47 ` [PATCH v3 3/6] usb: xhci: Abort transfers with unallocated rings Janne Grunau via B4 Relay
2024-03-22 7:47 ` [PATCH v3 4/6] usb: Add environment based device ignorelist Janne Grunau via B4 Relay
2024-03-22 11:56 ` Marek Vasut [this message]
2024-03-26 8:40 ` Janne Grunau
2024-03-26 11:29 ` Marek Vasut
2024-03-22 7:47 ` [PATCH v3 5/6] usb: kbd: support Apple Magic Keyboards (2021) Janne Grunau via B4 Relay
2024-03-22 7:47 ` [PATCH v3 6/6] usb: kbd: Add probe quirk for Apple and Keychron keyboards Janne Grunau via B4 Relay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fcc7e54e-5e52-4b27-bc0c-801954ccf0ca@denx.de \
--to=marex@denx.de \
--cc=asahi@lists.linux.dev \
--cc=bmeng.cn@gmail.com \
--cc=j@jannau.net \
--cc=joe.hershberger@ni.com \
--cc=neal@gompa.dev \
--cc=sjg@chromium.org \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox