From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail29.static.mailgun.info ([104.130.122.29]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jw2NS-00058s-6p for ath10k@lists.infradead.org; Thu, 16 Jul 2020 11:48:39 +0000 From: "Rakesh Pillai" References: <1593238973-23237-1-git-send-email-pillair@codeaurora.org> <926301ed-e27f-0d8f-0177-6484bfffa40c@candelatech.com> <000201d64d0a$b3d39d10$1b7ad730$@codeaurora.org> <859a8ffb-6108-81f3-b379-4a0adfa064fe@candelatech.com> In-Reply-To: <859a8ffb-6108-81f3-b379-4a0adfa064fe@candelatech.com> Subject: RE: [PATCH] ath10k: Add history for tracking certain events Date: Thu, 16 Jul 2020 17:18:22 +0530 Message-ID: <008501d65b67$0743a0c0$15cae240$@codeaurora.org> MIME-Version: 1.0 Content-Language: en-us List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: 'Ben Greear' , ath10k@lists.infradead.org Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org > -----Original Message----- > From: Ben Greear > Sent: Sunday, June 28, 2020 10:56 PM > To: Rakesh Pillai ; ath10k@lists.infradead.org > Cc: linux-wireless@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: Re: [PATCH] ath10k: Add history for tracking certain events > > > > On 06/27/2020 10:12 PM, Rakesh Pillai wrote: > > > > > >> -----Original Message----- > >> From: Ben Greear > >> Sent: Saturday, June 27, 2020 8:58 PM > >> To: Rakesh Pillai ; ath10k@lists.infradead.org > >> Cc: linux-wireless@vger.kernel.org; linux-kernel@vger.kernel.org > >> Subject: Re: [PATCH] ath10k: Add history for tracking certain events > >> > >> > >> > >> On 06/26/2020 11:22 PM, Rakesh Pillai wrote: > >>> For debugging many issues, a history of the > >>> below mentioned events can help get an idea > >>> of what exactly was going on just before any > >>> issue occurred in the system. These event > >>> history will be collected only when the host > >>> driver is run in debug mode (i.e. with the > >>> config ATH10K_DEBUG enabled). > >> > >> This should be disabled by default unless user specifically pokes some > >> debugfs > >> value to turn it on so that it does not impact performance. > > > > Hi Ben, > > This history is enabled only if the user compiles the kernel with > > ATH10K_DEBUG. > > Making it runtime, adds a lot of "if" conditions for this history record. > > Do you suggest to add support to enable/disable it runtime even in > > ATH10K_DEBUG ? > > Yes, because you are adding lots of locks/unlocks. That is way more > expensive > than an if statement. You can add an 'unlikely' to the if check as well, so > compiler will optimize for this feature not being enabled. Hi Ben, I missed this mail somehow. Yes sure, I will make the necessary changes and upload a new patchset. Thanks, Rakesh Pillai. > > Thanks, > Ben > > > > >> > >> Thanks, > >> Ben > >> > >>> > >>> Add history for tracking the below events > >>> - register read > >>> - register write > >>> - IRQ trigger > >>> - IRQ Enable > >>> - IRQ Disable > >>> - NAPI poll > >>> - CE service > >>> - WMI cmd > >>> - WMI event > >>> - WMI tx completion > >>> > >>> This will help in debugging any crash or any > >>> improper behaviour. > >> > >> > >> -- > >> Ben Greear > >> Candela Technologies Inc http://www.candelatech.com > > > > -- > Ben Greear > Candela Technologies Inc http://www.candelatech.com _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k