ATH10K Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Marc Gonzalez <mgonzalez@freebox.fr>
To: Kalle Valo <kvalo@kernel.org>,
	Bjorn Andersson <quic_bjorande@quicinc.com>
Cc: Jeff Johnson <quic_jjohnson@quicinc.com>,
	ath10k <ath10k@lists.infradead.org>,
	wireless <linux-wireless@vger.kernel.org>,
	DT <devicetree@vger.kernel.org>,
	MSM <linux-arm-msm@vger.kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Pierre-Hugues Husson <phhusson@freebox.fr>,
	Arnaud Vrac <avrac@freebox.fr>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konrad.dybcio@linaro.org>,
	Jami Kettunen <jamipkettunen@gmail.com>,
	Jeffrey Hugo <quic_jhugo@quicinc.com>,
	Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
	Alexey Minnekhanov <alexeymin@postmarketos.org>
Subject: Re: [PATCH v3 2/3] wifi: ath10k: do not always wait for MSA_READY indicator
Date: Tue, 30 Apr 2024 13:15:42 +0200	[thread overview]
Message-ID: <0a242bc1-fe8a-439b-96cb-bebdf2ada7d7@freebox.fr> (raw)
In-Reply-To: <ZjBWUvdEI6aq4s6M@hu-bjorande-lv.qualcomm.com>

On 30/04/2024 04:24, Bjorn Andersson wrote:

> On Mon, Apr 29, 2024 at 04:06:29PM +0200, Marc Gonzalez wrote:
>
>> The ath10k driver waits for an "MSA_READY" indicator
>> to complete initialization. If the indicator is not
>> received, then the device remains unusable.
>>
>> Several msm8998-based devices are affected by this issue.
>> Oddly, it seems safe to NOT wait for the indicator, and
>> proceed immediately when QMI_EVENT_SERVER_ARRIVE.
>>
>> fw_version 0x100204b2
>> fw_build_timestamp 2019-09-04 03:01
>> fw_build_id QC_IMAGE_VERSION_STRING=WLAN.HL.1.0-01202-QCAHLSWMTPLZ-1.221523.2
>>
>> Jeff Johnson wrote:
>>
>>   The feedback I received was "it might be ok to change all ath10k qmi
>>   to skip waiting for msa_ready", and it was pointed out that ath11k
>>   (and ath12k) do not wait for it.
>>
>>   However with so many deployed devices, "might be ok" isn't a strong
>>   argument for changing the default behavior.
>>
>> Signed-off-by: Pierre-Hugues Husson <phhusson@freebox.fr>
>> Signed-off-by: Marc Gonzalez <mgonzalez@freebox.fr>
> 
> As with patch 1, please address the s-o-b and accept my:
> 
> Reviewed-by: Bjorn Andersson <quic_bjorande@quicinc.com>

As with patch 1,
I typed this patch all by myself with my grubby little paws.
You can drop PH's S-o-b.

Regards



  reply	other threads:[~2024-04-30 11:15 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-29 14:01 [PATCH v3 0/3] Work around missing MSA_READY indicator for msm8998 devices Marc Gonzalez
2024-04-29 14:04 ` [PATCH v3 1/3] dt-bindings: net: wireless: ath10k: add qcom,no-msa-ready-indicator prop Marc Gonzalez
2024-04-30  2:22   ` Bjorn Andersson
2024-04-30  4:06     ` Kalle Valo
2024-04-30 11:10       ` Marc Gonzalez
2024-05-06 12:16         ` Kalle Valo
2024-05-07 17:03         ` Kalle Valo
2024-05-13  8:47           ` Marc Gonzalez
2024-04-30 14:39   ` Jeff Johnson
2024-05-07 15:05   ` Rob Herring (Arm)
2024-05-13 14:16   ` Kalle Valo
2024-05-28  9:54     ` Marc Gonzalez
2024-05-28 10:11       ` Kalle Valo
2024-05-28 12:36         ` Marc Gonzalez
2024-05-28 13:34           ` Kalle Valo
2024-04-29 14:06 ` [PATCH v3 2/3] wifi: ath10k: do not always wait for MSA_READY indicator Marc Gonzalez
2024-04-30  2:24   ` Bjorn Andersson
2024-04-30 11:15     ` Marc Gonzalez [this message]
2024-04-30 14:39   ` Jeff Johnson
2024-04-29 14:07 ` [PATCH v3 3/3] arm64: dts: qcom: msm8998: set qcom,no-msa-ready-indicator for wifi Marc Gonzalez
2024-04-30 14:40   ` Jeff Johnson
2024-05-06 10:39   ` Marc Gonzalez
2024-05-07 11:06     ` Konrad Dybcio
2024-04-29 23:24 ` [PATCH v3 0/3] Work around missing MSA_READY indicator for msm8998 devices Bryan O'Donoghue
2024-04-30  2:18   ` Bjorn Andersson
2024-05-29  2:01 ` (subset) " Bjorn Andersson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0a242bc1-fe8a-439b-96cb-bebdf2ada7d7@freebox.fr \
    --to=mgonzalez@freebox.fr \
    --cc=alexeymin@postmarketos.org \
    --cc=andersson@kernel.org \
    --cc=ath10k@lists.infradead.org \
    --cc=avrac@freebox.fr \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=jamipkettunen@gmail.com \
    --cc=konrad.dybcio@linaro.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=kvalo@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=phhusson@freebox.fr \
    --cc=quic_bjorande@quicinc.com \
    --cc=quic_jhugo@quicinc.com \
    --cc=quic_jjohnson@quicinc.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox