From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from ushosting.nmnhosting.com ([167.160.173.127]) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hFz6Y-0007eZ-Rj for ath10k@lists.infradead.org; Mon, 15 Apr 2019 10:44:52 +0000 From: "Alastair D'Silva" References: <20190410031720.11067-1-alastair@au1.ibm.com> <20190410031720.11067-4-alastair@au1.ibm.com> <20190412141211.lvnz6wb7mwkykmxf@pathway.suse.cz> <093301d4f187$da0756a0$8e1603e0$@d-silva.org> <20190415092424.qos7d54nbyr5hphu@pathway.suse.cz> <0da301d4f373$01d5bb80$05813280$@d-silva.org> <10c791893f034c26b4fee1a4659133e5@AcuMS.aculab.com> In-Reply-To: <10c791893f034c26b4fee1a4659133e5@AcuMS.aculab.com> Subject: RE: [PATCH 3/4] lib/hexdump.c: Replace ascii bool in hex_dump_to_buffer with flags Date: Mon, 15 Apr 2019 20:44:39 +1000 Message-ID: <0db501d4f378$3bd50bb0$b37f2310$@d-silva.org> MIME-Version: 1.0 Content-Language: en-au List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: 'David Laight' , 'Petr Mladek' Cc: linux-fbdev@vger.kernel.org, 'Stanislaw Gruszka' , 'David Airlie' , 'Joonas Lahtinen' , dri-devel@lists.freedesktop.org, devel@driverdev.osuosl.org, linux-scsi@vger.kernel.org, 'Jassi Brar' , ath10k@lists.infradead.org, intel-gfx@lists.freedesktop.org, 'Jose Abreu' , 'Tom Lendacky' , "'James E.J. Bottomley'" , 'Jani Nikula' , linux-fsdevel@vger.kernel.org, 'Steven Rostedt' , 'Rodrigo Vivi' , 'Benson Leung' , 'Kalle Valo' , 'Karsten Keil' , 'Alastair D'Silva' , "'Martin K. Petersen'" , 'Greg Kroah-Hartman' , linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, 'Sergey Senozhatsky' , 'Daniel Vetter' , netdev@vger.kernel.org, 'Enric Balletbo i Serra' , 'Andrew Morton' , "'David S. Miller'" , 'Alexander Viro' > -----Original Message----- > From: David Laight > Sent: Monday, 15 April 2019 8:21 PM > To: 'Alastair D'Silva' ; 'Petr Mladek' > > Cc: 'Alastair D'Silva' ; 'Jani Nikula' > ; 'Joonas Lahtinen' > ; 'Rodrigo Vivi' ; > 'David Airlie' ; 'Daniel Vetter' ; 'Karsten > Keil' ; 'Jassi Brar' ; 'Tom > Lendacky' ; 'David S. Miller' > ; 'Jose Abreu' ; 'Kalle > Valo' ; 'Stanislaw Gruszka' ; > 'Benson Leung' ; 'Enric Balletbo i Serra' > ; 'James E.J. Bottomley' > ; 'Martin K. Petersen' ; > 'Greg Kroah-Hartman' ; 'Alexander Viro' > ; 'Sergey Senozhatsky' > ; 'Steven Rostedt' > ; 'Andrew Morton' ; > intel-gfx@lists.freedesktop.org; dri-devel@lists.freedesktop.org; linux- > kernel@vger.kernel.org; netdev@vger.kernel.org; > ath10k@lists.infradead.org; linux-wireless@vger.kernel.org; linux- > scsi@vger.kernel.org; linux-fbdev@vger.kernel.org; > devel@driverdev.osuosl.org; linux-fsdevel@vger.kernel.org > Subject: RE: [PATCH 3/4] lib/hexdump.c: Replace ascii bool in > hex_dump_to_buffer with flags > > From: Alastair D'Silva > > Sent: 15 April 2019 11:07 > ... > > In the above example the author only wants the hex output, while in > > other situations, both hex & ASCII output is desirable. If you just > > want ASCII output, the caller should just use a printk or one of it's > wrappers. > > Hexdump will 'sanitise' the ASCII. > This is functionality that doesn't exist in the current hexdump implementation (you always get the hex version). I think a better option would be to factor out the sanitisation and expose that as a separate function. > Although I think you'd want a 'no hex' flag to suppress the hex. > > Probably more useful flags are ones to suppress the address column. This is already supported by the prefix_type parameter - are you proposing that we eliminate the parameter & combine it with flags? > I've also used flags to enable (or disable) suppression of multiple lines of > zeros of constant bytes. > In that case you may want hexdump to return the flags for the next call when > a large buffer is being dumped in fragments. I'm afraid I don't quite follow here, hex_dump_to_buffer doesn't alter the flags, so the caller already knows it. -- Alastair D'Silva mob: 0423 762 819 skype: alastair_dsilva msn: alastair@d-silva.org blog: http://alastair.d-silva.org Twitter: @EvilDeece _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k