From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from eu-smtp-delivery-151.mimecast.com ([207.82.80.151]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hFyiS-0008NO-Rt for ath10k@lists.infradead.org; Mon, 15 Apr 2019 10:19:58 +0000 From: David Laight Subject: RE: [PATCH 3/4] lib/hexdump.c: Replace ascii bool in hex_dump_to_buffer with flags Date: Mon, 15 Apr 2019 10:20:56 +0000 Message-ID: <10c791893f034c26b4fee1a4659133e5@AcuMS.aculab.com> References: <20190410031720.11067-1-alastair@au1.ibm.com> <20190410031720.11067-4-alastair@au1.ibm.com> <20190412141211.lvnz6wb7mwkykmxf@pathway.suse.cz> <093301d4f187$da0756a0$8e1603e0$@d-silva.org> <20190415092424.qos7d54nbyr5hphu@pathway.suse.cz> <0da301d4f373$01d5bb80$05813280$@d-silva.org> In-Reply-To: <0da301d4f373$01d5bb80$05813280$@d-silva.org> Content-Language: en-US MIME-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: 'Alastair D'Silva' , 'Petr Mladek' Cc: "linux-fbdev@vger.kernel.org" , 'Stanislaw Gruszka' , 'David Airlie' , 'Joonas Lahtinen' , "dri-devel@lists.freedesktop.org" , "devel@driverdev.osuosl.org" , "linux-scsi@vger.kernel.org" , 'Jassi Brar' , "ath10k@lists.infradead.org" , "intel-gfx@lists.freedesktop.org" , 'Jose Abreu' , 'Tom Lendacky' , "'James E.J. Bottomley'" , 'Jani Nikula' , "linux-fsdevel@vger.kernel.org" , 'Steven Rostedt' , 'Rodrigo Vivi' , 'Benson Leung' , 'Kalle Valo' , 'Karsten Keil' , 'Alastair D'Silva' , "'Martin K. Petersen'" , 'Greg Kroah-Hartman' , "linux-wireless@vger.kernel.org" , "linux-kernel@vger.kernel.org" , 'Sergey Senozhatsky' , 'Daniel Vetter' , "netdev@vger.kernel.org" , 'Enric Balletbo i Serra' , 'Andrew Morton' , "'David S. Miller'" , 'Alexander Viro' From: Alastair D'Silva > Sent: 15 April 2019 11:07 ... > In the above example the author only wants the hex output, while in other > situations, both hex & ASCII output is desirable. If you just want ASCII > output, the caller should just use a printk or one of it's wrappers. Hexdump will 'sanitise' the ASCII. Although I think you'd want a 'no hex' flag to suppress the hex. Probably more useful flags are ones to suppress the address column. I've also used flags to enable (or disable) suppression of multiple lines of zeros of constant bytes. In that case you may want hexdump to return the flags for the next call when a large buffer is being dumped in fragments. David - Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales) _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k