Re: [PATCH V2] debugfs: don't assume sizeof(bool) to be 4 bytes

From: Arnd Bergmann <arnd@arndb.de>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: "moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER
	MANAGEM..." <alsa-devel@alsa-project.org>,
	Avri Altman <avri.altman@intel.com>,
	Stanislaw Gruszka <sgruszka@redhat.com>,
	Jiri Slaby <jirislaby@gmail.com>,
	"open list:DOCUMENTATION" <linux-doc@vger.kernel.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
	Jaroslav Kysela <perex@perex.cz>,
	"open list:MEMORY MANAGEMENT" <linux-mm@kvack.org>,
	Kalle Valo <kvalo@qca.qualcomm.com>,
	Emmanuel Grumbach <emmanuel.grumbach@intel.com>,
	Luciano Coelho <luciano.coelho@intel.com>,
	Richard Fitzgerald <rf@opensource.wolfsonmicro.com>,
	Ingo Molnar <mingo@kernel.org>,
	Hariprasad S <hariprasad@chelsio.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Davidlohr Bueso <dave@stgolabs.net>,
	Eliad Peller <eliad@wizery.com>, Joonsoo Kim <js1304@gmail.com>,
	Jonathan Corbet <corbet@lwn.net>, Joerg Roedel <joro@8bytes.org>,
	"open list:WOLFSON MICROELECTRONICS DRIVERS"
	<patches@opensource.wolfsonmicro.com>,
	Sebastian Ott <sebott@linux.vnet.ibm.com>,
	"open list:QUALCOMM ATHEROS ATH10K WIRELESS DRIVER"
	<ath10k@lists.infradead.org>,
	Intel Linux Wireless <ilw@linux.intel.com>,
	"open list:ACPI" <linux-acpi@vger.kernel.org>,
	Dmitry Monakhov <dmonakhov@openvz.org>,
	Nick Kossifidis <mickflemm@gmail.com>,
	Doug Thompson <dougthompson@xmission.com>,
	Gustavo Padovan <gustavo@padovan.org>,
	Sasha Levin <sasha.levin@oracle.com>,
	Tomas Winkler <tomas.winkler@intel.com>,
	sboyd@codeaurora.org,
	"open list:B43 WIRELESS DRIVER" <b43-dev@lists.infradead.org>,
	linaro-kernel@lists.linaro.org,
	Johan Hedberg <johan.hedberg@gmail.com>,
	Johannes Berg <johannes.berg@intel.com>,
	Mauro Carvalho Chehab <mchehab@osg.samsung.com>,
	Arik Nemtsov <arik@wizery.com>,
	Marcel Holtmann <marcel@holtmann.org>,
	David Rientjes <rientjes@google.com>,
	Michal Hocko <mhocko@suse.com>,
	Akinobu Mita <akinobu.mita@gmail.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Joe Perches <joe@perches.com>, Mark Brown <broonie@kernel.org>,
	Borislav Petkov <bp@alien8.de>, Oleg Nesterov <oleg@redhat.com>,
	Florian Fainelli <f.fainelli@gmail.com>,
	Charles Keepax <ckeepax@opensource.wolfsonmicro.com>,
	Mel Gorman <mgorman@suse.de>, Vlastimil Babka <vbabka@suse.cz>,
	"open list:EDAC-CORE" <linux-edac@vger.kernel.org>,
	"moderated list:ARM64 PORT AARCH64 ARCHITECTURE"
	<linux-arm-kernel@lists.infradead.org>,
	Haggai Eran <haggaie@mellanox.com>,
	"James E.J. Bottomley" <JBottomley@odin.com>,
	Alexander Duyck <alexander.h.duyck@redhat.com>,
	Chaya Rachel Ivgi <chaya.rachel.ivgi@intel.com>,
	"open list:CISCO SCSI HBA DRIVER" <linux-scsi@vger.kernel.org>,
	Brian Silverman <bsilver16384@gmail.com>,
	"Luis R. Rodriguez" <mcgrof@do-not-panic.com>,
	Greg KH <gregkh@linuxfoundation.org>,
	"open list:ULTRA-WIDEBAND UWB SUBSYSTEM:"
	<linux-usb@vger.kernel.org>,
	"open list:NETWORKING DRIVERS WIRELESS"
	<linux-wireless@vger.kernel.org>, Takashi Iwai <tiwai@suse.com>,
	Sesidhar Baddela <sebaddel@cisco.com>,
	open list <linux-kernel@vger.kernel.org>,
	Johannes Weiner <hannes@cmpxchg.org>,
	"open list:BLUETOOTH DRIVERS" <linux-bluetooth@vger.kernel.org>,
	"open list:AMD IOMMU AMD-VI" <iommu@lists.linux-foundation.org>,
	"open list:QUALCOMM ATHEROS ATH9K WIRELESS DRIVER"
	<ath9k-devel@lists.ath9k.org>, Rafael Wysocki <rjw@rjwysocki.net>,
	Narsimhulu Musini <nmusini@cisco.com>,
	Wang Long <long.wanglong@huawei.com>, Tejun Heo <tj@kernel.org>,
	Michael Kerrisk <mtk.manpages@gmail.com>,
	QCA ath9k Development <ath9k-devel@qca.qualcomm.com>,
	Len Brown <lenb@kernel.org>, Liam Girdwood <lgirdwood@gmail.com>,
	"open list:CXGB4 ETHERNET DRIVER CXGB4" <netdev@vger.kernel.org>,
	Larry Finger <Larry.Finger@lwfinger.net>
Subject: Re: [PATCH V2] debugfs: don't assume sizeof(bool) to be 4 bytes
Date: Tue, 15 Sep 2015 08:30:55 +0200	[thread overview]
Message-ID: <11729827.zzMdq0fFyE@wuerfel> (raw)
In-Reply-To: <20150915020438.GG32551@linux>

On Tuesday 15 September 2015 07:34:38 Viresh Kumar wrote:
> On 14-09-15, 09:03, Greg KH wrote:
> > What ever ones you think it is relevant for :)
> 
> "Relevant" is a relevant term :)
> 
> So, the patch which defined the type bool as _Bool was added in v2.6.19 :)
> 
> 6e2182874324 ("[PATCH] Generic boolean")
> 
> So, I will try at least for v3.10+ as they are used by a lot of
> people, as they are LTS kernels. But wasn't sure if I should do it
> right from 2.6.19.

I don't think there is any use in backporting the global type change,
that is too invasive and does not change much. The specific bug
in the acpi code dates back to when acpi_ec_add_debugfs() was
added in 2.6.36, so that is the earliest point it could be backported
to. Then again, as I said it is only a problem on big-endian 64-bit
architectures, and on ACPI that would specifically mean arm64, which
only very recently gained ACPI support, so backporting to 4.1 is probably
enough.

	Arnd

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k