From: Johannes Berg <johannes@sipsolutions.net>
To: Kalle Valo <kvalo@qca.qualcomm.com>
Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org
Subject: Re: [PATCH v8 2/4] ath10k: provide firmware crash info via debugfs
Date: Fri, 22 Aug 2014 03:19:15 +0200 [thread overview]
Message-ID: <1408670355.4388.4.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <877g21c3dd.fsf@kamboji.qca.qualcomm.com>
On Thu, 2014-08-21 at 17:40 +0300, Kalle Valo wrote:
> Heh, this has been a pretty long review period. To be honest I really
> would like to get this just out of my hands :) And we do have a need for
> this. When are you planning to implement that generic framework?
Soon (TM). We need it, so really, I should do it soon.
> What I understood is that this is already pretty close what you are
> planning. Instead of creating a debugfs file of our own and allocating a
> vmalloc buffer (which we do now), we would just use the buffer provided
> by cfg80211 (or whatever component that would be) and use the sysfs file
> the framework provides. So hopefully it would be pretty easy to convert
> this to use your framework.
I'm thinking now that since vmalloc space is limited on some
architectures, we should just have a list of pages, but of course we
could copy it there from vmalloc area.
Anyway, yes, it should be fairly simple to convert - but is it worth it
for you to have it now? Depends how you use it, I guess.
johannes
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
next prev parent reply other threads:[~2014-08-22 1:19 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-21 12:48 [PATCH v8 0/4] ath10k: firmware crash dump Kalle Valo
2014-08-21 12:49 ` [PATCH v8 1/4] ath10k: add ath10k_pci_diag_* helpers Kalle Valo
2014-08-21 12:49 ` [PATCH v8 2/4] ath10k: provide firmware crash info via debugfs Kalle Valo
2014-08-21 13:10 ` Johannes Berg
2014-08-21 14:40 ` Kalle Valo
2014-08-22 1:19 ` Johannes Berg [this message]
2014-08-22 14:34 ` Kalle Valo
2014-08-24 9:42 ` Johannes Berg
2014-08-22 6:49 ` Michal Kazior
2014-08-25 6:28 ` Kalle Valo
2014-08-21 12:49 ` [PATCH v8 3/4] ath10k: rename ath10k_pci_hif_dump_area() to ath10k_pci_fw_crashed_dump() Kalle Valo
2014-08-21 12:49 ` [PATCH v8 4/4] ath10k: print more driver info when firmware crashes Kalle Valo
2014-08-25 8:25 ` [PATCH v8 0/4] ath10k: firmware crash dump Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1408670355.4388.4.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=ath10k@lists.infradead.org \
--cc=kvalo@qca.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox