ATH10K Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Manoharan, Rajkumar" <rmanohar@qti.qualcomm.com>
To: Sebastian Gottschall <s.gottschall@dd-wrt.com>,
	"ath10k@lists.infradead.org" <ath10k@lists.infradead.org>,
	Rajkumar Manoharan <rmanohar@codeaurora.org>
Subject: Re: latest ath10k pending tree bug's
Date: Tue, 29 Mar 2016 11:02:27 +0000	[thread overview]
Message-ID: <1459249346817.95969@qti.qualcomm.com> (raw)
In-Reply-To: <276aecc9-73a9-d71e-5aac-69c4eacf38d8@dd-wrt.com>

> the new introduced code which initialized the precal data for new
> chipsets will break QCA99XX support.
> so ath10k fails to initialize.
> i commented out
> ret = ath10k_core_pre_cal_config(ar);
> and
>   ret = ath10k_core_pre_cal_download(ar);
> 
> to get it working again. this might not affect real pcie cards. but on
> IPQ8064 based boards with on board wifi cards it shows that behaviour.
> 
Can you please try below change?

diff --git a/drivers/net/wireless/ath/ath10k/core.h b/drivers/net/wireless/ath/ath10k/core.h
index ca45da3..cf90c87 100644
--- a/drivers/net/wireless/ath/ath10k/core.h
+++ b/drivers/net/wireless/ath/ath10k/core.h
@@ -725,10 +725,8 @@ struct ath10k {
        const void *firmware_data;
        size_t firmware_len;

-       union {
-               const struct firmware *pre_cal_file;
-               const struct firmware *cal_file;
-       };
+       const struct firmware *pre_cal_file;
+       const struct firmware *cal_file;

        struct {
                const void *firmware_codeswap_data;

> in addition this message here floods the kernel log
> [125917.204121] ath10k_pci 0001:01:00.0: failed to increase tx mgmt
> pending count: -16, dropping
> but it has no further visible side effects
> 
Yeah... It is harmless but better to lower debug level.

-Rajkumar
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

  reply	other threads:[~2016-03-29 11:02 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-22 11:52 [PATCH 0/9] ath10k: improve throughput performance Rajkumar Manoharan
2016-03-22 11:52 ` [PATCH 1/9] ath10k: speedup htt rx descriptor processing for tx completion Rajkumar Manoharan
2016-03-24 13:08   ` Valo, Kalle
2016-03-24 15:52     ` Manoharan, Rajkumar
2016-03-24 16:13       ` Manoharan, Rajkumar
2016-03-29  7:39       ` Valo, Kalle
2016-03-29  9:12         ` latest ath10k pending tree bug's Sebastian Gottschall
2016-03-29 11:02           ` Manoharan, Rajkumar [this message]
2016-03-29 16:02             ` Sebastian Gottschall
2016-03-22 11:52 ` [PATCH 2/9] ath10k: copy tx fetch indication message Rajkumar Manoharan
2016-03-22 11:52 ` [PATCH 3/9] ath10k: remove unused fw_desc processing Rajkumar Manoharan
2016-03-22 11:52 ` [PATCH 4/9] ath10k: cleanup amsdu processing for rx indication Rajkumar Manoharan
2016-03-22 11:52 ` [PATCH 5/9] ath10k: speedup htt rx descriptor processing for rx_ind Rajkumar Manoharan
2016-03-22 11:52 ` [PATCH 6/9] ath10k: register ath10k_htt_htc_t2h_msg_handler Rajkumar Manoharan
2016-03-22 11:52 ` [PATCH 7/9] ath10k: cleanup copy engine receive next completion Rajkumar Manoharan
2016-03-22 11:52 ` [PATCH 8/9] ath10k: reuse copy engine 5 (htt rx) descriptors Rajkumar Manoharan
2016-03-22 11:52 ` [PATCH 9/9] ath10k: combine txrx and replenish task Rajkumar Manoharan
2016-04-04 14:55 ` [PATCH 0/9] ath10k: improve throughput performance Valo, Kalle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1459249346817.95969@qti.qualcomm.com \
    --to=rmanohar@qti.qualcomm.com \
    --cc=ath10k@lists.infradead.org \
    --cc=rmanohar@codeaurora.org \
    --cc=s.gottschall@dd-wrt.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox