From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from wolverine02.qualcomm.com ([199.106.114.251]) by bombadil.infradead.org with esmtps (Exim 4.85_2 #1 (Red Hat Linux)) id 1bLVNq-0006et-W4 for ath10k@lists.infradead.org; Fri, 08 Jul 2016 12:59:55 +0000 From: "Manoharan, Rajkumar" Subject: Re: ath10k + iw set bitrates is causing FW crash Date: Fri, 8 Jul 2016 12:59:26 +0000 Message-ID: <1467982766213.21223@qti.qualcomm.com> References: <1467972560885.99812@qti.qualcomm.com>, In-Reply-To: Content-Language: en-US MIME-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Krishna Chaitanya Cc: linux-wireless , ath10k I think security failures are due to peer unmap & map upon reassoc. Can you please try below change? diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c index 5e1cc8f4c43c..f7f04bb46fc8 100644 --- a/drivers/net/wireless/ath/ath10k/mac.c +++ b/drivers/net/wireless/ath/ath10k/mac.c @@ -5745,8 +5745,9 @@ static void ath10k_sta_rc_update_wk(struct work_struct *wk) sta->addr, smps, err); } - if (changed & IEEE80211_RC_SUPP_RATES_CHANGED || - changed & IEEE80211_RC_NSS_CHANGED) { + if ((changed & IEEE80211_RC_SUPP_RATES_CHANGED || + changed & IEEE80211_RC_NSS_CHANGED) && + (arvif->vif->type == NL80211_IFTYPE_ADHOC)) { ath10k_dbg(ar, ATH10K_DBG_MAC, "mac update sta %pM supp rates/nss\n", sta->addr); -Rajkumar ________________________________________ From: Krishna Chaitanya Sent: Friday, July 8, 2016 5:26 PM To: Manoharan, Rajkumar Cc: linux-wireless; ath10k Subject: Re: ath10k + iw set bitrates is causing FW crash On Fri, Jul 8, 2016 at 3:39 PM, Manoharan, Rajkumar wrote: >>> I am using ath10k driver with qca988x hw2.0 and trying to limit it to use >>> VHT MCS0-7 (iw set bitrates vht-mcs-5 2:0-7). >>> >>> But the command it causing a FW crash, if it disable HW_HAS_RATE_CONTROL >>> no crash is observed but it still uses MCS9. >>> >>> tree: wireless-drivers-next: commit#535633a5ba4ea2504fa6c33176633becf0e59339 >>> >>> 1) If i disable HW_RATE_CONTROL, will ath10k honor >>> the mac80211 rates? >>> >> > Thanks for reporting the issue. Could you please try with below change? > > diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c > index 5e1cc8f4c43c..cfa7e01a6103 100644 > --- a/drivers/net/wireless/ath/ath10k/mac.c > +++ b/drivers/net/wireless/ath/ath10k/mac.c > @@ -2812,6 +2812,9 @@ static int ath10k_station_assoc(struct ath10k *ar, > return ret; > } > > + if (vif->type != NL80211_IFTYPE_ADHOC) > + peer_arg.peer_reassoc = reassoc; > + > ret = ath10k_wmi_peer_assoc(ar, &peer_arg); > if (ret) { > ath10k_warn(ar, "failed to run peer assoc for STA %pM vdev %i: %d\n", Thanks Raj, with this fix the rates are 0-7, if i disable then i am seeing 0-9, so its working. But i am seeing a weird issues, the moment i give bitrates command, ath10k no longer does encryption, link is a WPA2-PSK: AES. Even after interface up/down it doesn't work. _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k