From: "Manoharan, Rajkumar" <rmanohar@qti.qualcomm.com>
To: "greearb@candelatech.com" <greearb@candelatech.com>,
"ath10k@lists.infradead.org" <ath10k@lists.infradead.org>,
Rajkumar Manoharan <rmanohar@codeaurora.org>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] ath10k: ensure pdev sta kickout threshold is set.
Date: Tue, 6 Sep 2016 07:39:42 +0000 [thread overview]
Message-ID: <1473147582638.99419@qti.qualcomm.com> (raw)
In-Reply-To: <1472843202-12428-1-git-send-email-greearb@candelatech.com>
[...]
> +int ath10k_mac_set_pdev_kickout(struct ath10k *ar)
> +{
> + u32 param = ar->wmi.pdev_param->sta_kickout_th;
> + int rv;
> +
> + rv = ath10k_wmi_pdev_set_param(ar, param,
> + ar->sta_xretry_kickout_thresh);
> + if (rv) {
> + ath10k_warn(ar, "failed to set sta kickout threshold to %d: %d\n",
> + ar->sta_xretry_kickout_thresh, rv);
> + }
> + return rv;
> +}
>
Ben,
I plan to get rid of setting station kickout threshold from host. Each firmware revision (i.e qca988x, qca99x0, ipq4019) follows different logic based on hw capability for station kickout and follows different default paramters. So configuring common threshold will affect firmware logic. Better to get rid of these configuration from host driver and let firmware to work with default parameters.
Also I could not find out sta_xretry_kickout_thresh definition in upstream driver. Have you posted any changes for the same?
-Rajkumar
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
next prev parent reply other threads:[~2016-09-06 7:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-02 19:06 [PATCH] ath10k: ensure pdev sta kickout threshold is set greearb
2016-09-06 7:39 ` Manoharan, Rajkumar [this message]
2016-09-06 13:12 ` Ben Greear
2016-09-06 17:16 ` Rajkumar Manoharan
2016-09-06 17:26 ` Ben Greear
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1473147582638.99419@qti.qualcomm.com \
--to=rmanohar@qti.qualcomm.com \
--cc=ath10k@lists.infradead.org \
--cc=greearb@candelatech.com \
--cc=linux-wireless@vger.kernel.org \
--cc=rmanohar@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox