From: Johannes Berg <johannes@sipsolutions.net>
To: c_traja@qti.qualcomm.com, linux-wireless@vger.kernel.org
Cc: tamizhchelvam@codeaurora.org, ath10k@lists.infradead.org
Subject: Re: [PATCH 1/4] cfg80211: Add support to enable or disable btcoex
Date: Mon, 05 Dec 2016 15:46:01 +0100 [thread overview]
Message-ID: <1480949161.31788.23.camel@sipsolutions.net> (raw)
In-Reply-To: <1478610932-21954-2-git-send-email-c_traja@qti.qualcomm.com>
On Tue, 2016-11-08 at 18:45 +0530, c_traja@qti.qualcomm.com wrote:
> From: Tamizh chelvam <c_traja@qti.qualcomm.com>
>
> This patch adds support to enable or disable btcoex by
> adding NL80211_ATTR_WIPHY_BTCOEX_ENABLE attribute in
> NL80211_CMD_SET_WIPHY command. By default BTCOEX disabled in driver.
I think overloading SET_WIPHY even more is a mistake - why not group
this with the new command you're introducing in the second patch?
Also, can have a flag attribute to enable/disable, or better even
disable when you're not setting any other parameters.
johannes
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
next prev parent reply other threads:[~2016-12-05 14:46 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-08 13:15 [PATCH 0/4] cfg80211: mac80211: BTCOEX feature support c_traja
2016-11-08 13:15 ` [PATCH 1/4] cfg80211: Add support to enable or disable btcoex c_traja
2016-12-05 14:46 ` Johannes Berg [this message]
2016-12-07 11:04 ` Tamizh chelvam
2016-11-08 13:15 ` [PATCH 2/4] cfg80211: Add new NL80211_CMD_SET_BTCOEX_PRIORITY to support BTCOEX c_traja
2016-12-05 14:49 ` Johannes Berg
2016-12-07 17:59 ` Tamizh chelvam
2016-12-13 16:09 ` Johannes Berg
2016-12-16 5:53 ` Tamizh chelvam
2016-12-16 9:37 ` Johannes Berg
2016-12-19 8:11 ` Tamizh chelvam
2017-01-02 10:48 ` Johannes Berg
2017-01-05 13:18 ` Tamizh chelvam
2017-01-05 13:38 ` Johannes Berg
2017-01-09 10:10 ` Tamizh chelvam
2017-01-09 10:36 ` Johannes Berg
2017-01-19 13:52 ` Tamizh chelvam
2016-11-08 13:15 ` [PATCH 3/4] mac80211: Add support to enable or disable btcoex c_traja
2016-11-08 13:15 ` [PATCH 4/4] mac80211: Add support to update btcoex priority value c_traja
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1480949161.31788.23.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=ath10k@lists.infradead.org \
--cc=c_traja@qti.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
--cc=tamizhchelvam@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox