From: greearb@candelatech.com
To: ath10k@lists.infradead.org
Cc: kvalo@qca.qualcomm.com, linux-wireless@vger.kernel.org,
Ben Greear <greearb@candelatech.com>
Subject: [PATCH 2/3] ath10k: Don't try un-supported idle_ps_config command.
Date: Fri, 11 May 2018 14:42:10 -0700 [thread overview]
Message-ID: <1526074931-23885-2-git-send-email-greearb@candelatech.com> (raw)
In-Reply-To: <1526074931-23885-1-git-send-email-greearb@candelatech.com>
From: Ben Greear <greearb@candelatech.com>
The warning the the logs does not give user a clue as to what
command is failing, so it is worth it to check for un-supported
command before trying the call.
And add return-code to survey error message.
Signed-off-by: Ben Greear <greearb@candelatech.com>
---
drivers/net/wireless/ath/ath10k/mac.c | 14 +++++++++-----
1 file changed, 9 insertions(+), 5 deletions(-)
diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c
index 3d7119a..1185d0c2 100644
--- a/drivers/net/wireless/ath/ath10k/mac.c
+++ b/drivers/net/wireless/ath/ath10k/mac.c
@@ -4680,10 +4680,13 @@ static int ath10k_start(struct ieee80211_hw *hw)
}
param = ar->wmi.pdev_param->idle_ps_config;
- ret = ath10k_wmi_pdev_set_param(ar, param, 1);
- if (ret && ret != -EOPNOTSUPP) {
- ath10k_warn(ar, "failed to enable idle_ps_config: %d\n", ret);
- goto err_core_stop;
+ if (param != WMI_PDEV_PARAM_UNSUPPORTED) {
+ ret = ath10k_wmi_pdev_set_param(ar, param, 1);
+ if (ret) {
+ ath10k_warn(ar, "failed to enable idle_ps_config: %d\n",
+ ret);
+ goto err_core_stop;
+ }
}
__ath10k_set_antenna(ar, ar->cfg_tx_chainmask, ar->cfg_rx_chainmask);
@@ -6770,7 +6773,8 @@ ath10k_mac_update_bss_chan_survey(struct ath10k *ar,
ret = ath10k_wmi_pdev_bss_chan_info_request(ar, type);
if (ret) {
- ath10k_warn(ar, "failed to send pdev bss chan info request\n");
+ ath10k_warn(ar, "failed to send pdev bss chan info request: %d\n",
+ ret);
return;
}
--
2.4.11
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
next prev parent reply other threads:[~2018-05-11 21:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-11 21:42 [PATCH 1/3] ath10k: Add ath10k-ct firmware feature flags and descriptions greearb
2018-05-11 21:42 ` greearb [this message]
2018-05-11 21:42 ` [PATCH 3/3] ath10k: Support survey dump for ath10k-ct 10.1 firmware greearb
2018-05-11 22:07 ` [PATCH 1/3] ath10k: Add ath10k-ct firmware feature flags and descriptions Jeff Johnson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1526074931-23885-2-git-send-email-greearb@candelatech.com \
--to=greearb@candelatech.com \
--cc=ath10k@lists.infradead.org \
--cc=kvalo@qca.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox